* Re: [PATCH v2] net/bridge: Optimizing read-write locks in ebtables.c
[not found] <2860814445452DE8+20240924022437.119730-1-yushengjin@uniontech.com>
@ 2024-09-24 8:35 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-09-24 8:35 UTC (permalink / raw)
To: yushengjin, pablo
Cc: llvm, oe-kbuild-all, kadlec, roopa, razor, davem, edumazet, kuba,
pabeni, netfilter-devel, coreteam, bridge, netdev, linux-kernel,
yushengjin
Hi yushengjin,
kernel test robot noticed the following build errors:
[auto build test ERROR on netfilter-nf/main]
[also build test ERROR on horms-ipvs/master linus/master v6.11 next-20240924]
[cannot apply to nf-next/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/yushengjin/net-bridge-Optimizing-read-write-locks-in-ebtables-c/20240924-102547
base: https://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf.git main
patch link: https://lore.kernel.org/r/2860814445452DE8%2B20240924022437.119730-1-yushengjin%40uniontech.com
patch subject: [PATCH v2] net/bridge: Optimizing read-write locks in ebtables.c
config: mips-bmips_stb_defconfig (https://download.01.org/0day-ci/archive/20240924/202409241627.NkoKxMEE-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 8663a75fa2f31299ab8d1d90288d9df92aadee88)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240924/202409241627.NkoKxMEE-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409241627.NkoKxMEE-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from net/bridge/netfilter/ebtables.c:17:
In file included from include/linux/netfilter/x_tables.h:6:
In file included from include/linux/netdevice.h:38:
In file included from include/net/net_namespace.h:43:
In file included from include/linux/skbuff.h:17:
In file included from include/linux/bvec.h:10:
In file included from include/linux/highmem.h:8:
In file included from include/linux/cacheflush.h:5:
In file included from arch/mips/include/asm/cacheflush.h:13:
In file included from include/linux/mm.h:2232:
include/linux/vmstat.h:517:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
517 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
>> net/bridge/netfilter/ebtables.c:1006:16: error: use of undeclared identifier 'ebt_recseq'; did you mean 'xt_recseq'?
1006 | s = &per_cpu(ebt_recseq, cpu);
| ^~~~~~~~~~
| xt_recseq
include/linux/percpu-defs.h:269:43: note: expanded from macro 'per_cpu'
269 | #define per_cpu(var, cpu) (*per_cpu_ptr(&(var), cpu))
| ^
include/linux/percpu-defs.h:235:20: note: expanded from macro 'per_cpu_ptr'
235 | __verify_pcpu_ptr(ptr); \
| ^
include/linux/percpu-defs.h:219:47: note: expanded from macro '__verify_pcpu_ptr'
219 | const void __percpu *__vpp_verify = (typeof((ptr) + 0))NULL; \
| ^
include/linux/netfilter/x_tables.h:346:29: note: 'xt_recseq' declared here
346 | DECLARE_PER_CPU(seqcount_t, xt_recseq);
| ^
>> net/bridge/netfilter/ebtables.c:1006:16: error: use of undeclared identifier 'ebt_recseq'; did you mean 'xt_recseq'?
1006 | s = &per_cpu(ebt_recseq, cpu);
| ^~~~~~~~~~
| xt_recseq
include/linux/percpu-defs.h:269:43: note: expanded from macro 'per_cpu'
269 | #define per_cpu(var, cpu) (*per_cpu_ptr(&(var), cpu))
| ^
include/linux/percpu-defs.h:236:20: note: expanded from macro 'per_cpu_ptr'
236 | SHIFT_PERCPU_PTR((ptr), per_cpu_offset((cpu))); \
| ^
include/linux/percpu-defs.h:231:23: note: expanded from macro 'SHIFT_PERCPU_PTR'
231 | RELOC_HIDE((typeof(*(__p)) __kernel __force *)(__p), (__offset))
| ^
include/linux/compiler.h:177:31: note: expanded from macro 'RELOC_HIDE'
177 | __ptr = (unsigned long) (ptr); \
| ^
include/linux/netfilter/x_tables.h:346:29: note: 'xt_recseq' declared here
346 | DECLARE_PER_CPU(seqcount_t, xt_recseq);
| ^
>> net/bridge/netfilter/ebtables.c:1006:16: error: use of undeclared identifier 'ebt_recseq'; did you mean 'xt_recseq'?
1006 | s = &per_cpu(ebt_recseq, cpu);
| ^~~~~~~~~~
| xt_recseq
include/linux/percpu-defs.h:269:43: note: expanded from macro 'per_cpu'
269 | #define per_cpu(var, cpu) (*per_cpu_ptr(&(var), cpu))
| ^
include/linux/percpu-defs.h:236:20: note: expanded from macro 'per_cpu_ptr'
236 | SHIFT_PERCPU_PTR((ptr), per_cpu_offset((cpu))); \
| ^
include/linux/percpu-defs.h:231:49: note: expanded from macro 'SHIFT_PERCPU_PTR'
231 | RELOC_HIDE((typeof(*(__p)) __kernel __force *)(__p), (__offset))
| ^
include/linux/compiler.h:177:31: note: expanded from macro 'RELOC_HIDE'
177 | __ptr = (unsigned long) (ptr); \
| ^
include/linux/netfilter/x_tables.h:346:29: note: 'xt_recseq' declared here
346 | DECLARE_PER_CPU(seqcount_t, xt_recseq);
| ^
>> net/bridge/netfilter/ebtables.c:1006:16: error: use of undeclared identifier 'ebt_recseq'; did you mean 'xt_recseq'?
1006 | s = &per_cpu(ebt_recseq, cpu);
| ^~~~~~~~~~
| xt_recseq
include/linux/percpu-defs.h:269:43: note: expanded from macro 'per_cpu'
269 | #define per_cpu(var, cpu) (*per_cpu_ptr(&(var), cpu))
| ^
include/linux/percpu-defs.h:236:20: note: expanded from macro 'per_cpu_ptr'
236 | SHIFT_PERCPU_PTR((ptr), per_cpu_offset((cpu))); \
| ^
include/linux/percpu-defs.h:231:23: note: expanded from macro 'SHIFT_PERCPU_PTR'
231 | RELOC_HIDE((typeof(*(__p)) __kernel __force *)(__p), (__offset))
| ^
include/linux/compiler.h:178:13: note: expanded from macro 'RELOC_HIDE'
178 | (typeof(ptr)) (__ptr + (off)); })
| ^
include/linux/netfilter/x_tables.h:346:29: note: 'xt_recseq' declared here
346 | DECLARE_PER_CPU(seqcount_t, xt_recseq);
| ^
>> net/bridge/netfilter/ebtables.c:1006:16: error: use of undeclared identifier 'ebt_recseq'; did you mean 'xt_recseq'?
1006 | s = &per_cpu(ebt_recseq, cpu);
| ^~~~~~~~~~
| xt_recseq
include/linux/percpu-defs.h:269:43: note: expanded from macro 'per_cpu'
269 | #define per_cpu(var, cpu) (*per_cpu_ptr(&(var), cpu))
| ^
include/linux/percpu-defs.h:236:20: note: expanded from macro 'per_cpu_ptr'
236 | SHIFT_PERCPU_PTR((ptr), per_cpu_offset((cpu))); \
| ^
include/linux/percpu-defs.h:231:49: note: expanded from macro 'SHIFT_PERCPU_PTR'
231 | RELOC_HIDE((typeof(*(__p)) __kernel __force *)(__p), (__offset))
| ^
include/linux/compiler.h:178:13: note: expanded from macro 'RELOC_HIDE'
178 | (typeof(ptr)) (__ptr + (off)); })
| ^
include/linux/netfilter/x_tables.h:346:29: note: 'xt_recseq' declared here
346 | DECLARE_PER_CPU(seqcount_t, xt_recseq);
| ^
net/bridge/netfilter/ebtables.c:1111:28: error: use of undeclared identifier 'ebt_recseq'; did you mean 'xt_recseq'?
1111 | seqcount_t *s = &per_cpu(ebt_recseq, cpu);
| ^~~~~~~~~~
| xt_recseq
include/linux/percpu-defs.h:269:43: note: expanded from macro 'per_cpu'
269 | #define per_cpu(var, cpu) (*per_cpu_ptr(&(var), cpu))
| ^
include/linux/percpu-defs.h:235:20: note: expanded from macro 'per_cpu_ptr'
235 | __verify_pcpu_ptr(ptr); \
| ^
include/linux/percpu-defs.h:219:47: note: expanded from macro '__verify_pcpu_ptr'
219 | const void __percpu *__vpp_verify = (typeof((ptr) + 0))NULL; \
| ^
include/linux/netfilter/x_tables.h:346:29: note: 'xt_recseq' declared here
346 | DECLARE_PER_CPU(seqcount_t, xt_recseq);
| ^
net/bridge/netfilter/ebtables.c:1111:28: error: use of undeclared identifier 'ebt_recseq'; did you mean 'xt_recseq'?
1111 | seqcount_t *s = &per_cpu(ebt_recseq, cpu);
| ^~~~~~~~~~
| xt_recseq
include/linux/percpu-defs.h:269:43: note: expanded from macro 'per_cpu'
269 | #define per_cpu(var, cpu) (*per_cpu_ptr(&(var), cpu))
| ^
include/linux/percpu-defs.h:236:20: note: expanded from macro 'per_cpu_ptr'
236 | SHIFT_PERCPU_PTR((ptr), per_cpu_offset((cpu))); \
| ^
include/linux/percpu-defs.h:231:23: note: expanded from macro 'SHIFT_PERCPU_PTR'
231 | RELOC_HIDE((typeof(*(__p)) __kernel __force *)(__p), (__offset))
| ^
include/linux/compiler.h:177:31: note: expanded from macro 'RELOC_HIDE'
177 | __ptr = (unsigned long) (ptr); \
| ^
include/linux/netfilter/x_tables.h:346:29: note: 'xt_recseq' declared here
346 | DECLARE_PER_CPU(seqcount_t, xt_recseq);
| ^
net/bridge/netfilter/ebtables.c:1111:28: error: use of undeclared identifier 'ebt_recseq'; did you mean 'xt_recseq'?
1111 | seqcount_t *s = &per_cpu(ebt_recseq, cpu);
| ^~~~~~~~~~
| xt_recseq
include/linux/percpu-defs.h:269:43: note: expanded from macro 'per_cpu'
269 | #define per_cpu(var, cpu) (*per_cpu_ptr(&(var), cpu))
| ^
include/linux/percpu-defs.h:236:20: note: expanded from macro 'per_cpu_ptr'
236 | SHIFT_PERCPU_PTR((ptr), per_cpu_offset((cpu))); \
| ^
include/linux/percpu-defs.h:231:49: note: expanded from macro 'SHIFT_PERCPU_PTR'
231 | RELOC_HIDE((typeof(*(__p)) __kernel __force *)(__p), (__offset))
| ^
include/linux/compiler.h:177:31: note: expanded from macro 'RELOC_HIDE'
177 | __ptr = (unsigned long) (ptr); \
| ^
include/linux/netfilter/x_tables.h:346:29: note: 'xt_recseq' declared here
346 | DECLARE_PER_CPU(seqcount_t, xt_recseq);
| ^
net/bridge/netfilter/ebtables.c:1111:28: error: use of undeclared identifier 'ebt_recseq'; did you mean 'xt_recseq'?
1111 | seqcount_t *s = &per_cpu(ebt_recseq, cpu);
| ^~~~~~~~~~
| xt_recseq
include/linux/percpu-defs.h:269:43: note: expanded from macro 'per_cpu'
269 | #define per_cpu(var, cpu) (*per_cpu_ptr(&(var), cpu))
| ^
include/linux/percpu-defs.h:236:20: note: expanded from macro 'per_cpu_ptr'
236 | SHIFT_PERCPU_PTR((ptr), per_cpu_offset((cpu))); \
| ^
include/linux/percpu-defs.h:231:23: note: expanded from macro 'SHIFT_PERCPU_PTR'
231 | RELOC_HIDE((typeof(*(__p)) __kernel __force *)(__p), (__offset))
| ^
include/linux/compiler.h:178:13: note: expanded from macro 'RELOC_HIDE'
178 | (typeof(ptr)) (__ptr + (off)); })
| ^
include/linux/netfilter/x_tables.h:346:29: note: 'xt_recseq' declared here
346 | DECLARE_PER_CPU(seqcount_t, xt_recseq);
| ^
net/bridge/netfilter/ebtables.c:1111:28: error: use of undeclared identifier 'ebt_recseq'; did you mean 'xt_recseq'?
1111 | seqcount_t *s = &per_cpu(ebt_recseq, cpu);
| ^~~~~~~~~~
| xt_recseq
include/linux/percpu-defs.h:269:43: note: expanded from macro 'per_cpu'
269 | #define per_cpu(var, cpu) (*per_cpu_ptr(&(var), cpu))
| ^
include/linux/percpu-defs.h:236:20: note: expanded from macro 'per_cpu_ptr'
236 | SHIFT_PERCPU_PTR((ptr), per_cpu_offset((cpu))); \
vim +1006 net/bridge/netfilter/ebtables.c
987
988
989 static void get_counters(const struct ebt_counter *oldcounters,
990 struct ebt_counter *counters, unsigned int nentries)
991 {
992 int i, cpu;
993 struct ebt_counter *counter_base;
994 seqcount_t *s;
995
996 /* counters of cpu 0 */
997 memcpy(counters, oldcounters,
998 sizeof(struct ebt_counter) * nentries);
999
1000 /* add other counters to those of cpu 0 */
1001 for_each_possible_cpu(cpu) {
1002
1003 if (cpu == 0)
1004 continue;
1005
> 1006 s = &per_cpu(ebt_recseq, cpu);
1007 counter_base = COUNTER_BASE(oldcounters, nentries, cpu);
1008 for (i = 0; i < nentries; i++) {
1009 u64 bcnt, pcnt;
1010 unsigned int start;
1011
1012 do {
1013 start = read_seqcount_begin(s);
1014 bcnt = counter_base[i].bcnt;
1015 pcnt = counter_base[i].pcnt;
1016 } while (read_seqcount_retry(s, start));
1017
1018 ADD_COUNTER(counters[i], bcnt, pcnt);
1019 cond_resched();
1020 }
1021 }
1022 }
1023
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread