* Re: [PATCH v3] x86/resctrl: Avoid overflow in MB settings in bw_validate()
[not found] <8d028c5f6f23e92fb83cbf20599366e896abc5b5.1727167989.git.nert.pinx@gmail.com>
@ 2024-09-24 18:01 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-09-24 18:01 UTC (permalink / raw)
To: Martin Kletzander, Fenghua Yu, Reinette Chatre, Thomas Gleixner,
Ingo Molnar, Borislav Petkov, Dave Hansen, x86, H. Peter Anvin,
linux-kernel
Cc: llvm, oe-kbuild-all
Hi Martin,
kernel test robot noticed the following build warnings:
[auto build test WARNING on tip/x86/core]
[also build test WARNING on linus/master v6.11 next-20240924]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Martin-Kletzander/x86-resctrl-Avoid-overflow-in-MB-settings-in-bw_validate/20240924-165510
base: tip/x86/core
patch link: https://lore.kernel.org/r/8d028c5f6f23e92fb83cbf20599366e896abc5b5.1727167989.git.nert.pinx%40gmail.com
patch subject: [PATCH v3] x86/resctrl: Avoid overflow in MB settings in bw_validate()
config: x86_64-buildonly-randconfig-005-20240924 (https://download.01.org/0day-ci/archive/20240925/202409250124.D1gI7Lzj-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240925/202409250124.D1gI7Lzj-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409250124.D1gI7Lzj-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> arch/x86/kernel/cpu/resctrl/ctrlmondata.c:58:62: warning: format specifies type 'long' but the argument has type 'u32' (aka 'unsigned int') [-Wformat]
58 | rdt_last_cmd_printf("MB value %ld out of range [%d,%d]\n", bw,
| ~~~ ^~
| %u
1 warning generated.
vim +58 arch/x86/kernel/cpu/resctrl/ctrlmondata.c
60ec2440c63dea arch/x86/kernel/cpu/intel_rdt_schemata.c Tony Luck 2016-10-28 25
64e8ed3d4a6dcd arch/x86/kernel/cpu/intel_rdt_schemata.c Vikas Shivappa 2017-04-07 26 /*
64e8ed3d4a6dcd arch/x86/kernel/cpu/intel_rdt_schemata.c Vikas Shivappa 2017-04-07 27 * Check whether MBA bandwidth percentage value is correct. The value is
64e8ed3d4a6dcd arch/x86/kernel/cpu/intel_rdt_schemata.c Vikas Shivappa 2017-04-07 28 * checked against the minimum and max bandwidth values specified by the
64e8ed3d4a6dcd arch/x86/kernel/cpu/intel_rdt_schemata.c Vikas Shivappa 2017-04-07 29 * hardware. The allocated bandwidth percentage is rounded to the next
64e8ed3d4a6dcd arch/x86/kernel/cpu/intel_rdt_schemata.c Vikas Shivappa 2017-04-07 30 * control step available on the hardware.
64e8ed3d4a6dcd arch/x86/kernel/cpu/intel_rdt_schemata.c Vikas Shivappa 2017-04-07 31 */
be99ce3b7dd7ba arch/x86/kernel/cpu/resctrl/ctrlmondata.c Martin Kletzander 2024-09-24 32 static bool bw_validate(char *buf, u32 *data, struct rdt_resource *r)
64e8ed3d4a6dcd arch/x86/kernel/cpu/intel_rdt_schemata.c Vikas Shivappa 2017-04-07 33 {
64e8ed3d4a6dcd arch/x86/kernel/cpu/intel_rdt_schemata.c Vikas Shivappa 2017-04-07 34 int ret;
be99ce3b7dd7ba arch/x86/kernel/cpu/resctrl/ctrlmondata.c Martin Kletzander 2024-09-24 35 u32 bw;
64e8ed3d4a6dcd arch/x86/kernel/cpu/intel_rdt_schemata.c Vikas Shivappa 2017-04-07 36
64e8ed3d4a6dcd arch/x86/kernel/cpu/intel_rdt_schemata.c Vikas Shivappa 2017-04-07 37 /*
64e8ed3d4a6dcd arch/x86/kernel/cpu/intel_rdt_schemata.c Vikas Shivappa 2017-04-07 38 * Only linear delay values is supported for current Intel SKUs.
64e8ed3d4a6dcd arch/x86/kernel/cpu/intel_rdt_schemata.c Vikas Shivappa 2017-04-07 39 */
41215b7947f1b1 arch/x86/kernel/cpu/resctrl/ctrlmondata.c James Morse 2020-07-08 40 if (!r->membw.delay_linear && r->membw.arch_needs_linear) {
c377dcfbee808e arch/x86/kernel/cpu/intel_rdt_ctrlmondata.c Tony Luck 2017-09-25 41 rdt_last_cmd_puts("No support for non-linear MB domains\n");
64e8ed3d4a6dcd arch/x86/kernel/cpu/intel_rdt_schemata.c Vikas Shivappa 2017-04-07 42 return false;
c377dcfbee808e arch/x86/kernel/cpu/intel_rdt_ctrlmondata.c Tony Luck 2017-09-25 43 }
64e8ed3d4a6dcd arch/x86/kernel/cpu/intel_rdt_schemata.c Vikas Shivappa 2017-04-07 44
be99ce3b7dd7ba arch/x86/kernel/cpu/resctrl/ctrlmondata.c Martin Kletzander 2024-09-24 45 ret = kstrtou32(buf, 10, &bw);
c377dcfbee808e arch/x86/kernel/cpu/intel_rdt_ctrlmondata.c Tony Luck 2017-09-25 46 if (ret) {
be99ce3b7dd7ba arch/x86/kernel/cpu/resctrl/ctrlmondata.c Martin Kletzander 2024-09-24 47 rdt_last_cmd_printf("Invalid MB value %s\n", buf);
64e8ed3d4a6dcd arch/x86/kernel/cpu/intel_rdt_schemata.c Vikas Shivappa 2017-04-07 48 return false;
c377dcfbee808e arch/x86/kernel/cpu/intel_rdt_ctrlmondata.c Tony Luck 2017-09-25 49 }
64e8ed3d4a6dcd arch/x86/kernel/cpu/intel_rdt_schemata.c Vikas Shivappa 2017-04-07 50
be99ce3b7dd7ba arch/x86/kernel/cpu/resctrl/ctrlmondata.c Martin Kletzander 2024-09-24 51 /* Nothing else to do if software controller is enabled. */
be99ce3b7dd7ba arch/x86/kernel/cpu/resctrl/ctrlmondata.c Martin Kletzander 2024-09-24 52 if (is_mba_sc(r)) {
be99ce3b7dd7ba arch/x86/kernel/cpu/resctrl/ctrlmondata.c Martin Kletzander 2024-09-24 53 *data = bw;
be99ce3b7dd7ba arch/x86/kernel/cpu/resctrl/ctrlmondata.c Martin Kletzander 2024-09-24 54 return true;
be99ce3b7dd7ba arch/x86/kernel/cpu/resctrl/ctrlmondata.c Martin Kletzander 2024-09-24 55 }
be99ce3b7dd7ba arch/x86/kernel/cpu/resctrl/ctrlmondata.c Martin Kletzander 2024-09-24 56
be99ce3b7dd7ba arch/x86/kernel/cpu/resctrl/ctrlmondata.c Martin Kletzander 2024-09-24 57 if (bw < r->membw.min_bw || bw > r->default_ctrl) {
c377dcfbee808e arch/x86/kernel/cpu/intel_rdt_ctrlmondata.c Tony Luck 2017-09-25 @58 rdt_last_cmd_printf("MB value %ld out of range [%d,%d]\n", bw,
c377dcfbee808e arch/x86/kernel/cpu/intel_rdt_ctrlmondata.c Tony Luck 2017-09-25 59 r->membw.min_bw, r->default_ctrl);
64e8ed3d4a6dcd arch/x86/kernel/cpu/intel_rdt_schemata.c Vikas Shivappa 2017-04-07 60 return false;
c377dcfbee808e arch/x86/kernel/cpu/intel_rdt_ctrlmondata.c Tony Luck 2017-09-25 61 }
64e8ed3d4a6dcd arch/x86/kernel/cpu/intel_rdt_schemata.c Vikas Shivappa 2017-04-07 62
64e8ed3d4a6dcd arch/x86/kernel/cpu/intel_rdt_schemata.c Vikas Shivappa 2017-04-07 63 *data = roundup(bw, (unsigned long)r->membw.bw_gran);
64e8ed3d4a6dcd arch/x86/kernel/cpu/intel_rdt_schemata.c Vikas Shivappa 2017-04-07 64 return true;
64e8ed3d4a6dcd arch/x86/kernel/cpu/intel_rdt_schemata.c Vikas Shivappa 2017-04-07 65 }
64e8ed3d4a6dcd arch/x86/kernel/cpu/intel_rdt_schemata.c Vikas Shivappa 2017-04-07 66
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread