* Re: [PATCH] Staging: iommu: Replace null pointer check with IS_ERR in arm_smmu_domain_alloc_user()
[not found] <20240922155621.49432-1-kdipendra88@gmail.com>
@ 2024-09-25 0:00 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-09-25 0:00 UTC (permalink / raw)
To: Dipendra Khadka, will, robin.murphy, joro, baolu.lu
Cc: llvm, oe-kbuild-all, Dipendra Khadka, linux-arm-kernel, iommu,
linux-kernel
Hi Dipendra,
kernel test robot noticed the following build errors:
[auto build test ERROR on staging/staging-testing]
url: https://github.com/intel-lab-lkp/linux/commits/Dipendra-Khadka/Staging-iommu-Replace-null-pointer-check-with-IS_ERR-in-arm_smmu_domain_alloc_user/20240922-235756
base: staging/staging-testing
patch link: https://lore.kernel.org/r/20240922155621.49432-1-kdipendra88%40gmail.com
patch subject: [PATCH] Staging: iommu: Replace null pointer check with IS_ERR in arm_smmu_domain_alloc_user()
config: arm64-randconfig-003-20240925 (https://download.01.org/0day-ci/archive/20240925/202409250755.nLQtNlCf-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 7773243d9916f98ba0ffce0c3a960e4aa9f03e81)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240925/202409250755.nLQtNlCf-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409250755.nLQtNlCf-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:15:
In file included from include/linux/crash_dump.h:5:
In file included from include/linux/kexec.h:18:
In file included from include/linux/vmcore_info.h:6:
In file included from include/linux/elfcore.h:11:
In file included from include/linux/ptrace.h:10:
In file included from include/linux/pid_namespace.h:7:
In file included from include/linux/mm.h:2228:
include/linux/vmstat.h:514:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
514 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
>> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:3066:10: error: incompatible pointer types returning 'struct arm_smmu_domain *' from a function with result type 'struct iommu_domain *' [-Werror,-Wincompatible-pointer-types]
3066 | return smmu_domain;
| ^~~~~~~~~~~
1 warning and 1 error generated.
vim +3066 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
3048
3049 static struct iommu_domain *
3050 arm_smmu_domain_alloc_user(struct device *dev, u32 flags,
3051 struct iommu_domain *parent,
3052 const struct iommu_user_data *user_data)
3053 {
3054 struct arm_smmu_master *master = dev_iommu_priv_get(dev);
3055 const u32 PAGING_FLAGS = IOMMU_HWPT_ALLOC_DIRTY_TRACKING;
3056 struct arm_smmu_domain *smmu_domain;
3057 int ret;
3058
3059 if (flags & ~PAGING_FLAGS)
3060 return ERR_PTR(-EOPNOTSUPP);
3061 if (parent || user_data)
3062 return ERR_PTR(-EOPNOTSUPP);
3063
3064 smmu_domain = arm_smmu_domain_alloc();
3065 if (IS_ERR(smmu_domain))
> 3066 return smmu_domain;
3067
3068 smmu_domain->domain.type = IOMMU_DOMAIN_UNMANAGED;
3069 smmu_domain->domain.ops = arm_smmu_ops.default_domain_ops;
3070 ret = arm_smmu_domain_finalise(smmu_domain, master->smmu, flags);
3071 if (ret)
3072 goto err_free;
3073 return &smmu_domain->domain;
3074
3075 err_free:
3076 kfree(smmu_domain);
3077 return ERR_PTR(ret);
3078 }
3079
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread