* Re: [RFC PATCH] cleanup: make scoped_guard() to be return-friendly
[not found] <20240926134347.19371-1-przemyslaw.kitszel@intel.com>
@ 2024-09-27 0:48 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-09-27 0:48 UTC (permalink / raw)
To: Przemek Kitszel; +Cc: llvm, oe-kbuild-all
Hi Przemek,
[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:
[auto build test WARNING on 151ac45348afc5b56baa584c7cd4876addf461ff]
url: https://github.com/intel-lab-lkp/linux/commits/Przemek-Kitszel/cleanup-make-scoped_guard-to-be-return-friendly/20240926-214521
base: 151ac45348afc5b56baa584c7cd4876addf461ff
patch link: https://lore.kernel.org/r/20240926134347.19371-1-przemyslaw.kitszel%40intel.com
patch subject: [RFC PATCH] cleanup: make scoped_guard() to be return-friendly
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240927/202409270848.tTpyEAR7-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240927/202409270848.tTpyEAR7-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409270848.tTpyEAR7-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/iio/magnetometer/af8133j.c:316:3: warning: add explicit braces to avoid dangling else [-Wdangling-else]
316 | scoped_guard(mutex, &data->mutex)
| ^
include/linux/cleanup.h:172:2: note: expanded from macro 'scoped_guard'
172 | __scoped_guard_labeled(__UNIQUE_ID(label), _name, args)
| ^
include/linux/cleanup.h:177:2: note: expanded from macro '__scoped_guard_labeled'
177 | else \
| ^
1 warning generated.
vim +316 drivers/iio/magnetometer/af8133j.c
1d8f4b04621f0f Icenowy Zheng 2024-02-22 294
1d8f4b04621f0f Icenowy Zheng 2024-02-22 295 static int af8133j_set_scale(struct af8133j_data *data,
1d8f4b04621f0f Icenowy Zheng 2024-02-22 296 unsigned int val, unsigned int val2)
1d8f4b04621f0f Icenowy Zheng 2024-02-22 297 {
1d8f4b04621f0f Icenowy Zheng 2024-02-22 298 struct device *dev = &data->client->dev;
1d8f4b04621f0f Icenowy Zheng 2024-02-22 299 u8 range;
1d8f4b04621f0f Icenowy Zheng 2024-02-22 300 int ret = 0;
1d8f4b04621f0f Icenowy Zheng 2024-02-22 301
1d8f4b04621f0f Icenowy Zheng 2024-02-22 302 if (af8133j_scales[0][0] == val && af8133j_scales[0][1] == val2)
1d8f4b04621f0f Icenowy Zheng 2024-02-22 303 range = AF8133J_REG_RANGE_12G;
1d8f4b04621f0f Icenowy Zheng 2024-02-22 304 else if (af8133j_scales[1][0] == val && af8133j_scales[1][1] == val2)
1d8f4b04621f0f Icenowy Zheng 2024-02-22 305 range = AF8133J_REG_RANGE_22G;
1d8f4b04621f0f Icenowy Zheng 2024-02-22 306 else
1d8f4b04621f0f Icenowy Zheng 2024-02-22 307 return -EINVAL;
1d8f4b04621f0f Icenowy Zheng 2024-02-22 308
1d8f4b04621f0f Icenowy Zheng 2024-02-22 309 pm_runtime_disable(dev);
1d8f4b04621f0f Icenowy Zheng 2024-02-22 310
1d8f4b04621f0f Icenowy Zheng 2024-02-22 311 /*
1d8f4b04621f0f Icenowy Zheng 2024-02-22 312 * When suspended, just store the new range to data->range to be
1d8f4b04621f0f Icenowy Zheng 2024-02-22 313 * applied later during power up.
1d8f4b04621f0f Icenowy Zheng 2024-02-22 314 */
1d8f4b04621f0f Icenowy Zheng 2024-02-22 315 if (!pm_runtime_status_suspended(dev))
1d8f4b04621f0f Icenowy Zheng 2024-02-22 @316 scoped_guard(mutex, &data->mutex)
1d8f4b04621f0f Icenowy Zheng 2024-02-22 317 ret = regmap_write(data->regmap,
1d8f4b04621f0f Icenowy Zheng 2024-02-22 318 AF8133J_REG_RANGE, range);
1d8f4b04621f0f Icenowy Zheng 2024-02-22 319
1d8f4b04621f0f Icenowy Zheng 2024-02-22 320 pm_runtime_enable(dev);
1d8f4b04621f0f Icenowy Zheng 2024-02-22 321
1d8f4b04621f0f Icenowy Zheng 2024-02-22 322 data->range = range;
1d8f4b04621f0f Icenowy Zheng 2024-02-22 323 return ret;
1d8f4b04621f0f Icenowy Zheng 2024-02-22 324 }
1d8f4b04621f0f Icenowy Zheng 2024-02-22 325
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread