Re: [PATCH v7] f2fs: zone: don't block IO if there is remained open zone

Re: [PATCH v7] f2fs: zone: don't block IO if there is remained open zone

[kernel test robot]

Hi Chao,

kernel test robot noticed the following build errors:

[auto build test ERROR on jaegeuk-f2fs/dev-test]
[also build test ERROR on jaegeuk-f2fs/dev linus/master v6.12-rc3 next-20241018]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Chao-Yu/f2fs-zone-don-t-block-IO-if-there-is-remained-open-zone/20241017-162658
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test
patch link:    https://lore.kernel.org/r/20241017081421.2213743-1-chao%40kernel.org
patch subject: [PATCH v7] f2fs: zone: don't block IO if there is remained open zone
config: i386-buildonly-randconfig-002-20241018 (https://download.01.org/0day-ci/archive/20241018/202410181726.6oq4qPDH-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241018/202410181726.6oq4qPDH-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410181726.6oq4qPDH-lkp@intel.com/

All errors (new ones prefixed by >>):

>> fs/f2fs/data.c:666:67: error: too many arguments to function call, expected single argument 'seg_type', have 2 arguments
     666 |         io = sbi->write_io[PAGE_TYPE(type)] + f2fs_get_segment_temp(sbi, type);
         |                                               ~~~~~~~~~~~~~~~~~~~~~      ^~~~
   fs/f2fs/f2fs.h:3762:5: note: 'f2fs_get_segment_temp' declared here
    3762 | int f2fs_get_segment_temp(int seg_type);
         |     ^                     ~~~~~~~~~~~~
   fs/f2fs/data.c:2426:10: warning: variable 'index' set but not used [-Wunused-but-set-variable]
    2426 |         pgoff_t index;
         |                 ^
   1 warning and 1 error generated.
--
>> fs/f2fs/segment.c:4324:38: error: too many arguments to function call, expected single argument 'seg_type', have 2 arguments
    4324 |                         temp = f2fs_get_segment_temp(sbi, type);
         |                                ~~~~~~~~~~~~~~~~~~~~~      ^~~~
   fs/f2fs/segment.c:3610:5: note: 'f2fs_get_segment_temp' declared here
    3610 | int f2fs_get_segment_temp(int seg_type)
         |     ^                     ~~~~~~~~~~~~
   fs/f2fs/segment.c:5666:53: error: too many arguments to function call, expected single argument 'seg_type', have 2 arguments
    5666 |                         enum temp_type temp = f2fs_get_segment_temp(sbi, i);
         |                                               ~~~~~~~~~~~~~~~~~~~~~      ^
   fs/f2fs/segment.c:3610:5: note: 'f2fs_get_segment_temp' declared here
    3610 | int f2fs_get_segment_temp(int seg_type)
         |     ^                     ~~~~~~~~~~~~
   2 errors generated.


vim +/seg_type +666 fs/f2fs/data.c

   657	
   658	void f2fs_blkzoned_submit_merged_write(struct f2fs_sb_info *sbi, int type)
   659	{
   660	#ifdef CONFIG_BLK_DEV_ZONED
   661		struct f2fs_bio_info *io;
   662	
   663		if (!f2fs_sb_has_blkzoned(sbi))
   664			return;
   665	
 > 666		io = sbi->write_io[PAGE_TYPE(type)] + f2fs_get_segment_temp(sbi, type);
   667	
   668		f2fs_down_write(&io->io_rwsem);
   669		if (io->zone_opened) {
   670			if (io->bio) {
   671				io->close_zone = true;
   672				__submit_merged_bio(io);
   673			} else {
   674				up(&sbi->available_open_zones);
   675				io->zone_opened = false;
   676			}
   677		}
   678		f2fs_up_write(&io->io_rwsem);
   679	#endif
   680	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki