* Re: [PATCH RFC v4 08/15] fuse: {uring} Add uring sqe commit and fetch support
[not found] <20241016-fuse-uring-for-6-10-rfc4-v4-8-9739c753666e@ddn.com>
@ 2024-10-19 3:12 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-10-19 3:12 UTC (permalink / raw)
To: Bernd Schubert; +Cc: llvm, oe-kbuild-all
Hi Bernd,
[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:
[auto build test WARNING on 0c3836482481200ead7b416ca80c68a29cfdaabd]
url: https://github.com/intel-lab-lkp/linux/commits/Bernd-Schubert/fuse-rename-to-fuse_dev_end_requests-and-make-non-static/20241016-084030
base: 0c3836482481200ead7b416ca80c68a29cfdaabd
patch link: https://lore.kernel.org/r/20241016-fuse-uring-for-6-10-rfc4-v4-8-9739c753666e%40ddn.com
patch subject: [PATCH RFC v4 08/15] fuse: {uring} Add uring sqe commit and fetch support
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20241019/202410191037.neVRHnb0-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241019/202410191037.neVRHnb0-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410191037.neVRHnb0-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> fs/fuse/dev_uring.c:533:15: warning: variable 'hash' set but not used [-Wunused-but-set-variable]
533 | unsigned int hash;
| ^
fs/fuse/dev_uring.c:712:3: error: use of undeclared identifier 'ret'
712 | ret = fuse_uring_commit_fetch(cmd, issue_flags, fc);
| ^
1 warning and 1 error generated.
vim +/hash +533 fs/fuse/dev_uring.c
521
522 /* FUSE_URING_REQ_COMMIT_AND_FETCH handler */
523 static int fuse_uring_commit_fetch(struct io_uring_cmd *cmd, int issue_flags,
524 struct fuse_conn *fc)
525 {
526 const struct fuse_uring_cmd_req *cmd_req = io_uring_sqe_cmd(cmd->sqe);
527 struct fuse_ring_ent *ring_ent;
528 int err;
529 struct fuse_ring *ring = fc->ring;
530 struct fuse_ring_queue *queue;
531 uint64_t commit_id = cmd_req->commit_id;
532 struct fuse_pqueue fpq;
> 533 unsigned int hash;
534 struct fuse_req *req;
535
536 err = -ENOTCONN;
537 if (!ring)
538 return err;
539
540 queue = ring->queues[cmd_req->qid];
541 if (!queue)
542 return err;
543 fpq = queue->fpq;
544
545 spin_lock(&queue->lock);
546 /* Find a request based on the unique ID of the fuse request
547 * This should get revised, as it needs a hash calculation and list
548 * search. And full struct fuse_pqueue is needed (memory overhead).
549 * As well as the link from req to ring_ent.
550 */
551 hash = fuse_req_hash(commit_id);
552 req = fuse_request_find(&fpq, commit_id);
553 err = -ENOENT;
554 if (!req) {
555 pr_info("qid=%d commit_id %llu not found\n", queue->qid,
556 commit_id);
557 spin_unlock(&queue->lock);
558 return err;
559 }
560 ring_ent = req->ring_entry;
561 req->ring_entry = NULL;
562
563 err = fuse_ring_ring_ent_unset_userspace(ring_ent);
564 if (err != 0) {
565 pr_info_ratelimited("qid=%d commit_id %llu state %d",
566 queue->qid, commit_id, ring_ent->state);
567 spin_unlock(&queue->lock);
568 return err;
569 }
570
571 ring_ent->cmd = cmd;
572 spin_unlock(&queue->lock);
573
574 /* without the queue lock, as other locks are taken */
575 fuse_uring_commit(ring_ent, issue_flags);
576
577 /*
578 * Fetching the next request is absolutely required as queued
579 * fuse requests would otherwise not get processed - committing
580 * and fetching is done in one step vs legacy fuse, which has separated
581 * read (fetch request) and write (commit result).
582 */
583 fuse_uring_next_fuse_req(ring_ent, queue);
584 return 0;
585 }
586
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread