* Re: [PATCH v5 09/14] scsi: fnic: Modify IO path to use FDLS
[not found] <20241018161409.4442-10-kartilak@cisco.com>
@ 2024-10-20 17:28 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-10-20 17:28 UTC (permalink / raw)
To: Karan Tilak Kumar, sebaddel
Cc: llvm, oe-kbuild-all, arulponn, djhawar, gcboffa, mkai2, satishkh,
aeasi, jejb, martin.petersen, linux-scsi, linux-kernel,
Karan Tilak Kumar
Hi Karan,
kernel test robot noticed the following build warnings:
[auto build test WARNING on mkp-scsi/for-next]
[cannot apply to jejb-scsi/for-next linus/master v6.12-rc3 next-20241018]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Karan-Tilak-Kumar/scsi-fnic-Replace-shost_printk-with-dev_info-dev_err/20241019-002800
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
patch link: https://lore.kernel.org/r/20241018161409.4442-10-kartilak%40cisco.com
patch subject: [PATCH v5 09/14] scsi: fnic: Modify IO path to use FDLS
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20241021/202410210147.fQp7tYeb-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241021/202410210147.fQp7tYeb-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410210147.fQp7tYeb-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/scsi/fnic/fnic_scsi.c:269:15: warning: variable 'ioreq_count' set but not used [-Wunused-but-set-variable]
269 | unsigned int ioreq_count;
| ^
drivers/scsi/fnic/fnic_scsi.c:928:6: warning: variable 'xfer_len' set but not used [-Wunused-but-set-variable]
928 | u64 xfer_len = 0;
| ^
drivers/scsi/fnic/fnic_scsi.c:2506:21: warning: variable 'fnic_stats' set but not used [-Wunused-but-set-variable]
2506 | struct fnic_stats *fnic_stats;
| ^
3 warnings generated.
vim +/ioreq_count +269 drivers/scsi/fnic/fnic_scsi.c
258
259
260 /*
261 * fnic_fw_reset_handler
262 * Routine to send reset msg to fw
263 */
264 int fnic_fw_reset_handler(struct fnic *fnic)
265 {
266 struct vnic_wq_copy *wq = &fnic->hw_copy_wq[0];
267 int ret = 0;
268 unsigned long flags;
> 269 unsigned int ioreq_count;
270
271 /* indicate fwreset to io path */
272 fnic_set_state_flags(fnic, FNIC_FLAGS_FWRESET);
273 ioreq_count = fnic_count_all_ioreqs(fnic);
274
275 /* wait for io cmpl */
276 while (atomic_read(&fnic->in_flight))
277 schedule_timeout(msecs_to_jiffies(1));
278
279 spin_lock_irqsave(&fnic->wq_copy_lock[0], flags);
280
281 if (vnic_wq_copy_desc_avail(wq) <= fnic->wq_copy_desc_low[0])
282 free_wq_copy_descs(fnic, wq, 0);
283
284 if (!vnic_wq_copy_desc_avail(wq))
285 ret = -EAGAIN;
286 else {
287 fnic_queue_wq_copy_desc_fw_reset(wq, SCSI_NO_TAG);
288 atomic64_inc(&fnic->fnic_stats.fw_stats.active_fw_reqs);
289 if (atomic64_read(&fnic->fnic_stats.fw_stats.active_fw_reqs) >
290 atomic64_read(&fnic->fnic_stats.fw_stats.max_fw_reqs))
291 atomic64_set(&fnic->fnic_stats.fw_stats.max_fw_reqs,
292 atomic64_read(
293 &fnic->fnic_stats.fw_stats.active_fw_reqs));
294 }
295
296 spin_unlock_irqrestore(&fnic->wq_copy_lock[0], flags);
297
298 if (!ret) {
299 atomic64_inc(&fnic->fnic_stats.reset_stats.fw_resets);
300 FNIC_SCSI_DBG(KERN_INFO, fnic->lport->host, fnic->fnic_num,
301 "Issued fw reset\n");
302 } else {
303 fnic_clear_state_flags(fnic, FNIC_FLAGS_FWRESET);
304 FNIC_SCSI_DBG(KERN_ERR, fnic->lport->host, fnic->fnic_num,
305 "Failed to issue fw reset\n");
306 }
307
308 return ret;
309 }
310
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread