* Re: [PATCH] wifi: wilc1000: Rework bus locking
[not found] <20241022013855.284783-1-marex@denx.de>
@ 2024-10-22 20:33 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-10-22 20:33 UTC (permalink / raw)
To: Marek Vasut, linux-wireless
Cc: llvm, oe-kbuild-all, Marek Vasut, Adham Abozaeid, Ajay Singh,
Alexis Lothoré, Claudiu Beznea, Conor Dooley, Eric Dumazet,
Jakub Kicinski, Kalle Valo, Krzysztof Kozlowski, Paolo Abeni,
Rob Herring, devicetree, netdev
Hi Marek,
kernel test robot noticed the following build errors:
[auto build test ERROR on wireless-next/main]
[also build test ERROR on next-20241022]
[cannot apply to wireless/main linus/master v6.12-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Marek-Vasut/wifi-wilc1000-Rework-bus-locking/20241022-093954
base: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
patch link: https://lore.kernel.org/r/20241022013855.284783-1-marex%40denx.de
patch subject: [PATCH] wifi: wilc1000: Rework bus locking
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20241023/202410230402.Cgu8obYR-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241023/202410230402.Cgu8obYR-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410230402.Cgu8obYR-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/net/wireless/microchip/wilc1000/spi.c:1113:20: error: no member named 'hif_cs' in 'struct wilc'
1113 | mutex_lock(&wilc->hif_cs);
| ~~~~ ^
include/linux/mutex.h:166:44: note: expanded from macro 'mutex_lock'
166 | #define mutex_lock(lock) mutex_lock_nested(lock, 0)
| ^~~~
drivers/net/wireless/microchip/wilc1000/spi.c:1118:22: error: no member named 'hif_cs' in 'struct wilc'
1118 | mutex_unlock(&wilc->hif_cs);
| ~~~~ ^
drivers/net/wireless/microchip/wilc1000/spi.c:1147:23: error: no member named 'hif_cs' in 'struct wilc'
1147 | mutex_destroy(&wilc->hif_cs);
| ~~~~ ^
>> drivers/net/wireless/microchip/wilc1000/spi.c:1156:14: error: use of undeclared identifier 'spi'
1156 | mutex_init(&spi->hif_cs);
| ^
>> drivers/net/wireless/microchip/wilc1000/spi.c:1156:14: error: use of undeclared identifier 'spi'
5 errors generated.
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for MODVERSIONS
Depends on [n]: MODULES [=y] && !COMPILE_TEST [=y]
Selected by [y]:
- RANDSTRUCT_FULL [=y] && (CC_HAS_RANDSTRUCT [=y] || GCC_PLUGINS [=n]) && MODULES [=y]
vim +1113 drivers/net/wireless/microchip/wilc1000/spi.c
1105
1106 /********************************************
1107 *
1108 * Bus interfaces
1109 *
1110 ********************************************/
1111 static void wilc_spi_claim(struct wilc *wilc)
1112 {
> 1113 mutex_lock(&wilc->hif_cs);
1114 }
1115
1116 static void wilc_spi_release(struct wilc *wilc)
1117 {
> 1118 mutex_unlock(&wilc->hif_cs);
1119 }
1120
1121 static int wilc_spi_reset(struct wilc *wilc)
1122 {
1123 struct spi_device *spi = to_spi_device(wilc->dev);
1124 struct wilc_spi *spi_priv = wilc->bus_data;
1125 int result;
1126
1127 result = wilc_spi_special_cmd(wilc, CMD_RESET);
1128 if (result && !spi_priv->probing_crc)
1129 dev_err(&spi->dev, "Failed cmd reset\n");
1130
1131 return result;
1132 }
1133
1134 static bool wilc_spi_is_init(struct wilc *wilc)
1135 {
1136 struct wilc_spi *spi_priv = wilc->bus_data;
1137
1138 return spi_priv->isinit;
1139 }
1140
1141 static int wilc_spi_deinit(struct wilc *wilc)
1142 {
1143 struct wilc_spi *spi_priv = wilc->bus_data;
1144
1145 spi_priv->isinit = false;
1146 wilc_wlan_power(wilc, false);
1147 mutex_destroy(&wilc->hif_cs);
1148 return 0;
1149 }
1150
1151 static int wilc_spi_init(struct wilc *wilc, bool resume)
1152 {
1153 struct wilc_spi *spi_priv = wilc->bus_data;
1154 int ret;
1155
> 1156 mutex_init(&spi->hif_cs);
1157
1158 if (spi_priv->isinit) {
1159 /* Confirm we can read chipid register without error: */
1160 if (wilc_validate_chipid(wilc) == 0)
1161 return 0;
1162 }
1163
1164 wilc_wlan_power(wilc, true);
1165
1166 ret = wilc_spi_configure_bus_protocol(wilc);
1167 if (ret) {
1168 wilc_wlan_power(wilc, false);
1169 return ret;
1170 }
1171
1172 spi_priv->isinit = true;
1173
1174 return 0;
1175 }
1176
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread