* [jolsa-perf:trampoline_multi_10 9/21] kernel/trace/ftrace.c:6001: warning: Function parameter or struct member 'hash' not described in 'unregister_ftrace_direct_hash'
@ 2024-10-23 6:34 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-10-23 6:34 UTC (permalink / raw)
To: Jiri Olsa; +Cc: llvm, oe-kbuild-all
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git trampoline_multi_10
head: 48132820c5a21b82d1a4507a86a67b3742fb110e
commit: 122145c00eae844a9c5f48a3c5604554a8b9a377 [9/21] ftrace: Add unregister_ftrace_direct_hash function
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20241023/202410231448.tshoLbjZ-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241023/202410231448.tshoLbjZ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410231448.tshoLbjZ-lkp@intel.com/
All warnings (new ones prefixed by >>):
kernel/trace/ftrace.c:5887: warning: Function parameter or struct member 'hash' not described in 'register_ftrace_direct_hash'
kernel/trace/ftrace.c:5887: warning: expecting prototype for register_ftrace_direct(). Prototype was for register_ftrace_direct_hash() instead
>> kernel/trace/ftrace.c:6001: warning: Function parameter or struct member 'hash' not described in 'unregister_ftrace_direct_hash'
>> kernel/trace/ftrace.c:6001: warning: expecting prototype for unregister_ftrace_direct(). Prototype was for unregister_ftrace_direct_hash() instead
vim +6001 kernel/trace/ftrace.c
5081acd5f53163 Jiri Olsa 2024-10-14 5982
f64dd4627ec6ed Jiri Olsa 2021-10-08 5983 /**
da8bdfbd422333 Florent Revest 2023-03-21 5984 * unregister_ftrace_direct - Remove calls to custom trampoline
da8bdfbd422333 Florent Revest 2023-03-21 5985 * previously registered by register_ftrace_direct for @ops object.
f64dd4627ec6ed Jiri Olsa 2021-10-08 5986 * @ops: The address of the struct ftrace_ops object
c488fe4b50d896 Jiri Olsa 2024-09-30 5987 * @ip: The address of the function to attach
9b5a45eb639c46 Marilene A Garcia 2024-06-06 5988 * @addr: The address of the direct function that is called by the @ops functions
9b5a45eb639c46 Marilene A Garcia 2024-06-06 5989 * @free_filters: Set to true to remove all filters for the ftrace_ops, false otherwise
f64dd4627ec6ed Jiri Olsa 2021-10-08 5990 *
f64dd4627ec6ed Jiri Olsa 2021-10-08 5991 * This is used to remove a direct calls to @addr from the nop locations
f64dd4627ec6ed Jiri Olsa 2021-10-08 5992 * of the functions registered in @ops (with by ftrace_set_filter_ip
f64dd4627ec6ed Jiri Olsa 2021-10-08 5993 * function).
f64dd4627ec6ed Jiri Olsa 2021-10-08 5994 *
f64dd4627ec6ed Jiri Olsa 2021-10-08 5995 * Returns:
f64dd4627ec6ed Jiri Olsa 2021-10-08 5996 * 0 on success
f64dd4627ec6ed Jiri Olsa 2021-10-08 5997 * -EINVAL - The @ops object was not properly registered.
f64dd4627ec6ed Jiri Olsa 2021-10-08 5998 */
122145c00eae84 Jiri Olsa 2024-10-14 5999 int unregister_ftrace_direct_hash(struct ftrace_ops *ops, struct ftrace_hash *hash,
59495740f79524 Florent Revest 2023-03-21 6000 bool free_filters)
f64dd4627ec6ed Jiri Olsa 2021-10-08 @6001 {
122145c00eae84 Jiri Olsa 2024-10-14 6002 struct ftrace_func_entry *del, *entry;
c488fe4b50d896 Jiri Olsa 2024-09-30 6003 struct ftrace_hash *new_hash = NULL;
122145c00eae84 Jiri Olsa 2024-10-14 6004 unsigned long size, i;
c488fe4b50d896 Jiri Olsa 2024-09-30 6005 int err = -EINVAL;
f64dd4627ec6ed Jiri Olsa 2021-10-08 6006
f64dd4627ec6ed Jiri Olsa 2021-10-08 6007 if (check_direct_multi(ops))
f64dd4627ec6ed Jiri Olsa 2021-10-08 6008 return -EINVAL;
f64dd4627ec6ed Jiri Olsa 2021-10-08 6009 if (!(ops->flags & FTRACE_OPS_FL_ENABLED))
f64dd4627ec6ed Jiri Olsa 2021-10-08 6010 return -EINVAL;
c488fe4b50d896 Jiri Olsa 2024-09-30 6011 if (direct_functions == EMPTY_HASH)
c488fe4b50d896 Jiri Olsa 2024-09-30 6012 return -EINVAL;
f64dd4627ec6ed Jiri Olsa 2021-10-08 6013
f64dd4627ec6ed Jiri Olsa 2021-10-08 6014 mutex_lock(&direct_mutex);
c488fe4b50d896 Jiri Olsa 2024-09-30 6015
122145c00eae84 Jiri Olsa 2024-10-14 6016 /* Make sure requested entries are already registered.. */
122145c00eae84 Jiri Olsa 2024-10-14 6017 size = 1 << hash->size_bits;
122145c00eae84 Jiri Olsa 2024-10-14 6018 for (i = 0; i < size; i++) {
122145c00eae84 Jiri Olsa 2024-10-14 6019 hlist_for_each_entry(entry, &hash->buckets[i], hlist) {
122145c00eae84 Jiri Olsa 2024-10-14 6020 del = __ftrace_lookup_ip(direct_functions, entry->ip);
122145c00eae84 Jiri Olsa 2024-10-14 6021 if (!del || del->direct != entry->direct)
c488fe4b50d896 Jiri Olsa 2024-09-30 6022 goto out_unlock;
122145c00eae84 Jiri Olsa 2024-10-14 6023 }
122145c00eae84 Jiri Olsa 2024-10-14 6024 }
c488fe4b50d896 Jiri Olsa 2024-09-30 6025
c488fe4b50d896 Jiri Olsa 2024-09-30 6026 new_hash = alloc_and_copy_ftrace_hash(FTRACE_HASH_DEFAULT_BITS, direct_functions);
c488fe4b50d896 Jiri Olsa 2024-09-30 6027 if (!new_hash)
c488fe4b50d896 Jiri Olsa 2024-09-30 6028 goto out_unlock;
c488fe4b50d896 Jiri Olsa 2024-09-30 6029
122145c00eae84 Jiri Olsa 2024-10-14 6030 for (i = 0; i < size; i++) {
122145c00eae84 Jiri Olsa 2024-10-14 6031 hlist_for_each_entry(entry, &hash->buckets[i], hlist) {
122145c00eae84 Jiri Olsa 2024-10-14 6032 del = __ftrace_lookup_ip(new_hash, entry->ip);
122145c00eae84 Jiri Olsa 2024-10-14 6033 remove_hash_entry(new_hash, del);
122145c00eae84 Jiri Olsa 2024-10-14 6034 kfree(del);
122145c00eae84 Jiri Olsa 2024-10-14 6035 }
122145c00eae84 Jiri Olsa 2024-10-14 6036 }
c488fe4b50d896 Jiri Olsa 2024-09-30 6037
c488fe4b50d896 Jiri Olsa 2024-09-30 6038 if (ftrace_hash_empty(new_hash)) {
f64dd4627ec6ed Jiri Olsa 2021-10-08 6039 err = unregister_ftrace_function(ops);
c488fe4b50d896 Jiri Olsa 2024-09-30 6040 ftrace_free_filter(ops);
c488fe4b50d896 Jiri Olsa 2024-09-30 6041 } else {
c488fe4b50d896 Jiri Olsa 2024-09-30 6042 err = ftrace_update_ops(ops, new_hash, EMPTY_HASH);
c488fe4b50d896 Jiri Olsa 2024-09-30 6043 }
c488fe4b50d896 Jiri Olsa 2024-09-30 6044
c488fe4b50d896 Jiri Olsa 2024-09-30 6045 free_ftrace_hash(new_hash);
fea3ffa48c6d42 Jiri Olsa 2021-12-06 6046
c488fe4b50d896 Jiri Olsa 2024-09-30 6047 if (!err) {
122145c00eae84 Jiri Olsa 2024-10-14 6048 for (i = 0; i < size; i++) {
122145c00eae84 Jiri Olsa 2024-10-14 6049 hlist_for_each_entry(entry, &hash->buckets[i], hlist) {
122145c00eae84 Jiri Olsa 2024-10-14 6050 del = __ftrace_lookup_ip(direct_functions, entry->ip);
122145c00eae84 Jiri Olsa 2024-10-14 6051 remove_hash_entry(direct_functions, del);
122145c00eae84 Jiri Olsa 2024-10-14 6052 kfree(del);
122145c00eae84 Jiri Olsa 2024-10-14 6053 }
122145c00eae84 Jiri Olsa 2024-10-14 6054 }
c488fe4b50d896 Jiri Olsa 2024-09-30 6055 }
59495740f79524 Florent Revest 2023-03-21 6056
c488fe4b50d896 Jiri Olsa 2024-09-30 6057 out_unlock:
c488fe4b50d896 Jiri Olsa 2024-09-30 6058 mutex_unlock(&direct_mutex);
59495740f79524 Florent Revest 2023-03-21 6059 if (free_filters)
59495740f79524 Florent Revest 2023-03-21 6060 ftrace_free_filter(ops);
f64dd4627ec6ed Jiri Olsa 2021-10-08 6061 return err;
f64dd4627ec6ed Jiri Olsa 2021-10-08 6062 }
da8bdfbd422333 Florent Revest 2023-03-21 6063 EXPORT_SYMBOL_GPL(unregister_ftrace_direct);
ccf5a89efd6f0a Jiri Olsa 2021-10-08 6064
:::::: The code at line 6001 was first introduced by commit
:::::: f64dd4627ec6edc39bf1430fe6dbc923d2300a88 ftrace: Add multi direct register/unregister interface
:::::: TO: Jiri Olsa <jolsa@redhat.com>
:::::: CC: Steven Rostedt (VMware) <rostedt@goodmis.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-10-23 6:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-23 6:34 [jolsa-perf:trampoline_multi_10 9/21] kernel/trace/ftrace.c:6001: warning: Function parameter or struct member 'hash' not described in 'unregister_ftrace_direct_hash' kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox