Re: [PATCH RFC] mm: count zeromap read and set for swapout and swapin

Re: [PATCH RFC] mm: count zeromap read and set for swapout and swapin

[kernel test robot]

Hi Barry,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on akpm-mm/mm-everything]

url:    https://github.com/intel-lab-lkp/linux/commits/Barry-Song/mm-count-zeromap-read-and-set-for-swapout-and-swapin/20241027-092054
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20241027011959.9226-1-21cnbao%40gmail.com
patch subject: [PATCH RFC] mm: count zeromap read and set for swapout and swapin
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20241027/202410271221.03oErzAu-lkp@intel.com/config)
compiler: clang version 19.1.2 (https://github.com/llvm/llvm-project 7ba7d8e2f7b6445b60679da826210cdde29eaf8b)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241027/202410271221.03oErzAu-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410271221.03oErzAu-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from mm/page_io.c:14:
   In file included from include/linux/mm.h:2213:
   include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     504 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     505 |                            item];
         |                            ~~~~
   include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     511 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     512 |                            NR_VM_NUMA_EVENT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~~
   include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
     518 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
         |                               ~~~~~~~~~~~ ^ ~~~
   include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     524 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     525 |                            NR_VM_NUMA_EVENT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~~
>> mm/page_io.c:622:39: error: use of undeclared identifier 'MTHP_STAT_SWPIN'
     622 |                 count_mthp_stat(folio_order(folio), MTHP_STAT_SWPIN);
         |                                                     ^
   4 warnings and 1 error generated.


vim +/MTHP_STAT_SWPIN +622 mm/page_io.c

   597	
   598	void swap_read_folio(struct folio *folio, struct swap_iocb **plug)
   599	{
   600		struct swap_info_struct *sis = swp_swap_info(folio->swap);
   601		bool synchronous = sis->flags & SWP_SYNCHRONOUS_IO;
   602		bool workingset = folio_test_workingset(folio);
   603		unsigned long pflags;
   604		bool in_thrashing;
   605	
   606		VM_BUG_ON_FOLIO(!folio_test_swapcache(folio) && !synchronous, folio);
   607		VM_BUG_ON_FOLIO(!folio_test_locked(folio), folio);
   608		VM_BUG_ON_FOLIO(folio_test_uptodate(folio), folio);
   609	
   610		/*
   611		 * Count submission time as memory stall and delay. When the device
   612		 * is congested, or the submitting cgroup IO-throttled, submission
   613		 * can be a significant part of overall IO time.
   614		 */
   615		if (workingset) {
   616			delayacct_thrashing_start(&in_thrashing);
   617			psi_memstall_enter(&pflags);
   618		}
   619		delayacct_swapin_start();
   620	
   621		if (swap_read_folio_zeromap(folio)) {
 > 622			count_mthp_stat(folio_order(folio), MTHP_STAT_SWPIN);
   623			count_memcg_folio_events(folio, PSWPIN, folio_nr_pages(folio));
   624			count_vm_events(PSWPIN, folio_nr_pages(folio));
   625			folio_unlock(folio);
   626			goto finish;
   627		} else if (zswap_load(folio)) {
   628			folio_unlock(folio);
   629			goto finish;
   630		}
   631	
   632		/* We have to read from slower devices. Increase zswap protection. */
   633		zswap_folio_swapin(folio);
   634	
   635		if (data_race(sis->flags & SWP_FS_OPS)) {
   636			swap_read_folio_fs(folio, plug);
   637		} else if (synchronous) {
   638			swap_read_folio_bdev_sync(folio, sis);
   639		} else {
   640			swap_read_folio_bdev_async(folio, sis);
   641		}
   642	
   643	finish:
   644		if (workingset) {
   645			delayacct_thrashing_end(&in_thrashing);
   646			psi_memstall_leave(&pflags);
   647		}
   648		delayacct_swapin_end();
   649	}
   650	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki