* Re: [PATCH v13 3/4] hisi_acc_vfio_pci: register debugfs for hisilicon migration driver
[not found] <20241106100343.21593-4-liulongfang@huawei.com>
@ 2024-11-06 21:11 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-11-06 21:11 UTC (permalink / raw)
To: Longfang Liu, alex.williamson, jgg, shameerali.kolothum.thodi,
jonathan.cameron
Cc: llvm, oe-kbuild-all, kvm, linux-kernel, linuxarm, liulongfang
Hi Longfang,
kernel test robot noticed the following build errors:
[auto build test ERROR on awilliam-vfio/next]
[also build test ERROR on awilliam-vfio/for-linus linus/master v6.12-rc6 next-20241106]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Longfang-Liu/hisi_acc_vfio_pci-extract-public-functions-for-container_of/20241106-182913
base: https://github.com/awilliam/linux-vfio.git next
patch link: https://lore.kernel.org/r/20241106100343.21593-4-liulongfang%40huawei.com
patch subject: [PATCH v13 3/4] hisi_acc_vfio_pci: register debugfs for hisilicon migration driver
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20241107/202411070400.I8XzogJF-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241107/202411070400.I8XzogJF-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411070400.I8XzogJF-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c:9:
In file included from include/linux/hisi_acc_qm.h:10:
In file included from include/linux/pci.h:1650:
In file included from include/linux/dmapool.h:14:
In file included from include/linux/scatterlist.h:8:
In file included from include/linux/mm.h:2213:
include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
504 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
505 | item];
| ~~~~
include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
511 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
512 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
524 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
525 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
>> drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c:1400:4: error: too many arguments to function call, expected 2, have 4
1397 | seq_puts(seq,
| ~~~~~~~~
1398 | "guest driver load: %u\n"
1399 | "data size: %lu\n",
1400 | hisi_acc_vdev->vf_qm_state,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
1401 | sizeof(struct acc_vf_data));
| ~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/seq_file.h:122:29: note: 'seq_puts' declared here
122 | static __always_inline void seq_puts(struct seq_file *m, const char *s)
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c:1429:46: error: too many arguments to function call, expected 2, have 3
1429 | seq_puts(seq, "migrate data length: %lu\n", debug_migf->total_length);
| ~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/seq_file.h:122:29: note: 'seq_puts' declared here
122 | static __always_inline void seq_puts(struct seq_file *m, const char *s)
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
4 warnings and 2 errors generated.
vim +1400 drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c
1364
1365 static int hisi_acc_vf_dev_read(struct seq_file *seq, void *data)
1366 {
1367 struct device *vf_dev = seq->private;
1368 struct vfio_pci_core_device *core_device = dev_get_drvdata(vf_dev);
1369 struct vfio_device *vdev = &core_device->vdev;
1370 struct hisi_acc_vf_core_device *hisi_acc_vdev = hisi_acc_get_vf_dev(vdev);
1371 size_t vf_data_sz = offsetofend(struct acc_vf_data, padding);
1372 struct acc_vf_data *vf_data;
1373 int ret;
1374
1375 mutex_lock(&hisi_acc_vdev->open_mutex);
1376 ret = hisi_acc_vf_debug_check(seq, vdev);
1377 if (ret) {
1378 mutex_unlock(&hisi_acc_vdev->open_mutex);
1379 return ret;
1380 }
1381
1382 mutex_lock(&hisi_acc_vdev->state_mutex);
1383 vf_data = kzalloc(sizeof(*vf_data), GFP_KERNEL);
1384 if (!vf_data) {
1385 ret = -ENOMEM;
1386 goto mutex_release;
1387 }
1388
1389 vf_data->vf_qm_state = hisi_acc_vdev->vf_qm_state;
1390 ret = vf_qm_read_data(&hisi_acc_vdev->vf_qm, vf_data);
1391 if (ret)
1392 goto migf_err;
1393
1394 seq_hex_dump(seq, "Dev Data:", DUMP_PREFIX_OFFSET, 16, 1,
1395 (const void *)vf_data, vf_data_sz, false);
1396
1397 seq_puts(seq,
1398 "guest driver load: %u\n"
1399 "data size: %lu\n",
> 1400 hisi_acc_vdev->vf_qm_state,
1401 sizeof(struct acc_vf_data));
1402
1403 migf_err:
1404 kfree(vf_data);
1405 mutex_release:
1406 mutex_unlock(&hisi_acc_vdev->state_mutex);
1407 mutex_unlock(&hisi_acc_vdev->open_mutex);
1408
1409 return ret;
1410 }
1411
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread