Re: [PATCH v5 16/20] ACPI: platform_profile: Make sure all profile handlers agree on profile

Re: [PATCH v5 16/20] ACPI: platform_profile: Make sure all profile handlers agree on profile

[kernel test robot]

Hi Mario,

kernel test robot noticed the following build warnings:

[auto build test WARNING on d68cb6023356af3bd3193983ad4ec03954a0b3e2]

url:    https://github.com/intel-lab-lkp/linux/commits/Mario-Limonciello/ACPI-platform-profile-Add-a-name-member-to-handlers/20241107-141001
base:   d68cb6023356af3bd3193983ad4ec03954a0b3e2
patch link:    https://lore.kernel.org/r/20241107060254.17615-17-mario.limonciello%40amd.com
patch subject: [PATCH v5 16/20] ACPI: platform_profile: Make sure all profile handlers agree on profile
config: x86_64-buildonly-randconfig-004-20241107 (https://download.01.org/0day-ci/archive/20241107/202411071827.sHhBsmEW-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241107/202411071827.sHhBsmEW-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411071827.sHhBsmEW-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/acpi/platform_profile.c:372:12: warning: converting the enum constant to a boolean [-Wint-in-bool-context]
     372 |         if (i < 0 || PLATFORM_PROFILE_CUSTOM)
         |                   ^
   1 warning generated.


vim +372 drivers/acpi/platform_profile.c

   354	
   355	/**
   356	 * platform_profile_store - Set the profile for legacy sysfs interface
   357	 * @dev: The device
   358	 * @attr: The attribute
   359	 * @buf: The buffer to read from
   360	 * @count: The number of bytes to read
   361	 * Return: The number of bytes read
   362	 */
   363	static ssize_t platform_profile_store(struct device *dev,
   364					      struct device_attribute *attr,
   365					      const char *buf, size_t count)
   366	{
   367		int ret;
   368		int i;
   369	
   370		/* Scan for a matching profile */
   371		i = sysfs_match_string(profile_names, buf);
 > 372		if (i < 0 || PLATFORM_PROFILE_CUSTOM)
   373			return -EINVAL;
   374	
   375		scoped_cond_guard(mutex_intr, return -ERESTARTSYS, &profile_lock) {
   376			ret = class_for_each_device(&platform_profile_class, NULL, &i,
   377						    _store_class_profile);
   378			if (ret)
   379				return ret;
   380			ret = class_for_each_device(&platform_profile_class, NULL, NULL,
   381						    _notify_class_profile);
   382			if (ret)
   383				return ret;
   384		}
   385	
   386		return count;
   387	}
   388	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki