* Re: [PATCH 2/2] spi: imx: support word delay
[not found] <20241107-imx-spi-word-delay-v1-2-2a969214d796@pengutronix.de>
@ 2024-11-08 1:02 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-11-08 1:02 UTC (permalink / raw)
To: Jonas Rebmann, Mark Brown, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: llvm, oe-kbuild-all, linux-spi, imx, linux-arm-kernel,
linux-kernel, devicetree, Jonas Rebmann
Hi Jonas,
kernel test robot noticed the following build errors:
[auto build test ERROR on 9852d85ec9d492ebef56dc5f229416c925758edc]
url: https://github.com/intel-lab-lkp/linux/commits/Jonas-Rebmann/spi-imx-pass-struct-spi_transfer-to-prepare_transfer/20241107-233756
base: 9852d85ec9d492ebef56dc5f229416c925758edc
patch link: https://lore.kernel.org/r/20241107-imx-spi-word-delay-v1-2-2a969214d796%40pengutronix.de
patch subject: [PATCH 2/2] spi: imx: support word delay
config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20241108/202411080814.OtrMOufy-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 592c0fe55f6d9a811028b5f3507be91458ab2713)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241108/202411080814.OtrMOufy-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411080814.OtrMOufy-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from drivers/spi/spi-imx.c:9:
In file included from include/linux/dmaengine.h:12:
In file included from include/linux/scatterlist.h:8:
In file included from include/linux/mm.h:2213:
include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
In file included from drivers/spi/spi-imx.c:9:
In file included from include/linux/dmaengine.h:12:
In file included from include/linux/scatterlist.h:9:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:548:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
548 | val = __raw_readb(PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:561:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
561 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu'
37 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x))
| ^
In file included from drivers/spi/spi-imx.c:9:
In file included from include/linux/dmaengine.h:12:
In file included from include/linux/scatterlist.h:9:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:574:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
574 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu'
35 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x))
| ^
In file included from drivers/spi/spi-imx.c:9:
In file included from include/linux/dmaengine.h:12:
In file included from include/linux/scatterlist.h:9:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:585:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
585 | __raw_writeb(value, PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:595:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
595 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:605:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
605 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
>> drivers/spi/spi-imx.c:739:7: error: call to undeclared function 'FIELD_FIT'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
739 | if (!FIELD_FIT(MX51_ECSPI_PERIOD_MASK, word_delay_sck))
| ^
>> drivers/spi/spi-imx.c:742:9: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
742 | writel(FIELD_PREP(MX51_ECSPI_PERIOD_MASK, word_delay_sck),
| ^
7 warnings and 2 errors generated.
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for MODVERSIONS
Depends on [n]: MODULES [=y] && !COMPILE_TEST [=y]
Selected by [y]:
- RANDSTRUCT_FULL [=y] && (CC_HAS_RANDSTRUCT [=y] || GCC_PLUGINS [=n]) && MODULES [=y]
WARNING: unmet direct dependencies detected for GET_FREE_REGION
Depends on [n]: SPARSEMEM [=n]
Selected by [m]:
- RESOURCE_KUNIT_TEST [=m] && RUNTIME_TESTING_MENU [=y] && KUNIT [=m]
vim +/FIELD_FIT +739 drivers/spi/spi-imx.c
665
666 static int mx51_ecspi_prepare_transfer(struct spi_imx_data *spi_imx,
667 struct spi_device *spi, struct spi_transfer *t)
668 {
669 u32 ctrl = readl(spi_imx->base + MX51_ECSPI_CTRL);
670 u64 word_delay_sck;
671 u32 clk;
672
673 /* Clear BL field and set the right value */
674 ctrl &= ~MX51_ECSPI_CTRL_BL_MASK;
675 if (spi_imx->target_mode && is_imx53_ecspi(spi_imx))
676 ctrl |= (spi_imx->target_burst * 8 - 1)
677 << MX51_ECSPI_CTRL_BL_OFFSET;
678 else {
679 ctrl |= (spi_imx->bits_per_word - 1)
680 << MX51_ECSPI_CTRL_BL_OFFSET;
681 }
682
683 /* set clock speed */
684 ctrl &= ~(0xf << MX51_ECSPI_CTRL_POSTDIV_OFFSET |
685 0xf << MX51_ECSPI_CTRL_PREDIV_OFFSET);
686 ctrl |= mx51_ecspi_clkdiv(spi_imx, spi_imx->spi_bus_clk, &clk);
687 spi_imx->spi_bus_clk = clk;
688
689 mx51_configure_cpha(spi_imx, spi);
690
691 /*
692 * ERR009165: work in XHC mode instead of SMC as PIO on the chips
693 * before i.mx6ul.
694 */
695 if (spi_imx->usedma && spi_imx->devtype_data->tx_glitch_fixed)
696 ctrl |= MX51_ECSPI_CTRL_SMC;
697 else
698 ctrl &= ~MX51_ECSPI_CTRL_SMC;
699
700 writel(ctrl, spi_imx->base + MX51_ECSPI_CTRL);
701
702 /* calculate word delay in SPI Clock (SCLK) cycles */
703 if (t->word_delay.value == 0) {
704 word_delay_sck = 0;
705 } else if (t->word_delay.unit == SPI_DELAY_UNIT_SCK) {
706 word_delay_sck = t->word_delay.value;
707
708 if (word_delay_sck <= MX51_ECSPI_PERIOD_MIN_DELAY_SCK)
709 word_delay_sck = 0;
710 else if (word_delay_sck <= MX51_ECSPI_PERIOD_MIN_DELAY_SCK + 1)
711 word_delay_sck = 1;
712 else
713 word_delay_sck -= MX51_ECSPI_PERIOD_MIN_DELAY_SCK + 1;
714 } else {
715 int word_delay_ns;
716
717 word_delay_ns = spi_delay_to_ns(&t->word_delay, t);
718 if (word_delay_ns < 0)
719 return word_delay_ns;
720
721 if (word_delay_ns <= mul_u64_u32_div(NSEC_PER_SEC,
722 MX51_ECSPI_PERIOD_MIN_DELAY_SCK,
723 spi_imx->spi_bus_clk)) {
724 word_delay_sck = 0;
725 } else if (word_delay_ns <= mul_u64_u32_div(NSEC_PER_SEC,
726 MX51_ECSPI_PERIOD_MIN_DELAY_SCK + 1,
727 spi_imx->spi_bus_clk)) {
728 word_delay_sck = 1;
729 } else {
730 word_delay_ns -= mul_u64_u32_div(NSEC_PER_SEC,
731 MX51_ECSPI_PERIOD_MIN_DELAY_SCK + 1,
732 spi_imx->spi_bus_clk);
733
734 word_delay_sck = DIV_U64_ROUND_UP((u64)word_delay_ns * spi_imx->spi_bus_clk,
735 NSEC_PER_SEC);
736 }
737 }
738
> 739 if (!FIELD_FIT(MX51_ECSPI_PERIOD_MASK, word_delay_sck))
740 return -EINVAL;
741
> 742 writel(FIELD_PREP(MX51_ECSPI_PERIOD_MASK, word_delay_sck),
743 spi_imx->base + MX51_ECSPI_PERIOD);
744
745 return 0;
746 }
747
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread