Re: [PATCH 2/2] procfs: implement PROCFS_SET_GROUPS ioctl

Re: [PATCH 2/2] procfs: implement PROCFS_SET_GROUPS ioctl

[kernel test robot]

Hi Stas,

kernel test robot noticed the following build errors:

[auto build test ERROR on brauner-vfs/vfs.all]
[also build test ERROR on linus/master v6.12-rc6 next-20241108]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Stas-Sergeev/procfs-avoid-some-usages-of-seq_file-private-data/20241108-060856
base:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.all
patch link:    https://lore.kernel.org/r/20241107215821.1514623-3-stsp2%40yandex.ru
patch subject: [PATCH 2/2] procfs: implement PROCFS_SET_GROUPS ioctl
config: x86_64-buildonly-randconfig-004-20241108 (https://download.01.org/0day-ci/archive/20241108/202411081700.kAQXSC2u-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241108/202411081700.kAQXSC2u-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411081700.kAQXSC2u-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from fs/proc/base.c:66:
   In file included from include/linux/mm.h:2213:
   include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
     518 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
         |                               ~~~~~~~~~~~ ^ ~~~
>> fs/proc/base.c:891:8: error: call to undeclared function 'set_current_groups'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     891 |         err = set_current_groups(gi);
         |               ^
   1 warning and 1 error generated.


vim +/set_current_groups +891 fs/proc/base.c

   870	
   871	static int do_proc_setgroups(const struct cred *task_cred,
   872				     const struct cred *cur_cred,
   873				     const struct cred *f_cred)
   874	{
   875		struct group_info *cgi = get_group_info(cur_cred->group_info);
   876		struct group_info *gi = get_group_info(task_cred->group_info);
   877		int err;
   878	
   879		/* Make sure groups didn't change since file open. */
   880		err = -EPERM;
   881		if (f_cred->group_info != gi)
   882			goto out_gi;
   883		/* Don't error if the process is setting the same list again. */
   884		err = 0;
   885		if (cgi == gi)
   886			goto out_gi;
   887	
   888		err = -EPERM;
   889		if (!can_borrow_groups(cur_cred, f_cred))
   890			goto out_gi;
 > 891		err = set_current_groups(gi);
   892	
   893	out_gi:
   894		put_group_info(gi);
   895		put_group_info(cgi);
   896		return err;
   897	}
   898	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki