* Re: [PATCH] net: modernize ioremap in probe
[not found] <20241109233641.8313-1-rosenp@gmail.com>
@ 2024-11-10 20:28 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-11-10 20:28 UTC (permalink / raw)
To: Rosen Penev, netdev
Cc: llvm, oe-kbuild-all, Chandrasekar Ramakrishnan, Marc Kleine-Budde,
Vincent Mailhol, Andrew Lunn, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Kurt Kanzenbach, Vladimir Oltean, Chris Snook,
Marcin Wojtas, Russell King, Horatiu Vultur, UNGLinuxDriver,
Yoshihiro Shimoda, Niklas Söderlund, Doug Berger,
Florian Fainelli, Broadcom internal kernel review list,
Heiner Kallweit, Richard Cochran, linux-can, linux-kernel,
linux-renesas-soc
Hi Rosen,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
[also build test WARNING on next-20241108]
[cannot apply to mkl-can-next/testing net/main linus/master v6.12-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Rosen-Penev/net-modernize-ioremap-in-probe/20241110-073751
base: net-next/main
patch link: https://lore.kernel.org/r/20241109233641.8313-1-rosenp%40gmail.com
patch subject: [PATCH] net: modernize ioremap in probe
config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20241111/202411110419.EQz0nIvL-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 592c0fe55f6d9a811028b5f3507be91458ab2713)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241111/202411110419.EQz0nIvL-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411110419.EQz0nIvL-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from drivers/net/ethernet/freescale/xgmac_mdio.c:16:
In file included from include/linux/acpi_mdio.h:9:
In file included from include/linux/phy.h:16:
In file included from include/linux/ethtool.h:18:
In file included from include/linux/if_ether.h:19:
In file included from include/linux/skbuff.h:17:
In file included from include/linux/bvec.h:10:
In file included from include/linux/highmem.h:10:
In file included from include/linux/mm.h:2213:
include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
In file included from drivers/net/ethernet/freescale/xgmac_mdio.c:16:
In file included from include/linux/acpi_mdio.h:9:
In file included from include/linux/phy.h:16:
In file included from include/linux/ethtool.h:18:
In file included from include/linux/if_ether.h:19:
In file included from include/linux/skbuff.h:17:
In file included from include/linux/bvec.h:10:
In file included from include/linux/highmem.h:12:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:14:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:548:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
548 | val = __raw_readb(PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:561:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
561 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu'
37 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x))
| ^
In file included from drivers/net/ethernet/freescale/xgmac_mdio.c:16:
In file included from include/linux/acpi_mdio.h:9:
In file included from include/linux/phy.h:16:
In file included from include/linux/ethtool.h:18:
In file included from include/linux/if_ether.h:19:
In file included from include/linux/skbuff.h:17:
In file included from include/linux/bvec.h:10:
In file included from include/linux/highmem.h:12:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:14:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:574:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
574 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu'
35 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x))
| ^
In file included from drivers/net/ethernet/freescale/xgmac_mdio.c:16:
In file included from include/linux/acpi_mdio.h:9:
In file included from include/linux/phy.h:16:
In file included from include/linux/ethtool.h:18:
In file included from include/linux/if_ether.h:19:
In file included from include/linux/skbuff.h:17:
In file included from include/linux/bvec.h:10:
In file included from include/linux/highmem.h:12:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:14:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:585:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
585 | __raw_writeb(value, PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:595:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
595 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:605:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
605 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
>> drivers/net/ethernet/freescale/xgmac_mdio.c:395:45: warning: variable 'res' is uninitialized when used here [-Wuninitialized]
395 | snprintf(bus->id, MII_BUS_ID_SIZE, "%pa", &res->start);
| ^~~
drivers/net/ethernet/freescale/xgmac_mdio.c:375:22: note: initialize the variable 'res' to silence this warning
375 | struct resource *res;
| ^
| = NULL
8 warnings generated.
vim +/res +395 drivers/net/ethernet/freescale/xgmac_mdio.c
909bea73485fab5 Tobias Waldekranz 2022-01-26 370
33897cc869eef8b Bill Pemberton 2012-12-03 371 static int xgmac_mdio_probe(struct platform_device *pdev)
9f35a7342cff0be Timur Tabi 2012-08-20 372 {
ac53c26433b51f1 Marcin Wojtas 2021-06-25 373 struct fwnode_handle *fwnode;
73ee5442978b2dd Shaohui Xie 2015-03-16 374 struct mdio_fsl_priv *priv;
15e7064e8793352 Calvin Johnson 2021-06-11 375 struct resource *res;
15e7064e8793352 Calvin Johnson 2021-06-11 376 struct mii_bus *bus;
9f35a7342cff0be Timur Tabi 2012-08-20 377 int ret;
9f35a7342cff0be Timur Tabi 2012-08-20 378
229f4bb47512ece Calvin Johnson 2020-06-22 379 /* In DPAA-1, MDIO is one of the many FMan sub-devices. The FMan
229f4bb47512ece Calvin Johnson 2020-06-22 380 * defines a register space that spans a large area, covering all the
229f4bb47512ece Calvin Johnson 2020-06-22 381 * subdevice areas. Therefore, MDIO cannot claim exclusive access to
229f4bb47512ece Calvin Johnson 2020-06-22 382 * this register area.
229f4bb47512ece Calvin Johnson 2020-06-22 383 */
9f35a7342cff0be Timur Tabi 2012-08-20 384
1d14eb15dc2c396 Tobias Waldekranz 2022-01-26 385 bus = devm_mdiobus_alloc_size(&pdev->dev, sizeof(struct mdio_fsl_priv));
9f35a7342cff0be Timur Tabi 2012-08-20 386 if (!bus)
9f35a7342cff0be Timur Tabi 2012-08-20 387 return -ENOMEM;
9f35a7342cff0be Timur Tabi 2012-08-20 388
9f35a7342cff0be Timur Tabi 2012-08-20 389 bus->name = "Freescale XGMAC MDIO Bus";
c0fc8e6dcee40cf Andrew Lunn 2023-01-09 390 bus->read = xgmac_mdio_read_c22;
c0fc8e6dcee40cf Andrew Lunn 2023-01-09 391 bus->write = xgmac_mdio_write_c22;
c0fc8e6dcee40cf Andrew Lunn 2023-01-09 392 bus->read_c45 = xgmac_mdio_read_c45;
c0fc8e6dcee40cf Andrew Lunn 2023-01-09 393 bus->write_c45 = xgmac_mdio_write_c45;
9f35a7342cff0be Timur Tabi 2012-08-20 394 bus->parent = &pdev->dev;
229f4bb47512ece Calvin Johnson 2020-06-22 @395 snprintf(bus->id, MII_BUS_ID_SIZE, "%pa", &res->start);
9f35a7342cff0be Timur Tabi 2012-08-20 396
73ee5442978b2dd Shaohui Xie 2015-03-16 397 priv = bus->priv;
865bbb2945a1614 Rosen Penev 2024-11-09 398 priv->mdio_base = devm_platform_ioremap_resource(pdev, 0);
865bbb2945a1614 Rosen Penev 2024-11-09 399 if (IS_ERR(priv->mdio_base))
865bbb2945a1614 Rosen Penev 2024-11-09 400 return PTR_ERR(priv->mdio_base);
9f35a7342cff0be Timur Tabi 2012-08-20 401
15e7064e8793352 Calvin Johnson 2021-06-11 402 /* For both ACPI and DT cases, endianness of MDIO controller
15e7064e8793352 Calvin Johnson 2021-06-11 403 * needs to be specified using "little-endian" property.
15e7064e8793352 Calvin Johnson 2021-06-11 404 */
229f4bb47512ece Calvin Johnson 2020-06-22 405 priv->is_little_endian = device_property_read_bool(&pdev->dev,
07bf2e11ad05868 Julia Lawall 2016-08-05 406 "little-endian");
73ee5442978b2dd Shaohui Xie 2015-03-16 407
6198c722019774d Tobias Waldekranz 2022-01-18 408 priv->has_a009885 = device_property_read_bool(&pdev->dev,
6198c722019774d Tobias Waldekranz 2022-01-18 409 "fsl,erratum-a009885");
229f4bb47512ece Calvin Johnson 2020-06-22 410 priv->has_a011043 = device_property_read_bool(&pdev->dev,
1d3ca681b9d9575 Madalin Bucur 2020-01-22 411 "fsl,erratum-a011043");
1d3ca681b9d9575 Madalin Bucur 2020-01-22 412
909bea73485fab5 Tobias Waldekranz 2022-01-26 413 xgmac_mdio_set_suppress_preamble(bus);
909bea73485fab5 Tobias Waldekranz 2022-01-26 414
dd8f467eda72cda Tobias Waldekranz 2022-01-26 415 ret = xgmac_mdio_set_mdc_freq(bus);
dd8f467eda72cda Tobias Waldekranz 2022-01-26 416 if (ret)
dd8f467eda72cda Tobias Waldekranz 2022-01-26 417 return ret;
dd8f467eda72cda Tobias Waldekranz 2022-01-26 418
105b0468d7b2e67 zhaoxiao 2022-08-18 419 fwnode = dev_fwnode(&pdev->dev);
ac53c26433b51f1 Marcin Wojtas 2021-06-25 420 if (is_of_node(fwnode))
ac53c26433b51f1 Marcin Wojtas 2021-06-25 421 ret = of_mdiobus_register(bus, to_of_node(fwnode));
ac53c26433b51f1 Marcin Wojtas 2021-06-25 422 else if (is_acpi_node(fwnode))
ac53c26433b51f1 Marcin Wojtas 2021-06-25 423 ret = acpi_mdiobus_register(bus, fwnode);
ac53c26433b51f1 Marcin Wojtas 2021-06-25 424 else
ac53c26433b51f1 Marcin Wojtas 2021-06-25 425 ret = -EINVAL;
9f35a7342cff0be Timur Tabi 2012-08-20 426 if (ret) {
9f35a7342cff0be Timur Tabi 2012-08-20 427 dev_err(&pdev->dev, "cannot register MDIO bus\n");
9f35a7342cff0be Timur Tabi 2012-08-20 428 return ret;
9f35a7342cff0be Timur Tabi 2012-08-20 429 }
9f35a7342cff0be Timur Tabi 2012-08-20 430
1d14eb15dc2c396 Tobias Waldekranz 2022-01-26 431 platform_set_drvdata(pdev, bus);
9f35a7342cff0be Timur Tabi 2012-08-20 432
9f35a7342cff0be Timur Tabi 2012-08-20 433 return 0;
9f35a7342cff0be Timur Tabi 2012-08-20 434 }
9f35a7342cff0be Timur Tabi 2012-08-20 435
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-11-10 20:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20241109233641.8313-1-rosenp@gmail.com>
2024-11-10 20:28 ` [PATCH] net: modernize ioremap in probe kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox