Re: [RFC PATCH 02/29] dma-fence: Add dma_fence_user_fence

[kernel test robot <lkp@intel.com>]

Hi Matthew,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on drm-xe/drm-xe-next]
[also build test WARNING on drm-exynos/exynos-drm-next linus/master drm/drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-misc/drm-misc-next drm-tip/drm-tip v6.12 next-20241121]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Matthew-Brost/dma-fence-Add-dma_fence_preempt-base-class/20241121-124856
base:   https://gitlab.freedesktop.org/drm/xe/kernel.git drm-xe-next
patch link:    https://lore.kernel.org/r/20241118233757.2374041-3-matthew.brost%40intel.com
patch subject: [RFC PATCH 02/29] dma-fence: Add dma_fence_user_fence
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20241121/202411211817.zrnXCVkd-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241121/202411211817.zrnXCVkd-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411211817.zrnXCVkd-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/dma-buf/dma-fence-user-fence.c:41: warning: Function parameter or struct member 'user_fence' not described in 'dma_fence_user_fence_free'
>> drivers/dma-buf/dma-fence-user-fence.c:63: warning: Function parameter or struct member 'user_fence' not described in 'dma_fence_user_fence_attach'


vim +41 drivers/dma-buf/dma-fence-user-fence.c

    32	
    33	/**
    34	 * dma_fence_user_fence_free() - Free user fence
    35	 *
    36	 * Free user fence. Should only be called on a user fence if
    37	 * dma_fence_user_fence_attach is not called to cleanup original allocation from
    38	 * dma_fence_user_fence_alloc.
    39	 */
    40	void dma_fence_user_fence_free(struct dma_fence_user_fence *user_fence)
  > 41	{
    42		kfree(user_fence);
    43	}
    44	EXPORT_SYMBOL(dma_fence_user_fence_free);
    45	
    46	/**
    47	 * dma_fence_user_fence_attach() - Attach user fence to dma-fence
    48	 *
    49	 * @fence: fence
    50	 * @user_fence user fence
    51	 * @map: IOSYS map to write seqno to
    52	 * @seqno: seqno to write to IOSYS map
    53	 *
    54	 * Attach a user fence, which is a seqno write to an IOSYS map, to a DMA fence.
    55	 * The caller must guarantee that the memory in the IOSYS map doesn't move
    56	 * before the fence signals. This is typically done by installing the DMA fence
    57	 * into the BO's DMA reservation bookkeeping slot from which the IOSYS was
    58	 * derived.
    59	 */
    60	void dma_fence_user_fence_attach(struct dma_fence *fence,
    61					 struct dma_fence_user_fence *user_fence,
    62					 struct iosys_map *map, u64 seqno)
  > 63	{

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki