* Re: [RFC PATCH 02/29] dma-fence: Add dma_fence_user_fence
[not found] <20241118233757.2374041-3-matthew.brost@intel.com>
@ 2024-11-21 10:28 ` kernel test robot
2024-11-21 21:12 ` kernel test robot
2024-11-21 23:59 ` kernel test robot
2 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2024-11-21 10:28 UTC (permalink / raw)
To: Matthew Brost; +Cc: llvm, oe-kbuild-all
Hi Matthew,
[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:
[auto build test WARNING on drm-xe/drm-xe-next]
[also build test WARNING on drm-exynos/exynos-drm-next linus/master drm/drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-misc/drm-misc-next drm-tip/drm-tip v6.12 next-20241121]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Matthew-Brost/dma-fence-Add-dma_fence_preempt-base-class/20241121-124856
base: https://gitlab.freedesktop.org/drm/xe/kernel.git drm-xe-next
patch link: https://lore.kernel.org/r/20241118233757.2374041-3-matthew.brost%40intel.com
patch subject: [RFC PATCH 02/29] dma-fence: Add dma_fence_user_fence
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20241121/202411211817.zrnXCVkd-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241121/202411211817.zrnXCVkd-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411211817.zrnXCVkd-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/dma-buf/dma-fence-user-fence.c:41: warning: Function parameter or struct member 'user_fence' not described in 'dma_fence_user_fence_free'
>> drivers/dma-buf/dma-fence-user-fence.c:63: warning: Function parameter or struct member 'user_fence' not described in 'dma_fence_user_fence_attach'
vim +41 drivers/dma-buf/dma-fence-user-fence.c
32
33 /**
34 * dma_fence_user_fence_free() - Free user fence
35 *
36 * Free user fence. Should only be called on a user fence if
37 * dma_fence_user_fence_attach is not called to cleanup original allocation from
38 * dma_fence_user_fence_alloc.
39 */
40 void dma_fence_user_fence_free(struct dma_fence_user_fence *user_fence)
> 41 {
42 kfree(user_fence);
43 }
44 EXPORT_SYMBOL(dma_fence_user_fence_free);
45
46 /**
47 * dma_fence_user_fence_attach() - Attach user fence to dma-fence
48 *
49 * @fence: fence
50 * @user_fence user fence
51 * @map: IOSYS map to write seqno to
52 * @seqno: seqno to write to IOSYS map
53 *
54 * Attach a user fence, which is a seqno write to an IOSYS map, to a DMA fence.
55 * The caller must guarantee that the memory in the IOSYS map doesn't move
56 * before the fence signals. This is typically done by installing the DMA fence
57 * into the BO's DMA reservation bookkeeping slot from which the IOSYS was
58 * derived.
59 */
60 void dma_fence_user_fence_attach(struct dma_fence *fence,
61 struct dma_fence_user_fence *user_fence,
62 struct iosys_map *map, u64 seqno)
> 63 {
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [RFC PATCH 02/29] dma-fence: Add dma_fence_user_fence
[not found] <20241118233757.2374041-3-matthew.brost@intel.com>
2024-11-21 10:28 ` [RFC PATCH 02/29] dma-fence: Add dma_fence_user_fence kernel test robot
@ 2024-11-21 21:12 ` kernel test robot
2024-11-21 23:59 ` kernel test robot
2 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2024-11-21 21:12 UTC (permalink / raw)
To: Matthew Brost; +Cc: llvm, oe-kbuild-all
Hi Matthew,
[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:
[auto build test ERROR on drm-xe/drm-xe-next]
[also build test ERROR on drm-exynos/exynos-drm-next linus/master drm/drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-misc/drm-misc-next drm-tip/drm-tip v6.12 next-20241121]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Matthew-Brost/dma-fence-Add-dma_fence_preempt-base-class/20241121-124856
base: https://gitlab.freedesktop.org/drm/xe/kernel.git drm-xe-next
patch link: https://lore.kernel.org/r/20241118233757.2374041-3-matthew.brost%40intel.com
patch subject: [RFC PATCH 02/29] dma-fence: Add dma_fence_user_fence
config: hexagon-randconfig-002-20241121 (https://download.01.org/0day-ci/archive/20241122/202411220754.4LD2Xt3z-lkp@intel.com/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241122/202411220754.4LD2Xt3z-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411220754.4LD2Xt3z-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from drivers/dma-buf/dma-fence-user-fence.c:6:
In file included from include/linux/dma-fence-user-fence.h:10:
In file included from include/linux/iosys-map.h:10:
In file included from include/linux/io.h:14:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:548:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __raw_readb(PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:561:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu'
#define __le16_to_cpu(x) ((__force __u16)(__le16)(x))
^
In file included from drivers/dma-buf/dma-fence-user-fence.c:6:
In file included from include/linux/dma-fence-user-fence.h:10:
In file included from include/linux/iosys-map.h:10:
In file included from include/linux/io.h:14:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:574:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu'
#define __le32_to_cpu(x) ((__force __u32)(__le32)(x))
^
In file included from drivers/dma-buf/dma-fence-user-fence.c:6:
In file included from include/linux/dma-fence-user-fence.h:10:
In file included from include/linux/iosys-map.h:10:
In file included from include/linux/io.h:14:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:585:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
__raw_writeb(value, PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:595:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
__raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:605:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
__raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
~~~~~~~~~~ ^
>> drivers/dma-buf/dma-fence-user-fence.c:15:3: error: call to undeclared function 'writeq'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
writeq(user_fence->seqno, user_fence->map.vaddr_iomem);
^
6 warnings and 1 error generated.
vim +/writeq +15 drivers/dma-buf/dma-fence-user-fence.c
8
9 static void user_fence_cb(struct dma_fence *fence, struct dma_fence_cb *cb)
10 {
11 struct dma_fence_user_fence *user_fence =
12 container_of(cb, struct dma_fence_user_fence, cb);
13
14 if (user_fence->map.is_iomem)
> 15 writeq(user_fence->seqno, user_fence->map.vaddr_iomem);
16 else
17 *(u64 *)user_fence->map.vaddr = user_fence->seqno;
18
19 dma_fence_user_fence_free(user_fence);
20 }
21
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [RFC PATCH 02/29] dma-fence: Add dma_fence_user_fence
[not found] <20241118233757.2374041-3-matthew.brost@intel.com>
2024-11-21 10:28 ` [RFC PATCH 02/29] dma-fence: Add dma_fence_user_fence kernel test robot
2024-11-21 21:12 ` kernel test robot
@ 2024-11-21 23:59 ` kernel test robot
2 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2024-11-21 23:59 UTC (permalink / raw)
To: Matthew Brost; +Cc: llvm, oe-kbuild-all
Hi Matthew,
[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:
[auto build test ERROR on drm-xe/drm-xe-next]
[also build test ERROR on drm-exynos/exynos-drm-next linus/master drm/drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-misc/drm-misc-next drm-tip/drm-tip v6.12 next-20241121]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Matthew-Brost/dma-fence-Add-dma_fence_preempt-base-class/20241121-124856
base: https://gitlab.freedesktop.org/drm/xe/kernel.git drm-xe-next
patch link: https://lore.kernel.org/r/20241118233757.2374041-3-matthew.brost%40intel.com
patch subject: [RFC PATCH 02/29] dma-fence: Add dma_fence_user_fence
config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20241122/202411220719.Zhxq1Vjq-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 592c0fe55f6d9a811028b5f3507be91458ab2713)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241122/202411220719.Zhxq1Vjq-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411220719.Zhxq1Vjq-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from drivers/dma-buf/dma-fence-user-fence.c:6:
In file included from include/linux/dma-fence-user-fence.h:10:
In file included from include/linux/iosys-map.h:10:
In file included from include/linux/io.h:14:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:548:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
548 | val = __raw_readb(PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:561:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
561 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu'
37 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x))
| ^
In file included from drivers/dma-buf/dma-fence-user-fence.c:6:
In file included from include/linux/dma-fence-user-fence.h:10:
In file included from include/linux/iosys-map.h:10:
In file included from include/linux/io.h:14:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:574:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
574 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu'
35 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x))
| ^
In file included from drivers/dma-buf/dma-fence-user-fence.c:6:
In file included from include/linux/dma-fence-user-fence.h:10:
In file included from include/linux/iosys-map.h:10:
In file included from include/linux/io.h:14:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:585:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
585 | __raw_writeb(value, PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:595:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
595 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:605:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
605 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
>> drivers/dma-buf/dma-fence-user-fence.c:15:3: error: call to undeclared function 'writeq'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
15 | writeq(user_fence->seqno, user_fence->map.vaddr_iomem);
| ^
6 warnings and 1 error generated.
vim +/writeq +15 drivers/dma-buf/dma-fence-user-fence.c
8
9 static void user_fence_cb(struct dma_fence *fence, struct dma_fence_cb *cb)
10 {
11 struct dma_fence_user_fence *user_fence =
12 container_of(cb, struct dma_fence_user_fence, cb);
13
14 if (user_fence->map.is_iomem)
> 15 writeq(user_fence->seqno, user_fence->map.vaddr_iomem);
16 else
17 *(u64 *)user_fence->map.vaddr = user_fence->seqno;
18
19 dma_fence_user_fence_free(user_fence);
20 }
21
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread