* Re: [PATCH 04/10] drm/i915/histogram: Add support for histogram
[not found] <20241209162504.2146697-5-arun.r.murthy@intel.com>
@ 2024-12-11 0:08 ` kernel test robot
2024-12-12 10:18 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2024-12-11 0:08 UTC (permalink / raw)
To: Arun R Murthy; +Cc: llvm, oe-kbuild-all
Hi Arun,
kernel test robot noticed the following build errors:
[auto build test ERROR on linus/master]
[also build test ERROR on drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip v6.13-rc2 next-20241210]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Arun-R-Murthy/drm-crtc-Add-histogram-properties/20241210-003717
base: linus/master
patch link: https://lore.kernel.org/r/20241209162504.2146697-5-arun.r.murthy%40intel.com
patch subject: [PATCH 04/10] drm/i915/histogram: Add support for histogram
config: x86_64-randconfig-002-20241210 (https://download.01.org/0day-ci/archive/20241211/202412110725.YaOtG2y8-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241211/202412110725.YaOtG2y8-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412110725.YaOtG2y8-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from drivers/gpu/drm/i915/display/intel_histogram.c:7:
In file included from include/drm/drm_file.h:39:
In file included from include/drm/drm_prime.h:37:
In file included from include/linux/scatterlist.h:8:
In file included from include/linux/mm.h:2223:
include/linux/vmstat.h:518:36: error: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Werror,-Wenum-enum-conversion]
518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
>> drivers/gpu/drm/i915/display/intel_histogram.c:145:7: error: variable 'data' is uninitialized when used here [-Werror,-Wuninitialized]
145 | if (!data) {
| ^~~~
drivers/gpu/drm/i915/display/intel_histogram.c:134:11: note: initialize the variable 'data' to silence this warning
134 | u32 *data;
| ^
| = NULL
2 errors generated.
vim +/data +145 drivers/gpu/drm/i915/display/intel_histogram.c
125
126 int intel_histogram_set_iet_lut(struct intel_crtc *intel_crtc,
127 struct drm_property_blob *blob)
128 {
129 struct intel_histogram *histogram = intel_crtc->histogram;
130 struct intel_display *display = to_intel_display(intel_crtc);
131 int pipe = intel_crtc->pipe;
132 int i = 0;
133 struct drm_iet *iet;
134 u32 *data;
135 int ret;
136
137 if (!histogram)
138 return -EINVAL;
139
140 if (!histogram->enable) {
141 drm_err(display->drm, "histogram not enabled");
142 return -EINVAL;
143 }
144
> 145 if (!data) {
146 drm_err(display->drm, "enhancement LUT data is NULL");
147 return -EINVAL;
148 }
149
150 /* Set DPST_CTL Bin Reg function select to IE & wait for a vblabk */
151 intel_de_rmw(display, DPST_CTL(pipe),
152 DPST_CTL_BIN_REG_FUNC_SEL, DPST_CTL_BIN_REG_FUNC_IE);
153
154 drm_crtc_wait_one_vblank(&intel_crtc->base);
155
156 /* Set DPST_CTL Bin Register Index to 0 */
157 intel_de_rmw(display, DPST_CTL(pipe),
158 DPST_CTL_BIN_REG_MASK, DPST_CTL_BIN_REG_CLEAR);
159
160 iet = (struct drm_iet *)blob->data;
161 data = kzalloc(sizeof(data) * iet->nr_elements, GFP_KERNEL);
162 if (!data)
163 return -ENOMEM;
164 ret = copy_from_user(data, (uint32_t __user *)(unsigned long)iet->data_ptr,
165 sizeof(uint32_t) * iet->nr_elements);
166 if (ret)
167 return ret;
168
169 for (i = 0; i < HISTOGRAM_IET_LENGTH; i++) {
170 intel_de_rmw(display, DPST_BIN(pipe),
171 DPST_BIN_DATA_MASK, data[i]);
172 drm_dbg_atomic(display->drm, "iet_lut[%d]=%x\n", i, data[i]);
173 }
174 kfree(data);
175 drm_property_blob_put(intel_crtc->base.state->histogram_iet);
176
177 return 0;
178 }
179
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread