* Re: [PATCH] btrfs: edit __btrfs_add_delayed_item() to use rb helper
[not found] <9b85bdbc269d20886590f0a70de66c602d72aa9d.1733695544.git.beckerlee3@gmail.com>
@ 2024-12-09 5:07 ` kernel test robot
2024-12-12 1:18 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2024-12-09 5:07 UTC (permalink / raw)
To: Roger L. Beckermeyer III, linux-btrfs
Cc: llvm, oe-kbuild-all, Roger L. Beckermeyer III
Hi Roger,
kernel test robot noticed the following build errors:
[auto build test ERROR on kdave/for-next]
[also build test ERROR on linus/master v6.13-rc2 next-20241206]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Roger-L-Beckermeyer-III/btrfs-edit-__btrfs_add_delayed_item-to-use-rb-helper/20241209-064154
base: https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-next
patch link: https://lore.kernel.org/r/9b85bdbc269d20886590f0a70de66c602d72aa9d.1733695544.git.beckerlee3%40gmail.com
patch subject: [PATCH] btrfs: edit __btrfs_add_delayed_item() to use rb helper
config: arm-randconfig-001-20241209 (https://download.01.org/0day-ci/archive/20241209/202412091036.JGaCqbvL-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 592c0fe55f6d9a811028b5f3507be91458ab2713)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241209/202412091036.JGaCqbvL-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412091036.JGaCqbvL-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from fs/btrfs/delayed-inode.c:9:
In file included from fs/btrfs/ctree.h:10:
In file included from include/linux/pagemap.h:8:
In file included from include/linux/mm.h:2223:
include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
>> fs/btrfs/delayed-inode.c:392:10: error: call to undeclared function 'rb_find_add_cached'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
392 | exist = rb_find_add_cached(&ins->rb_node, root, btrfs_add_delayed_item_cmp);
| ^
>> fs/btrfs/delayed-inode.c:392:8: error: incompatible integer to pointer conversion assigning to 'struct rb_node *' from 'int' [-Wint-conversion]
392 | exist = rb_find_add_cached(&ins->rb_node, root, btrfs_add_delayed_item_cmp);
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning and 2 errors generated.
vim +/rb_find_add_cached +392 fs/btrfs/delayed-inode.c
380
381 static int __btrfs_add_delayed_item(struct btrfs_delayed_node *delayed_node,
382 struct btrfs_delayed_item *ins)
383 {
384 struct rb_root_cached *root;
385 struct rb_node *exist;
386
387 if (ins->type == BTRFS_DELAYED_INSERTION_ITEM)
388 root = &delayed_node->ins_root;
389 else
390 root = &delayed_node->del_root;
391
> 392 exist = rb_find_add_cached(&ins->rb_node, root, btrfs_add_delayed_item_cmp);
393 if (exist != NULL)
394 return -EEXIST;
395
396 if (ins->type == BTRFS_DELAYED_INSERTION_ITEM &&
397 ins->index >= delayed_node->index_cnt)
398 delayed_node->index_cnt = ins->index + 1;
399
400 delayed_node->count++;
401 atomic_inc(&delayed_node->root->fs_info->delayed_root->items);
402 return 0;
403 }
404
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] btrfs: edit __btrfs_add_delayed_item() to use rb helper
[not found] <9b85bdbc269d20886590f0a70de66c602d72aa9d.1733695544.git.beckerlee3@gmail.com>
2024-12-09 5:07 ` [PATCH] btrfs: edit __btrfs_add_delayed_item() to use rb helper kernel test robot
@ 2024-12-12 1:18 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2024-12-12 1:18 UTC (permalink / raw)
To: Roger L. Beckermeyer III, linux-btrfs
Cc: llvm, oe-kbuild-all, Roger L. Beckermeyer III
Hi Roger,
kernel test robot noticed the following build errors:
[auto build test ERROR on kdave/for-next]
[also build test ERROR on linus/master v6.13-rc2 next-20241211]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Roger-L-Beckermeyer-III/btrfs-edit-__btrfs_add_delayed_item-to-use-rb-helper/20241209-104443
base: https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-next
patch link: https://lore.kernel.org/r/9b85bdbc269d20886590f0a70de66c602d72aa9d.1733695544.git.beckerlee3%40gmail.com
patch subject: [PATCH] btrfs: edit __btrfs_add_delayed_item() to use rb helper
config: s390-defconfig (https://download.01.org/0day-ci/archive/20241212/202412120959.0utuK69J-lkp@intel.com/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241212/202412120959.0utuK69J-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412120959.0utuK69J-lkp@intel.com/
All errors (new ones prefixed by >>):
>> fs/btrfs/delayed-inode.c:392:10: error: call to undeclared function 'rb_find_add_cached'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
exist = rb_find_add_cached(&ins->rb_node, root, btrfs_add_delayed_item_cmp);
^
fs/btrfs/delayed-inode.c:392:8: error: incompatible integer to pointer conversion assigning to 'struct rb_node *' from 'int' [-Wint-conversion]
exist = rb_find_add_cached(&ins->rb_node, root, btrfs_add_delayed_item_cmp);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 errors generated.
vim +/rb_find_add_cached +392 fs/btrfs/delayed-inode.c
380
381 static int __btrfs_add_delayed_item(struct btrfs_delayed_node *delayed_node,
382 struct btrfs_delayed_item *ins)
383 {
384 struct rb_root_cached *root;
385 struct rb_node *exist;
386
387 if (ins->type == BTRFS_DELAYED_INSERTION_ITEM)
388 root = &delayed_node->ins_root;
389 else
390 root = &delayed_node->del_root;
391
> 392 exist = rb_find_add_cached(&ins->rb_node, root, btrfs_add_delayed_item_cmp);
393 if (exist != NULL)
394 return -EEXIST;
395
396 if (ins->type == BTRFS_DELAYED_INSERTION_ITEM &&
397 ins->index >= delayed_node->index_cnt)
398 delayed_node->index_cnt = ins->index + 1;
399
400 delayed_node->count++;
401 atomic_inc(&delayed_node->root->fs_info->delayed_root->items);
402 return 0;
403 }
404
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread