* Re: [PATCH v7 3/4] sched, psi: Don't account irq time if sched_clock_irqtime is disabled
[not found] <20241215032315.43698-4-laoar.shao@gmail.com>
@ 2024-12-15 13:50 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-12-15 13:50 UTC (permalink / raw)
To: Yafang Shao, mingo, peterz, mkoutny, hannes
Cc: llvm, oe-kbuild-all, juri.lelli, vincent.guittot,
dietmar.eggemann, rostedt, bsegall, mgorman, vschneid, surenb,
linux-kernel, cgroups, Yafang Shao
Hi Yafang,
kernel test robot noticed the following build errors:
[auto build test ERROR on tip/sched/core]
[also build test ERROR on peterz-queue/sched/core linus/master v6.13-rc2 next-20241213]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Yafang-Shao/sched-Define-sched_clock_irqtime-as-static-key/20241215-112638
base: tip/sched/core
patch link: https://lore.kernel.org/r/20241215032315.43698-4-laoar.shao%40gmail.com
patch subject: [PATCH v7 3/4] sched, psi: Don't account irq time if sched_clock_irqtime is disabled
config: arm-randconfig-001-20241215 (https://download.01.org/0day-ci/archive/20241215/202412152115.zQ6k9tVk-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 2dc22615fd46ab2566d0f26d5ba234ab12dc4bf8)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241215/202412152115.zQ6k9tVk-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412152115.zQ6k9tVk-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from kernel/sched/build_utility.c:15:
In file included from include/linux/sched/isolation.h:5:
In file included from include/linux/cpuset.h:17:
In file included from include/linux/mm.h:2223:
include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
In file included from kernel/sched/build_utility.c:96:
>> kernel/sched/psi.c:1243:35: error: use of undeclared identifier 'PSI_IRQ'; did you mean 'PSI_IO'?
1243 | if (!irqtime_enabled() && res == PSI_IRQ)
| ^~~~~~~
| PSI_IO
include/linux/psi_types.h:42:2: note: 'PSI_IO' declared here
42 | PSI_IO,
| ^
1 warning and 1 error generated.
vim +1243 kernel/sched/psi.c
1233
1234 int psi_show(struct seq_file *m, struct psi_group *group, enum psi_res res)
1235 {
1236 bool only_full = false;
1237 int full;
1238 u64 now;
1239
1240 if (static_branch_likely(&psi_disabled))
1241 return -EOPNOTSUPP;
1242
> 1243 if (!irqtime_enabled() && res == PSI_IRQ)
1244 return -EOPNOTSUPP;
1245
1246 /* Update averages before reporting them */
1247 mutex_lock(&group->avgs_lock);
1248 now = sched_clock();
1249 collect_percpu_times(group, PSI_AVGS, NULL);
1250 if (now >= group->avg_next_update)
1251 group->avg_next_update = update_averages(group, now);
1252 mutex_unlock(&group->avgs_lock);
1253
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread