* Re: [PATCH v2 10/10] HID: Add hid-universal-pidff driver and supported device ids
[not found] <20250105193628.296350-11-tomasz.pakula.oficjalny@gmail.com>
@ 2025-01-06 18:26 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2025-01-06 18:26 UTC (permalink / raw)
To: Tomasz Pakuła, jikos, bentiss
Cc: llvm, oe-kbuild-all, linux-input, linux-usb
Hi Tomasz,
kernel test robot noticed the following build errors:
[auto build test ERROR on hid/for-next]
[also build test ERROR on linus/master v6.13-rc6 next-20241220]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Tomasz-Paku-a/HID-pidff-Convert-infinite-length-from-Linux-API-to-PID-standard/20250106-033931
base: https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-next
patch link: https://lore.kernel.org/r/20250105193628.296350-11-tomasz.pakula.oficjalny%40gmail.com
patch subject: [PATCH v2 10/10] HID: Add hid-universal-pidff driver and supported device ids
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20250107/202501070200.pA9ifqd5-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250107/202501070200.pA9ifqd5-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501070200.pA9ifqd5-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from drivers/hid/hid-universal-pidff.c:11:
In file included from include/linux/device.h:32:
In file included from include/linux/device/driver.h:21:
In file included from include/linux/module.h:19:
In file included from include/linux/elf.h:6:
In file included from arch/s390/include/asm/elf.h:181:
In file included from arch/s390/include/asm/mmu_context.h:11:
In file included from arch/s390/include/asm/pgalloc.h:18:
In file included from include/linux/mm.h:2223:
include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
504 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
505 | item];
| ~~~~
include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
511 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
512 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
524 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
525 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
>> drivers/hid/hid-universal-pidff.c:90:16: error: incompatible function pointer types assigning to 'void (*)(struct hid_device *, __u32)' (aka 'void (*)(struct hid_device *, unsigned int)') from 'int (struct hid_device *, __u32)' (aka 'int (struct hid_device *, unsigned int)') [-Wincompatible-function-pointer-types]
90 | init_function = hid_pidff_init_with_quirks;
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/hid/hid-universal-pidff.c:97:8: error: assigning to 'int' from incompatible type 'void'
97 | error = init_function(hdev, id->driver_data);
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
4 warnings and 2 errors generated.
vim +90 drivers/hid/hid-universal-pidff.c
66
67
68 /*
69 * Check if the device is PID and initialize it
70 * Add quirks after initialisation
71 */
72 static int universal_pidff_probe(struct hid_device *hdev,
73 const struct hid_device_id *id)
74 {
75 int error;
76 error = hid_parse(hdev);
77 if (error) {
78 hid_err(hdev, "HID parse failed\n");
79 goto err;
80 }
81
82 error = hid_hw_start(hdev, HID_CONNECT_DEFAULT & ~HID_CONNECT_FF);
83 if (error) {
84 hid_err(hdev, "HID hw start failed\n");
85 goto err;
86 }
87
88 // Check if HID_PID support is enabled
89 void (*init_function)(struct hid_device *, __u32);
> 90 init_function = hid_pidff_init_with_quirks;
91
92 if (!init_function) {
93 hid_warn(hdev, "HID_PID support not enabled!\n");
94 return 0;
95 }
96
> 97 error = init_function(hdev, id->driver_data);
98 if (error) {
99 hid_warn(hdev, "Force Feedback initialization failed\n");
100 goto err;
101 }
102
103 hid_info(hdev, "Universal pidff driver loaded sucesfully!");
104
105 return 0;
106 err:
107 return error;
108 }
109
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread