Re: [RFC net-next 1/2] netdev-genl: Add an XSK attribute to queues

Re: [RFC net-next 1/2] netdev-genl: Add an XSK attribute to queues

[kernel test robot]

Hi Joe,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on 0ad9617c78acbc71373fb341a6f75d4012b01d69]

url:    https://github.com/intel-lab-lkp/linux/commits/Joe-Damato/netdev-genl-Add-an-XSK-attribute-to-queues/20250130-012820
base:   0ad9617c78acbc71373fb341a6f75d4012b01d69
patch link:    https://lore.kernel.org/r/20250129172431.65773-2-jdamato%40fastly.com
patch subject: [RFC net-next 1/2] netdev-genl: Add an XSK attribute to queues
config: hexagon-randconfig-002-20250130 (https://download.01.org/0day-ci/archive/20250130/202501301434.ZoSDVYrs-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 19306351a2c45e266fa11b41eb1362b20b6ca56d)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250130/202501301434.ZoSDVYrs-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501301434.ZoSDVYrs-lkp@intel.com/

All errors (new ones prefixed by >>):

>> net/core/netdev-genl.c:397:51: error: no member named 'pool' in 'struct netdev_rx_queue'
     397 |                 if (nla_put_u32(rsp, NETDEV_A_QUEUE_XSK, !!rxq->pool))
         |                                                            ~~~  ^
>> net/core/netdev-genl.c:407:51: error: no member named 'pool' in 'struct netdev_queue'
     407 |                 if (nla_put_u32(rsp, NETDEV_A_QUEUE_XSK, !!txq->pool))
         |                                                            ~~~  ^
   2 errors generated.


vim +397 net/core/netdev-genl.c

   366	
   367	static int
   368	netdev_nl_queue_fill_one(struct sk_buff *rsp, struct net_device *netdev,
   369				 u32 q_idx, u32 q_type, const struct genl_info *info)
   370	{
   371		struct net_devmem_dmabuf_binding *binding;
   372		struct netdev_rx_queue *rxq;
   373		struct netdev_queue *txq;
   374		void *hdr;
   375	
   376		hdr = genlmsg_iput(rsp, info);
   377		if (!hdr)
   378			return -EMSGSIZE;
   379	
   380		if (nla_put_u32(rsp, NETDEV_A_QUEUE_ID, q_idx) ||
   381		    nla_put_u32(rsp, NETDEV_A_QUEUE_TYPE, q_type) ||
   382		    nla_put_u32(rsp, NETDEV_A_QUEUE_IFINDEX, netdev->ifindex))
   383			goto nla_put_failure;
   384	
   385		switch (q_type) {
   386		case NETDEV_QUEUE_TYPE_RX:
   387			rxq = __netif_get_rx_queue(netdev, q_idx);
   388			if (rxq->napi && nla_put_u32(rsp, NETDEV_A_QUEUE_NAPI_ID,
   389						     rxq->napi->napi_id))
   390				goto nla_put_failure;
   391	
   392			binding = rxq->mp_params.mp_priv;
   393			if (binding &&
   394			    nla_put_u32(rsp, NETDEV_A_QUEUE_DMABUF, binding->id))
   395				goto nla_put_failure;
   396	
 > 397			if (nla_put_u32(rsp, NETDEV_A_QUEUE_XSK, !!rxq->pool))
   398				goto nla_put_failure;
   399	
   400			break;
   401		case NETDEV_QUEUE_TYPE_TX:
   402			txq = netdev_get_tx_queue(netdev, q_idx);
   403			if (txq->napi && nla_put_u32(rsp, NETDEV_A_QUEUE_NAPI_ID,
   404						     txq->napi->napi_id))
   405				goto nla_put_failure;
   406	
 > 407			if (nla_put_u32(rsp, NETDEV_A_QUEUE_XSK, !!txq->pool))
   408				goto nla_put_failure;
   409		}
   410	
   411		genlmsg_end(rsp, hdr);
   412	
   413		return 0;
   414	
   415	nla_put_failure:
   416		genlmsg_cancel(rsp, hdr);
   417		return -EMSGSIZE;
   418	}
   419	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki