Re: [RFC PATCH 2/5] mfd: Add ROHM BD79124 ADC/GPO

Re: [RFC PATCH 2/5] mfd: Add ROHM BD79124 ADC/GPO

[kernel test robot]

Hi Matti,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on 5bc55a333a2f7316b58edc7573e8e893f7acb532]

url:    https://github.com/intel-lab-lkp/linux/commits/Matti-Vaittinen/dt-bindings-ROHM-BD79124-ADC-GPO/20250131-214129
base:   5bc55a333a2f7316b58edc7573e8e893f7acb532
patch link:    https://lore.kernel.org/r/cc30cf6859b5e5a7320282709f428cd42717ac6b.1738328714.git.mazziesaccount%40gmail.com
patch subject: [RFC PATCH 2/5] mfd: Add ROHM BD79124 ADC/GPO
config: hexagon-allyesconfig (https://download.01.org/0day-ci/archive/20250201/202502011801.rWqfrePH-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250201/202502011801.rWqfrePH-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502011801.rWqfrePH-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/mfd/rohm-bd79124.c:114:29: warning: variable 'ret' is uninitialized when used here [-Wuninitialized]
     114 |                 return dev_err_probe(dev, ret, "Failed to get the Vdd\n");
         |                                           ^~~
   drivers/mfd/rohm-bd79124.c:97:9: note: initialize the variable 'ret' to silence this warning
      97 |         int ret;
         |                ^
         |                 = 0
   1 warning generated.


vim +/ret +114 drivers/mfd/rohm-bd79124.c

    94	
    95	static int bd79124_probe(struct i2c_client *i2c)
    96	{
    97		int ret;
    98		struct regmap *map;
    99		struct device *dev = &i2c->dev;
   100		int *adc_vref;
   101	
   102		adc_vref = devm_kzalloc(dev, sizeof(*adc_vref), GFP_KERNEL);
   103		if (!adc_vref)
   104			return -ENOMEM;
   105	
   106		/*
   107		 * Better to enable regulators here so we don't need to worry about the
   108		 * order of sub-device instantiation. We also need to deliver the
   109		 * reference voltage value to the ADC driver. This is done via
   110		 * the MFD driver's drvdata.
   111		 */
   112		*adc_vref = devm_regulator_get_enable_read_voltage(dev, "vdd");
   113		if (*adc_vref < 0)
 > 114			return dev_err_probe(dev, ret, "Failed to get the Vdd\n");
   115	
   116		dev_set_drvdata(dev, adc_vref);
   117	
   118		ret = devm_regulator_get_enable(dev, "iovdd");
   119		if (ret < 0)
   120			return dev_err_probe(dev, ret, "Failed to enable I/O voltage\n");
   121	
   122		map = devm_regmap_init_i2c(i2c, &bd79124_regmap);
   123		if (IS_ERR(map))
   124			return dev_err_probe(dev, PTR_ERR(map),
   125					     "Failed to initialize Regmap\n");
   126	
   127		if (i2c->irq) {
   128			adc_alert = DEFINE_RES_IRQ_NAMED(i2c->irq, "thresh-alert");
   129			bd79124_cells[CELL_ADC].resources = &adc_alert;
   130			bd79124_cells[CELL_ADC].num_resources = 1;
   131		}
   132	
   133		ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_AUTO, bd79124_cells,
   134					   ARRAY_SIZE(bd79124_cells), NULL, 0, NULL);
   135		if (ret)
   136			dev_err_probe(dev, ret, "Failed to create subdevices\n");
   137	
   138		return ret;
   139	}
   140	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki