[koverstreet-bcachefs:bcachefs-testing 79/81] fs/bcachefs/alloc_background.c:2199:13: warning: stack frame size (1048) exceeds limit (1024) in 'bch2_do_invalidates_work'

[koverstreet-bcachefs:bcachefs-testing 79/81] fs/bcachefs/alloc_background.c:2199:13: warning: stack frame size (1048) exceeds limit (1024) in 'bch2_do_invalidates_work'

[kernel test robot]

tree:   https://github.com/koverstreet/bcachefs bcachefs-testing
head:   48a8a8bcdc41b32b39f53a42f72ed2ddde60baaa
commit: ac96afa3e911b7bc8b8c2c5648076542db97d4f8 [79/81] bcachefs: Invalidate cached data by backpointers
config: hexagon-allyesconfig (https://download.01.org/0day-ci/archive/20250208/202502082057.iwBVivQN-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250208/202502082057.iwBVivQN-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502082057.iwBVivQN-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> fs/bcachefs/alloc_background.c:2199:13: warning: stack frame size (1048) exceeds limit (1024) in 'bch2_do_invalidates_work' [-Wframe-larger-than]
    2199 | static void bch2_do_invalidates_work(struct work_struct *work)
         |             ^
   1 warning generated.


vim +/bch2_do_invalidates_work +2199 fs/bcachefs/alloc_background.c

2e9940d4a19507 Kent Overstreet 2024-06-17  2198  
caece7fe3f1199 Kent Overstreet 2022-02-10 @2199  static void bch2_do_invalidates_work(struct work_struct *work)
caece7fe3f1199 Kent Overstreet 2022-02-10  2200  {
64ee1431cc7d11 Kent Overstreet 2024-06-23  2201  	struct bch_dev *ca = container_of(work, struct bch_dev, invalidate_work);
64ee1431cc7d11 Kent Overstreet 2024-06-23  2202  	struct bch_fs *c = ca->fs;
6bd68ec266ad71 Kent Overstreet 2023-09-12  2203  	struct btree_trans *trans = bch2_trans_get(c);
caece7fe3f1199 Kent Overstreet 2022-02-10  2204  	int ret = 0;
caece7fe3f1199 Kent Overstreet 2022-02-10  2205  
ac96afa3e911b7 Kent Overstreet 2025-02-07  2206  	struct bkey_buf last_flushed;
ac96afa3e911b7 Kent Overstreet 2025-02-07  2207  	bch2_bkey_buf_init(&last_flushed);
ac96afa3e911b7 Kent Overstreet 2025-02-07  2208  	bkey_init(&last_flushed.k->k);
ac96afa3e911b7 Kent Overstreet 2025-02-07  2209  
cb13f471390ce6 Kent Overstreet 2023-11-02  2210  	ret = bch2_btree_write_buffer_tryflush(trans);
1b30ed5fd87828 Kent Overstreet 2023-02-06  2211  	if (ret)
1b30ed5fd87828 Kent Overstreet 2023-02-06  2212  		goto err;
1b30ed5fd87828 Kent Overstreet 2023-02-06  2213  
822835ffeae411 Kent Overstreet 2022-04-01  2214  	s64 nr_to_invalidate =
822835ffeae411 Kent Overstreet 2022-04-01  2215  		should_invalidate_buckets(ca, bch2_dev_usage_read(ca));
2e9940d4a19507 Kent Overstreet 2024-06-17  2216  	struct btree_iter iter;
2e9940d4a19507 Kent Overstreet 2024-06-17  2217  	bool wrapped = false;
2e9940d4a19507 Kent Overstreet 2024-06-17  2218  
2e9940d4a19507 Kent Overstreet 2024-06-17  2219  	bch2_trans_iter_init(trans, &iter, BTREE_ID_lru,
2e9940d4a19507 Kent Overstreet 2024-06-17  2220  			     lru_pos(ca->dev_idx, 0,
2e9940d4a19507 Kent Overstreet 2024-06-17  2221  				     ((bch2_current_io_time(c, READ) + U32_MAX) &
2e9940d4a19507 Kent Overstreet 2024-06-17  2222  				      LRU_TIME_MAX)), 0);
2e9940d4a19507 Kent Overstreet 2024-06-17  2223  
2e9940d4a19507 Kent Overstreet 2024-06-17  2224  	while (true) {
2e9940d4a19507 Kent Overstreet 2024-06-17  2225  		bch2_trans_begin(trans);
822835ffeae411 Kent Overstreet 2022-04-01  2226  
2e9940d4a19507 Kent Overstreet 2024-06-17  2227  		struct bkey_s_c k = next_lru_key(trans, &iter, ca, &wrapped);
2e9940d4a19507 Kent Overstreet 2024-06-17  2228  		ret = bkey_err(k);
2e9940d4a19507 Kent Overstreet 2024-06-17  2229  		if (ret)
7ee4be9c621e4c Kent Overstreet 2024-10-15  2230  			goto restart_err;
2e9940d4a19507 Kent Overstreet 2024-06-17  2231  		if (!k.k)
2e9940d4a19507 Kent Overstreet 2024-06-17  2232  			break;
2e9940d4a19507 Kent Overstreet 2024-06-17  2233  
ac96afa3e911b7 Kent Overstreet 2025-02-07  2234  		ret = invalidate_one_bucket(trans, ca, &iter, k, &last_flushed, &nr_to_invalidate);
7ee4be9c621e4c Kent Overstreet 2024-10-15  2235  restart_err:
7ee4be9c621e4c Kent Overstreet 2024-10-15  2236  		if (bch2_err_matches(ret, BCH_ERR_transaction_restart))
7ee4be9c621e4c Kent Overstreet 2024-10-15  2237  			continue;
2e9940d4a19507 Kent Overstreet 2024-06-17  2238  		if (ret)
2e9940d4a19507 Kent Overstreet 2024-06-17  2239  			break;
2e9940d4a19507 Kent Overstreet 2024-06-17  2240  
2e9940d4a19507 Kent Overstreet 2024-06-17  2241  		bch2_btree_iter_advance(&iter);
2e9940d4a19507 Kent Overstreet 2024-06-17  2242  	}
2e9940d4a19507 Kent Overstreet 2024-06-17  2243  	bch2_trans_iter_exit(trans, &iter);
1b30ed5fd87828 Kent Overstreet 2023-02-06  2244  err:
6bd68ec266ad71 Kent Overstreet 2023-09-12  2245  	bch2_trans_put(trans);
64ee1431cc7d11 Kent Overstreet 2024-06-23  2246  	percpu_ref_put(&ca->io_ref);
ac96afa3e911b7 Kent Overstreet 2025-02-07  2247  	bch2_bkey_buf_exit(&last_flushed, c);
5a6e43af1e5341 Kent Overstreet 2024-09-04  2248  	bch2_write_ref_put(c, BCH_WRITE_REF_invalidate);
caece7fe3f1199 Kent Overstreet 2022-02-10  2249  }
caece7fe3f1199 Kent Overstreet 2022-02-10  2250  

:::::: The code at line 2199 was first introduced by commit
:::::: caece7fe3f1199f0da42b4537434166f99f0c11f bcachefs: New bucket invalidate path

:::::: TO: Kent Overstreet <kent.overstreet@gmail.com>
:::::: CC: Kent Overstreet <kent.overstreet@linux.dev>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki