Re: [RFC PATCH 6/6] debugfs: Replace debugfs_node #define with struct wrapping dentry

Re: [RFC PATCH 6/6] debugfs: Replace debugfs_node #define with struct wrapping dentry

[kernel test robot]

Hi David,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on a64dcfb451e254085a7daee5fe51bf22959d52d3]

url:    https://github.com/intel-lab-lkp/linux/commits/David-Reaver/debugfs-Add-temporary-define-debugfs_node-dentry-directives/20250210-132642
base:   a64dcfb451e254085a7daee5fe51bf22959d52d3
patch link:    https://lore.kernel.org/r/20250210052039.144513-7-me%40davidreaver.com
patch subject: [RFC PATCH 6/6] debugfs: Replace debugfs_node #define with struct wrapping dentry
config: arm64-randconfig-003-20250210 (https://download.01.org/0day-ci/archive/20250210/202502102301.7D1vpwVw-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project 6807164500e9920638e2ab0cdb4bf8321d24f8eb)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250210/202502102301.7D1vpwVw-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502102301.7D1vpwVw-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/imagination/pvr_debugfs.c:21:17: error: incompatible function pointer types initializing 'void (*)(struct pvr_device *, struct dentry *)' with an expression of type 'void (struct pvr_device *, struct debugfs_node *)' [-Wincompatible-function-pointer-types]
      21 |         {"pvr_params", pvr_params_debugfs_init},
         |                        ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/imagination/pvr_debugfs.c:22:13: error: incompatible function pointer types initializing 'void (*)(struct pvr_device *, struct dentry *)' with an expression of type 'void (struct pvr_device *, struct debugfs_node *)' [-Wincompatible-function-pointer-types]
      22 |         {"pvr_fw", pvr_fw_trace_debugfs_init},
         |                    ^~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/imagination/pvr_debugfs.c:45:24: error: incompatible pointer types passing 'struct debugfs_node *' to parameter of type 'struct dentry *' [-Werror,-Wincompatible-pointer-types]
      45 |                 entry->init(pvr_dev, dir);
         |                                      ^~~
   3 errors generated.


vim +21 drivers/gpu/drm/imagination/pvr_debugfs.c

cb56cd61086645 Sarah Walker 2023-11-22  19  
cb56cd61086645 Sarah Walker 2023-11-22  20  static const struct pvr_debugfs_entry pvr_debugfs_entries[] = {
cb56cd61086645 Sarah Walker 2023-11-22 @21  	{"pvr_params", pvr_params_debugfs_init},
cb56cd61086645 Sarah Walker 2023-11-22  22  	{"pvr_fw", pvr_fw_trace_debugfs_init},
cb56cd61086645 Sarah Walker 2023-11-22  23  };
cb56cd61086645 Sarah Walker 2023-11-22  24  
cb56cd61086645 Sarah Walker 2023-11-22  25  void
cb56cd61086645 Sarah Walker 2023-11-22  26  pvr_debugfs_init(struct drm_minor *minor)
cb56cd61086645 Sarah Walker 2023-11-22  27  {
cb56cd61086645 Sarah Walker 2023-11-22  28  	struct drm_device *drm_dev = minor->dev;
cb56cd61086645 Sarah Walker 2023-11-22  29  	struct pvr_device *pvr_dev = to_pvr_device(drm_dev);
ff2c46c29b70e2 David Reaver 2025-02-09  30  	struct debugfs_node *root = minor->debugfs_root;
cb56cd61086645 Sarah Walker 2023-11-22  31  	size_t i;
cb56cd61086645 Sarah Walker 2023-11-22  32  
cb56cd61086645 Sarah Walker 2023-11-22  33  	for (i = 0; i < ARRAY_SIZE(pvr_debugfs_entries); ++i) {
cb56cd61086645 Sarah Walker 2023-11-22  34  		const struct pvr_debugfs_entry *entry = &pvr_debugfs_entries[i];
ff2c46c29b70e2 David Reaver 2025-02-09  35  		struct debugfs_node *dir;
cb56cd61086645 Sarah Walker 2023-11-22  36  
cb56cd61086645 Sarah Walker 2023-11-22  37  		dir = debugfs_create_dir(entry->name, root);
cb56cd61086645 Sarah Walker 2023-11-22  38  		if (IS_ERR(dir)) {
cb56cd61086645 Sarah Walker 2023-11-22  39  			drm_warn(drm_dev,
cb56cd61086645 Sarah Walker 2023-11-22  40  				 "failed to create debugfs dir '%s' (err=%d)",
cb56cd61086645 Sarah Walker 2023-11-22  41  				 entry->name, (int)PTR_ERR(dir));
cb56cd61086645 Sarah Walker 2023-11-22  42  			continue;
cb56cd61086645 Sarah Walker 2023-11-22  43  		}
cb56cd61086645 Sarah Walker 2023-11-22  44  
cb56cd61086645 Sarah Walker 2023-11-22 @45  		entry->init(pvr_dev, dir);
cb56cd61086645 Sarah Walker 2023-11-22  46  	}
cb56cd61086645 Sarah Walker 2023-11-22  47  }
cb56cd61086645 Sarah Walker 2023-11-22  48  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki