Re: [PATCH 3/4] ACPI/MRRM: Add "node" symlink to /sys/devices/system/memory/rangeX

Re: [PATCH 3/4] ACPI/MRRM: Add "node" symlink to /sys/devices/system/memory/rangeX

[kernel test robot]

Hi Tony,

kernel test robot noticed the following build errors:

[auto build test ERROR on a64dcfb451e254085a7daee5fe51bf22959d52d3]

url:    https://github.com/intel-lab-lkp/linux/commits/Tony-Luck/ACPICA-Define-MRRM-ACPI-table/20250211-051427
base:   a64dcfb451e254085a7daee5fe51bf22959d52d3
patch link:    https://lore.kernel.org/r/20250210211223.6139-4-tony.luck%40intel.com
patch subject: [PATCH 3/4] ACPI/MRRM: Add "node" symlink to /sys/devices/system/memory/rangeX
config: x86_64-randconfig-003-20250211 (https://download.01.org/0day-ci/archive/20250211/202502111945.ZftqkQvL-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250211/202502111945.ZftqkQvL-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502111945.ZftqkQvL-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/acpi/acpi_mrrm.c:135:31: error: no member named 'node' in 'struct zone'
     135 |                                 node = node_devices[zone->node];
         |                                                     ~~~~  ^
   1 error generated.


vim +135 drivers/acpi/acpi_mrrm.c

   121	
   122	static __init int add_node_link(struct mrrm_mem_range_entry *entry)
   123	{
   124		struct node *node = NULL;
   125		int ret = 0;
   126		int nid;
   127	
   128		for_each_online_node(nid) {
   129			for (int z = 0; z < MAX_NR_ZONES; z++) {
   130				struct zone *zone = NODE_DATA(nid)->node_zones + z;
   131	
   132				if (!populated_zone(zone))
   133					continue;
   134				if (zone_intersects(zone, PHYS_PFN(entry->base), PHYS_PFN(entry->length))) {
 > 135					node = node_devices[zone->node];
   136					goto found;
   137				}
   138			}
   139		}
   140	found:
   141		if (node)
   142			ret = sysfs_create_link(&entry->dev.kobj, &node->dev.kobj, "node");
   143	
   144		return ret;
   145	}
   146	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki