Re: [PATCHv2 6/6] io_uring: cache nodes and mapped buffers

Re: [PATCHv2 6/6] io_uring: cache nodes and mapped buffers

[kernel test robot]

Hi Keith,

kernel test robot noticed the following build errors:

[auto build test ERROR on axboe-block/for-next]
[also build test ERROR on linus/master v6.14-rc2 next-20250210]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Keith-Busch/io_uring-use-node-for-import/20250211-091231
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
patch link:    https://lore.kernel.org/r/20250211005646.222452-7-kbusch%40meta.com
patch subject: [PATCHv2 6/6] io_uring: cache nodes and mapped buffers
config: hexagon-randconfig-001-20250212 (https://download.01.org/0day-ci/archive/20250212/202502120932.uu9ibLvc-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project 6807164500e9920638e2ab0cdb4bf8321d24f8eb)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250212/202502120932.uu9ibLvc-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502120932.uu9ibLvc-lkp@intel.com/

All errors (new ones prefixed by >>):

>> io_uring/rsrc.c:180:2: error: call to '__compiletime_assert_443' declared with 'error' attribute: BUILD_BUG_ON failed: imu_cache_size != 512
     180 |         BUILD_BUG_ON(imu_cache_size != 512);
         |         ^
   include/linux/build_bug.h:50:2: note: expanded from macro 'BUILD_BUG_ON'
      50 |         BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition)
         |         ^
   include/linux/build_bug.h:39:37: note: expanded from macro 'BUILD_BUG_ON_MSG'
      39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
         |                                     ^
   include/linux/compiler_types.h:542:2: note: expanded from macro 'compiletime_assert'
     542 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
         |         ^
   include/linux/compiler_types.h:530:2: note: expanded from macro '_compiletime_assert'
     530 |         __compiletime_assert(condition, msg, prefix, suffix)
         |         ^
   include/linux/compiler_types.h:523:4: note: expanded from macro '__compiletime_assert'
     523 |                         prefix ## suffix();                             \
         |                         ^
   <scratch space>:193:1: note: expanded from here
     193 | __compiletime_assert_443
         | ^
>> io_uring/rsrc.c:180:2: error: call to '__compiletime_assert_443' declared with 'error' attribute: BUILD_BUG_ON failed: imu_cache_size != 512
   include/linux/build_bug.h:50:2: note: expanded from macro 'BUILD_BUG_ON'
      50 |         BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition)
         |         ^
   include/linux/build_bug.h:39:37: note: expanded from macro 'BUILD_BUG_ON_MSG'
      39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
         |                                     ^
   include/linux/compiler_types.h:542:2: note: expanded from macro 'compiletime_assert'
     542 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
         |         ^
   include/linux/compiler_types.h:530:2: note: expanded from macro '_compiletime_assert'
     530 |         __compiletime_assert(condition, msg, prefix, suffix)
         |         ^
   include/linux/compiler_types.h:523:4: note: expanded from macro '__compiletime_assert'
     523 |                         prefix ## suffix();                             \
         |                         ^
   <scratch space>:193:1: note: expanded from here
     193 | __compiletime_assert_443
         | ^
   2 errors generated.


vim +180 io_uring/rsrc.c

   173	
   174	static __cold int io_rsrc_buffer_alloc(struct io_buf_table *table, unsigned nr)
   175	{
   176		const int imu_cache_size = struct_size_t(struct io_mapped_ubuf, bvec,
   177							 IO_CACHED_BVECS_SEGS);
   178		int ret;
   179	
 > 180		BUILD_BUG_ON(imu_cache_size != 512);
   181		ret = io_rsrc_data_alloc(&table->data, nr);
   182		if (ret)
   183			return ret;
   184	
   185		ret = io_alloc_cache_init(&table->node_cache, nr,
   186					  sizeof(struct io_rsrc_node), 0);
   187		if (ret)
   188			goto out_1;
   189	
   190		ret = io_alloc_cache_init(&table->imu_cache, nr, imu_cache_size, 0);
   191		if (ret)
   192			goto out_2;
   193	
   194		return 0;
   195	out_2:
   196		io_alloc_cache_free(&table->node_cache, kfree);
   197	out_1:
   198		__io_rsrc_data_free(&table->data);
   199		return ret;
   200	}
   201	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki