* [litex-hub:litex-rebase 10/15] drivers/mtd/spi-nor/litex-spiflash.c:305:15: error: incompatible function pointer types initializing 'int (*)(struct spi_nor *, u8, const u8 *, size_t)' (aka 'int (*)(struct spi_nor *, unsigned char, const unsigned char *, unsigned long)') with an express...
@ 2025-02-01 10:06 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2025-02-01 10:06 UTC (permalink / raw)
To: Daniel Craviee; +Cc: llvm, oe-kbuild-all, Gabriel Somlo, Geert Uytterhoeven
tree: https://github.com/litex-hub/linux litex-rebase
head: d063b9bfd84d4ae32eaa664cd7b8906d1e5a4265
commit: 3d002d5d735d84642819be0fbf1ae715f4b1aac4 [10/15] LiteX: driver for SPI Flash (mtd) device
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20250201/202502011735.bkOUcCe6-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250201/202502011735.bkOUcCe6-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502011735.bkOUcCe6-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from drivers/mtd/spi-nor/litex-spiflash.c:23:
In file included from include/linux/module.h:19:
In file included from include/linux/elf.h:6:
In file included from arch/s390/include/asm/elf.h:181:
In file included from arch/s390/include/asm/mmu_context.h:11:
In file included from arch/s390/include/asm/pgalloc.h:18:
In file included from include/linux/mm.h:2224:
include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
504 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
505 | item];
| ~~~~
include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
511 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
512 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
524 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
525 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
>> drivers/mtd/spi-nor/litex-spiflash.c:305:15: error: incompatible function pointer types initializing 'int (*)(struct spi_nor *, u8, const u8 *, size_t)' (aka 'int (*)(struct spi_nor *, unsigned char, const unsigned char *, unsigned long)') with an expression of type 'ssize_t (struct spi_nor *, u8, const u8 *, size_t)' (aka 'long (struct spi_nor *, unsigned char, const unsigned char *, unsigned long)') [-Wincompatible-function-pointer-types]
305 | .write_reg = spi_flash_nor_write_reg,
| ^~~~~~~~~~~~~~~~~~~~~~~
3 warnings and 1 error generated.
vim +305 drivers/mtd/spi-nor/litex-spiflash.c
300
301 static const struct spi_nor_controller_ops litex_spi_controller_ops = {
302 .read = spi_flash_nor_read,
303 .write = spi_flash_nor_write,
304 .read_reg = spi_flash_nor_read_reg,
> 305 .write_reg = spi_flash_nor_write_reg,
306 .erase = spi_flash_nor_erase,
307 };
308
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
* [litex-hub:litex-rebase 10/15] drivers/mtd/spi-nor/litex-spiflash.c:305:15: error: incompatible function pointer types initializing 'int (*)(struct spi_nor *, u8, const u8 *, size_t)' (aka 'int (*)(struct spi_nor *, unsigned char, const unsigned char *, unsigned long)') with an express...
@ 2025-02-16 23:11 kernel test robot
2025-02-17 15:54 ` Gabriel L. Somlo
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2025-02-16 23:11 UTC (permalink / raw)
To: Daniel Craviee; +Cc: llvm, oe-kbuild-all, Gabriel Somlo, Geert Uytterhoeven
tree: https://github.com/litex-hub/linux litex-rebase
head: bfdc7246bec114e599ddb68ba442ce88172537ed
commit: 7cbcc8cd508400e5b564e23a122126a13096c2f7 [10/15] LiteX: driver for SPI Flash (mtd) device
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20250217/202502170711.tNK4CFp1-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250217/202502170711.tNK4CFp1-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502170711.tNK4CFp1-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from drivers/mtd/spi-nor/litex-spiflash.c:23:
In file included from include/linux/module.h:19:
In file included from include/linux/elf.h:6:
In file included from arch/s390/include/asm/elf.h:181:
In file included from arch/s390/include/asm/mmu_context.h:11:
In file included from arch/s390/include/asm/pgalloc.h:18:
In file included from include/linux/mm.h:2224:
include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
504 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
505 | item];
| ~~~~
include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
511 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
512 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
524 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
525 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
>> drivers/mtd/spi-nor/litex-spiflash.c:305:15: error: incompatible function pointer types initializing 'int (*)(struct spi_nor *, u8, const u8 *, size_t)' (aka 'int (*)(struct spi_nor *, unsigned char, const unsigned char *, unsigned long)') with an expression of type 'ssize_t (struct spi_nor *, u8, const u8 *, size_t)' (aka 'long (struct spi_nor *, unsigned char, const unsigned char *, unsigned long)') [-Wincompatible-function-pointer-types]
305 | .write_reg = spi_flash_nor_write_reg,
| ^~~~~~~~~~~~~~~~~~~~~~~
3 warnings and 1 error generated.
vim +305 drivers/mtd/spi-nor/litex-spiflash.c
300
301 static const struct spi_nor_controller_ops litex_spi_controller_ops = {
302 .read = spi_flash_nor_read,
303 .write = spi_flash_nor_write,
304 .read_reg = spi_flash_nor_read_reg,
> 305 .write_reg = spi_flash_nor_write_reg,
306 .erase = spi_flash_nor_erase,
307 };
308
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [litex-hub:litex-rebase 10/15] drivers/mtd/spi-nor/litex-spiflash.c:305:15: error: incompatible function pointer types initializing 'int (*)(struct spi_nor *, u8, const u8 *, size_t)' (aka 'int (*)(struct spi_nor *, unsigned char, const unsigned char *, unsigned long)') with an express...
2025-02-16 23:11 [litex-hub:litex-rebase 10/15] drivers/mtd/spi-nor/litex-spiflash.c:305:15: error: incompatible function pointer types initializing 'int (*)(struct spi_nor *, u8, const u8 *, size_t)' (aka 'int (*)(struct spi_nor *, unsigned char, const unsigned char *, unsigned long)') with an express kernel test robot
@ 2025-02-17 15:54 ` Gabriel L. Somlo
0 siblings, 0 replies; 3+ messages in thread
From: Gabriel L. Somlo @ 2025-02-17 15:54 UTC (permalink / raw)
To: kernel test robot; +Cc: Daniel Craviee, llvm, oe-kbuild-all, Geert Uytterhoeven
Thanks for the heads-up!
On Mon, Feb 17, 2025 at 07:11:56AM +0800, kernel test robot wrote:
> tree: https://github.com/litex-hub/linux litex-rebase
> head: bfdc7246bec114e599ddb68ba442ce88172537ed
> commit: 7cbcc8cd508400e5b564e23a122126a13096c2f7 [10/15] LiteX: driver for SPI Flash (mtd) device
> config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20250217/202502170711.tNK4CFp1-lkp@intel.com/config)
> compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250217/202502170711.tNK4CFp1-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202502170711.tNK4CFp1-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
> In file included from drivers/mtd/spi-nor/litex-spiflash.c:23:
> In file included from include/linux/module.h:19:
> In file included from include/linux/elf.h:6:
> In file included from arch/s390/include/asm/elf.h:181:
> In file included from arch/s390/include/asm/mmu_context.h:11:
> In file included from arch/s390/include/asm/pgalloc.h:18:
> In file included from include/linux/mm.h:2224:
> include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
> 504 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
> | ~~~~~~~~~~~~~~~~~~~~~ ^
> 505 | item];
> | ~~~~
> include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
> 511 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
> | ~~~~~~~~~~~~~~~~~~~~~ ^
> 512 | NR_VM_NUMA_EVENT_ITEMS +
> | ~~~~~~~~~~~~~~~~~~~~~~
> include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
> 524 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
> | ~~~~~~~~~~~~~~~~~~~~~ ^
> 525 | NR_VM_NUMA_EVENT_ITEMS +
> | ~~~~~~~~~~~~~~~~~~~~~~
> >> drivers/mtd/spi-nor/litex-spiflash.c:305:15: error: incompatible function pointer types initializing 'int (*)(struct spi_nor *, u8, const u8 *, size_t)' (aka 'int (*)(struct spi_nor *, unsigned char, const unsigned char *, unsigned long)') with an expression of type 'ssize_t (struct spi_nor *, u8, const u8 *, size_t)' (aka 'long (struct spi_nor *, unsigned char, const unsigned char *, unsigned long)') [-Wincompatible-function-pointer-types]
> 305 | .write_reg = spi_flash_nor_write_reg,
> | ^~~~~~~~~~~~~~~~~~~~~~~
> 3 warnings and 1 error generated.
>
>
> vim +305 drivers/mtd/spi-nor/litex-spiflash.c
>
> 300
> 301 static const struct spi_nor_controller_ops litex_spi_controller_ops = {
> 302 .read = spi_flash_nor_read,
> 303 .write = spi_flash_nor_write,
> 304 .read_reg = spi_flash_nor_read_reg,
> > 305 .write_reg = spi_flash_nor_write_reg,
> 306 .erase = spi_flash_nor_erase,
> 307 };
> 308
Fixed by s/ssize_t/int/ in the definition of spi_flash_nor_write_reg():
-static ssize_t spi_flash_nor_write_reg(struct spi_nor *nor, u8 opcode,
+static int spi_flash_nor_write_reg(struct spi_nor *nor, u8 opcode,
I will squash that change on top of the existing driver in a few days.
Thanks,
--Gabriel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-17 15:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-16 23:11 [litex-hub:litex-rebase 10/15] drivers/mtd/spi-nor/litex-spiflash.c:305:15: error: incompatible function pointer types initializing 'int (*)(struct spi_nor *, u8, const u8 *, size_t)' (aka 'int (*)(struct spi_nor *, unsigned char, const unsigned char *, unsigned long)') with an express kernel test robot
2025-02-17 15:54 ` Gabriel L. Somlo
-- strict thread matches above, loose matches on Subject: below --
2025-02-01 10:06 kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox