[PATCH] sound:firewire:fixed spelling error

[PATCH] sound:firewire:fixed spelling error

[jack Livingood]

fixed a spelling error.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202502191455.cX0HILg0-lkp@intel.com/
Signed-off-by: Jack Livingood <jacklivingood@comcast.net>
---
 sound/firewire/isight.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/firewire/isight.c b/sound/firewire/isight.c
index e9617fc0a532..bf1e3f293c75 100644
--- a/sound/firewire/isight.c
+++ b/sound/firewire/isight.c
@@ -643,7 +643,7 @@ static int isight_probe(struct fw_unit *unit,
 		 "Apple iSight (GUID %08x%08x) at %s, S%d",
 		 fw_dev->config_rom[3], fw_dev->config_rom[4],
 		 dev_name(&unit->device), 100 << fw_dev->max_speed);
-	strspy(card->mixername, "iSight");
+	strscpy(card->mixername, "iSight");
 
 	err = isight_create_pcm(isight);
 	if (err < 0)
-- 
2.48.1

Re: [PATCH] sound:firewire:fixed spelling error

[Takashi Sakamoto]

Hi,

On Wed, Feb 19, 2025 at 09:28:17AM -0800, jack Livingood wrote:
> fixed a spelling error.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202502191455.cX0HILg0-lkp@intel.com/
> Signed-off-by: Jack Livingood <jacklivingood@comcast.net>
> ---
>  sound/firewire/isight.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

The issued patch does not exist in linux-next branch of sound.git[1]. The
report to which you address is for Sound Open Firmware project[2].

I think it better to re-post the revised-version of patch to replace the
usage of 'strcpy()' with 'strscpy()'[3].


[1] I guess that the maintainer realized the build error when applying
the patch after my review.
[2] https://lore.kernel.org/oe-kbuild-all/202502220137.fyFohYSo-lkp@intel.com/
[3] https://lore.kernel.org/linux-sound/20250205192258.358362-1-jacklivingood@comcast.net/

Thanks

Takashi Sakamoto