* [linux-next:master 6161/6583] sound/soc/mediatek/mt8188/mt8188-dai-dmic.c:311:4: warning: variable 'msk' is uninitialized when used here
@ 2025-02-26 10:39 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2025-02-26 10:39 UTC (permalink / raw)
To: parkeryang
Cc: llvm, oe-kbuild-all, Mark Brown, Nícolas F. R. A. Prado,
AngeloGioacchino Del Regno
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 8433c776e1eb1371f5cd40b5fd3a61f9c7b7f3ad
commit: c1e42ec04197ac013d049dde40d9c72cf543b5f6 [6161/6583] ASoC: mediatek: mt8188: Add support for DMIC
config: hexagon-allyesconfig (https://download.01.org/0day-ci/archive/20250226/202502261854.7caMptGv-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250226/202502261854.7caMptGv-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502261854.7caMptGv-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> sound/soc/mediatek/mt8188/mt8188-dai-dmic.c:311:4: warning: variable 'msk' is uninitialized when used here [-Wuninitialized]
311 | msk |= PWR2_TOP_CON1_DMIC_FIFO_SOFT_RST_EN(i);
| ^~~
sound/soc/mediatek/mt8188/mt8188-dai-dmic.c:295:18: note: initialize the variable 'msk' to silence this warning
295 | unsigned int msk;
| ^
| = 0
1 warning generated.
vim +/msk +311 sound/soc/mediatek/mt8188/mt8188-dai-dmic.c
284
285 static int mtk_dmic_event(struct snd_soc_dapm_widget *w,
286 struct snd_kcontrol *kcontrol,
287 int event)
288 {
289 struct snd_soc_component *cmpnt = snd_soc_dapm_to_component(w->dapm);
290 struct mtk_base_afe *afe = snd_soc_component_get_drvdata(cmpnt);
291 struct mt8188_afe_private *afe_priv = afe->platform_priv;
292 struct mtk_dai_dmic_priv *dmic_priv = afe_priv->dai_priv[MT8188_AFE_IO_DMIC_IN];
293 const struct mtk_dai_dmic_ctrl_reg *reg = NULL;
294 unsigned int channels = dmic_priv->channels;
295 unsigned int msk;
296 u8 dmic_num;
297 int i;
298
299 dev_dbg(afe->dev, "%s(), name %s, event 0x%x\n",
300 __func__, w->name, event);
301
302 if (!channels)
303 return -EINVAL;
304
305 dmic_num = mtk_dmic_channels_to_dmic_number(channels);
306
307 switch (event) {
308 case SND_SOC_DAPM_PRE_PMU:
309 /* request fifo soft rst */
310 for (i = dmic_num; i >= DMIC0; i--)
> 311 msk |= PWR2_TOP_CON1_DMIC_FIFO_SOFT_RST_EN(i);
312
313 regmap_set_bits(afe->regmap, PWR2_TOP_CON1, msk);
314
315 msk = AFE_DMIC_UL_SRC_CON0_UL_MODE_3P25M_CH1_CTL |
316 AFE_DMIC_UL_SRC_CON0_UL_MODE_3P25M_CH2_CTL |
317 AFE_DMIC_UL_SRC_CON0_UL_SDM_3_LEVEL_CTL |
318 AFE_DMIC_UL_SRC_CON0_UL_IIR_ON_TMP_CTL;
319
320 for (i = dmic_num; i >= DMIC0; i--) {
321 reg = get_dmic_ctrl_reg(i);
322 if (reg)
323 regmap_set_bits(afe->regmap, reg->con0, msk);
324 }
325 break;
326 case SND_SOC_DAPM_POST_PMU:
327 msk = AFE_DMIC_UL_SRC_CON0_UL_SRC_ON_TMP_CTL;
328
329 for (i = dmic_num; i >= DMIC0; i--) {
330 reg = get_dmic_ctrl_reg(i);
331 if (reg)
332 regmap_set_bits(afe->regmap, reg->con0, msk);
333 }
334
335 if (dmic_priv->hires_required) {
336 mt8188_afe_enable_clk(afe, afe_priv->clk[MT8188_CLK_AUD_DMIC_HIRES1]);
337 mt8188_afe_enable_clk(afe, afe_priv->clk[MT8188_CLK_AUD_DMIC_HIRES2]);
338 mt8188_afe_enable_clk(afe, afe_priv->clk[MT8188_CLK_AUD_DMIC_HIRES3]);
339 mt8188_afe_enable_clk(afe, afe_priv->clk[MT8188_CLK_AUD_DMIC_HIRES4]);
340 }
341
342 mt8188_afe_enable_clk(afe, afe_priv->clk[MT8188_CLK_AUD_AFE_DMIC1]);
343 mt8188_afe_enable_clk(afe, afe_priv->clk[MT8188_CLK_AUD_AFE_DMIC2]);
344 mt8188_afe_enable_clk(afe, afe_priv->clk[MT8188_CLK_AUD_AFE_DMIC3]);
345 mt8188_afe_enable_clk(afe, afe_priv->clk[MT8188_CLK_AUD_AFE_DMIC4]);
346
347 /* release fifo soft rst */
348 msk = 0;
349 for (i = dmic_num; i >= DMIC0; i--)
350 msk |= PWR2_TOP_CON1_DMIC_FIFO_SOFT_RST_EN(i);
351
352 regmap_clear_bits(afe->regmap, PWR2_TOP_CON1, msk);
353 break;
354 case SND_SOC_DAPM_PRE_PMD:
355 msk = AFE_DMIC_UL_SRC_CON0_UL_MODE_3P25M_CH1_CTL |
356 AFE_DMIC_UL_SRC_CON0_UL_MODE_3P25M_CH2_CTL |
357 AFE_DMIC_UL_SRC_CON0_UL_SRC_ON_TMP_CTL |
358 AFE_DMIC_UL_SRC_CON0_UL_IIR_ON_TMP_CTL |
359 AFE_DMIC_UL_SRC_CON0_UL_SDM_3_LEVEL_CTL;
360
361 for (i = dmic_num; i >= DMIC0; i--) {
362 reg = get_dmic_ctrl_reg(i);
363 if (reg)
364 regmap_set_bits(afe->regmap, reg->con0, msk);
365 }
366 break;
367 case SND_SOC_DAPM_POST_PMD:
368 /* should delayed 1/fs(smallest is 8k) = 125us before afe off */
369 usleep_range(125, 126);
370
371 mt8188_afe_disable_clk(afe, afe_priv->clk[MT8188_CLK_AUD_AFE_DMIC1]);
372 mt8188_afe_disable_clk(afe, afe_priv->clk[MT8188_CLK_AUD_AFE_DMIC2]);
373 mt8188_afe_disable_clk(afe, afe_priv->clk[MT8188_CLK_AUD_AFE_DMIC3]);
374 mt8188_afe_disable_clk(afe, afe_priv->clk[MT8188_CLK_AUD_AFE_DMIC4]);
375
376 if (dmic_priv->hires_required) {
377 mt8188_afe_disable_clk(afe, afe_priv->clk[MT8188_CLK_AUD_DMIC_HIRES1]);
378 mt8188_afe_disable_clk(afe, afe_priv->clk[MT8188_CLK_AUD_DMIC_HIRES2]);
379 mt8188_afe_disable_clk(afe, afe_priv->clk[MT8188_CLK_AUD_DMIC_HIRES3]);
380 mt8188_afe_disable_clk(afe, afe_priv->clk[MT8188_CLK_AUD_DMIC_HIRES4]);
381 }
382 break;
383 default:
384 break;
385 }
386
387 return 0;
388 }
389
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2025-02-26 10:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-26 10:39 [linux-next:master 6161/6583] sound/soc/mediatek/mt8188/mt8188-dai-dmic.c:311:4: warning: variable 'msk' is uninitialized when used here kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox