Re: [PATCH v2 6/9] phy: qcom: Add M31 based eUSB2 PHY driver

Re: [PATCH v2 6/9] phy: qcom: Add M31 based eUSB2 PHY driver

[kernel test robot]

Hi Melody,

kernel test robot noticed the following build errors:

[auto build test ERROR on 20d5c66e1810e6e8805ec0d01373afb2dba9f51a]

url:    https://github.com/intel-lab-lkp/linux/commits/Melody-Olvera/dt-bindings-phy-qcom-sc8280xp-qmp-usb43dp-phy-Add-SM8750-to-QMP-PHY/20250305-060056
base:   20d5c66e1810e6e8805ec0d01373afb2dba9f51a
patch link:    https://lore.kernel.org/r/20250304-sm8750_usb_master-v2-6-a698a2e68e06%40quicinc.com
patch subject: [PATCH v2 6/9] phy: qcom: Add M31 based eUSB2 PHY driver
config: hexagon-allyesconfig (https://download.01.org/0day-ci/archive/20250306/202503061951.9eCEo3hd-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250306/202503061951.9eCEo3hd-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503061951.9eCEo3hd-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/phy/qualcomm/phy-qcom-m31-eusb2.c:180:10: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     180 |                                      FIELD_PREP(FSEL, data->fsel));
         |                                      ^
   1 error generated.


vim +/FIELD_PREP +180 drivers/phy/qualcomm/phy-qcom-m31-eusb2.c

   147	
   148	static int m31eusb2_phy_init(struct phy *uphy)
   149	{
   150		struct m31eusb2_phy *phy = phy_get_drvdata(uphy);
   151		const struct m31_eusb2_priv_data *data = phy->data;
   152		int ret;
   153	
   154		ret = regulator_bulk_enable(ARRAY_SIZE(phy->vregs), phy->vregs);
   155		if (ret) {
   156			dev_err(&uphy->dev, "failed to enable regulator, %d\n", ret);
   157			return ret;
   158		}
   159	
   160		ret = phy_init(phy->repeater);
   161		if (ret) {
   162			dev_err(&uphy->dev, "repeater init failed. %d\n", ret);
   163			goto disable_vreg;
   164		}
   165	
   166		ret = clk_prepare_enable(phy->clk);
   167		if (ret) {
   168			dev_err(&uphy->dev, "failed to enable cfg ahb clock, %d\n", ret);
   169			goto disable_repeater;
   170		}
   171	
   172		/* Perform phy reset */
   173		reset_control_assert(phy->reset);
   174		udelay(5);
   175		reset_control_deassert(phy->reset);
   176	
   177		m31eusb2_phy_write_sequence(phy, data->setup_seq, data->setup_seq_nregs);
   178		msm_m31_eusb2_write_readback(phy->base,
   179					     USB_PHY_HS_PHY_CTRL_COMMON0, FSEL,
 > 180					     FIELD_PREP(FSEL, data->fsel));
   181		m31eusb2_phy_write_sequence(phy, data->override_seq, data->override_seq_nregs);
   182		m31eusb2_phy_write_sequence(phy, data->reset_seq, data->reset_seq_nregs);
   183	
   184		return 0;
   185	
   186	disable_repeater:
   187		phy_exit(phy->repeater);
   188	disable_vreg:
   189		regulator_bulk_disable(ARRAY_SIZE(phy->vregs), phy->vregs);
   190	
   191		return 0;
   192	}
   193	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki