Re: [PATCH net-next 1/2] net: phylink: add functions to block/unblock rx clock stop

Re: [PATCH net-next 1/2] net: phylink: add functions to block/unblock rx clock stop

[kernel test robot]

Hi Russell,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Russell-King-Oracle/net-phylink-add-functions-to-block-unblock-rx-clock-stop/20250306-060346
base:   net-next/main
patch link:    https://lore.kernel.org/r/E1tpt2t-005UNB-MC%40rmk-PC.armlinux.org.uk
patch subject: [PATCH net-next 1/2] net: phylink: add functions to block/unblock rx clock stop
config: arm-exynos_defconfig (https://download.01.org/0day-ci/archive/20250307/202503070329.D6SVd1ez-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project 14170b16028c087ca154878f5ed93d3089a965c6)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250307/202503070329.D6SVd1ez-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503070329.D6SVd1ez-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

>> drivers/net/phy/phylink.c:2613:40: error: expected ';' after expression
    2613 |             pl->config->eee_rx_clk_stop_enable)
         |                                               ^
         |                                               ;
>> drivers/net/phy/phylink.c:2613:40: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
   drivers/net/phy/phylink.c:2611:2: note: previous statement is here
    2611 |         if (pl->mac_rx_clk_stop_blocked++ == 0 &&
         |         ^
>> drivers/net/phy/phylink.c:2613:40: error: expected expression
    2613 |             pl->config->eee_rx_clk_stop_enable)
         |                                               ^
>> drivers/net/phy/phylink.c:2613:18: warning: expression result unused [-Wunused-value]
    2613 |             pl->config->eee_rx_clk_stop_enable)
         |             ~~~~~~~~~~  ^~~~~~~~~~~~~~~~~~~~~~
   2 warnings and 2 errors generated.


vim +2613 drivers/net/phy/phylink.c

  2595	
  2596	
  2597	void phylink_rx_clk_stop_block(struct phylink *pl)
  2598	{
  2599		ASSERT_RTNL();
  2600	
  2601		if (pl->mac_rx_clk_stop_blocked == U8_MAX) {
  2602			phylink_warn(pl, "%s called too many times - ignoring\n",
  2603				     __func__);
  2604			dump_stack();
  2605			return;
  2606		}
  2607	
  2608		/* Disable PHY receive clock stop if this is the first time this
  2609		 * function has been called and clock-stop was previously enabled.
  2610		 */
  2611		if (pl->mac_rx_clk_stop_blocked++ == 0 &&
  2612		    pl->mac_supports_eee_ops && pl->phydev)
> 2613		    pl->config->eee_rx_clk_stop_enable)
  2614			phy_eee_rx_clock_stop(pl->phydev, false);
  2615	}
  2616	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki