Re: [PATCH 3/4] nfsd: add some stub tracepoints around key vfs functions

Re: [PATCH 3/4] nfsd: add some stub tracepoints around key vfs functions

[kernel test robot]

Hi Jeff,

kernel test robot noticed the following build errors:

[auto build test ERROR on 7dc86d35a5f8a7ac24b53792c704b101e5041842]

url:    https://github.com/intel-lab-lkp/linux/commits/Jeff-Layton/nfsd-add-commit-start-done-tracepoints-around-nfsd_commit/20250306-204120
base:   7dc86d35a5f8a7ac24b53792c704b101e5041842
patch link:    https://lore.kernel.org/r/20250306-nfsd-tracepoints-v1-3-4405bf41b95f%40kernel.org
patch subject: [PATCH 3/4] nfsd: add some stub tracepoints around key vfs functions
config: arm-randconfig-003-20250307 (https://download.01.org/0day-ci/archive/20250307/202503071828.4eKhNhUb-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250307/202503071828.4eKhNhUb-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503071828.4eKhNhUb-lkp@intel.com/

All errors (new ones prefixed by >>):

>> fs/nfsd/nfsproc.c:57:2: error: call to undeclared function 'trace_nfsd_getattr'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
      57 |         trace_nfsd_getattr(rqstp, &argp->fh);
         |         ^
   1 error generated.


vim +/trace_nfsd_getattr +57 fs/nfsd/nfsproc.c

    46	
    47	/*
    48	 * Get a file's attributes
    49	 * N.B. After this call resp->fh needs an fh_put
    50	 */
    51	static __be32
    52	nfsd_proc_getattr(struct svc_rqst *rqstp)
    53	{
    54		struct nfsd_fhandle *argp = rqstp->rq_argp;
    55		struct nfsd_attrstat *resp = rqstp->rq_resp;
    56	
  > 57		trace_nfsd_getattr(rqstp, &argp->fh);
    58	
    59		dprintk("nfsd: GETATTR  %s\n", SVCFH_fmt(&argp->fh));
    60	
    61		fh_copy(&resp->fh, &argp->fh);
    62		resp->status = fh_verify(rqstp, &resp->fh, 0,
    63					 NFSD_MAY_NOP | NFSD_MAY_BYPASS_GSS_ON_ROOT);
    64		if (resp->status != nfs_ok)
    65			goto out;
    66		resp->status = fh_getattr(&resp->fh, &resp->stat);
    67	out:
    68		resp->status = nfsd_map_status(resp->status);
    69		return rpc_success;
    70	}
    71	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki