Re: [PATCH v6 15/26] landlock: Log scoped denials

Re: [PATCH v6 15/26] landlock: Log scoped denials

[kernel test robot]

Hi Mickaël,

kernel test robot noticed the following build errors:

[auto build test ERROR on 7eb172143d5508b4da468ed59ee857c6e5e01da6]

url:    https://github.com/intel-lab-lkp/linux/commits/Micka-l-Sala-n/lsm-Add-audit_log_lsm_data-helper/20250309-025251
base:   7eb172143d5508b4da468ed59ee857c6e5e01da6
patch link:    https://lore.kernel.org/r/20250308184422.2159360-16-mic%40digikod.net
patch subject: [PATCH v6 15/26] landlock: Log scoped denials
config: i386-buildonly-randconfig-006-20250309 (https://download.01.org/0day-ci/archive/20250309/202503091759.e9RGYFVV-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250309/202503091759.e9RGYFVV-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503091759.e9RGYFVV-lkp@intel.com/

All errors (new ones prefixed by >>):

>> security/landlock/fs.c:1816:24: error: no member named 'fown_layer' in 'struct landlock_file_security'
    1816 |                 landlock_file(file)->fown_layer = handle_layer;
         |                 ~~~~~~~~~~~~~~~~~~~  ^
   security/landlock/fs.c:1821:24: error: no member named 'fown_layer' in 'struct landlock_file_security'
    1821 |                 landlock_file(file)->fown_layer = 0;
         |                 ~~~~~~~~~~~~~~~~~~~  ^
   2 errors generated.
--
>> security/landlock/task.c:412:48: error: no member named 'fown_layer' in 'struct landlock_file_security'
     412 |                 .layer_plus_one = landlock_file(fown->file)->fown_layer + 1,
         |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~  ^
   1 error generated.


vim +1816 security/landlock/fs.c

  1792	
  1793	static void hook_file_set_fowner(struct file *file)
  1794	{
  1795		static const struct access_masks signal_scope = {
  1796			.scope = LANDLOCK_SCOPE_SIGNAL,
  1797		};
  1798		const struct landlock_cred_security *new_subject;
  1799		struct landlock_cred_security *fown_subject;
  1800		struct landlock_ruleset *prev_dom;
  1801		size_t handle_layer;
  1802	
  1803		/*
  1804		 * Lock already held by __f_setown(), see commit 26f204380a3c ("fs: Fix
  1805		 * file_set_fowner LSM hook inconsistencies").
  1806		 */
  1807		lockdep_assert_held(&file_f_owner(file)->lock);
  1808	
  1809		fown_subject = &landlock_file(file)->fown_subject;
  1810		prev_dom = fown_subject->domain;
  1811		new_subject = landlock_get_applicable_subject(
  1812			current_cred(), signal_scope, &handle_layer);
  1813		if (new_subject) {
  1814			landlock_get_ruleset(new_subject->domain);
  1815			*fown_subject = *new_subject;
> 1816			landlock_file(file)->fown_layer = handle_layer;
  1817		} else {
  1818			static const struct landlock_cred_security empty = {};
  1819	
  1820			*fown_subject = empty;
  1821			landlock_file(file)->fown_layer = 0;
  1822		}
  1823	
  1824		/* Called in an RCU read-side critical section. */
  1825		landlock_put_ruleset_deferred(prev_dom);
  1826	}
  1827	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki