* Re: [PATCH RFC net-next v1] page_pool: import Jesper's page_pool benchmark
[not found] <20250309084118.3080950-1-almasrymina@google.com>
@ 2025-03-10 8:08 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2025-03-10 8:08 UTC (permalink / raw)
To: Mina Almasry; +Cc: llvm, oe-kbuild-all
Hi Mina,
[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:
[auto build test ERROR on 8ef890df4031121a94407c84659125cbccd3fdbe]
url: https://github.com/intel-lab-lkp/linux/commits/Mina-Almasry/page_pool-import-Jesper-s-page_pool-benchmark/20250309-164215
base: 8ef890df4031121a94407c84659125cbccd3fdbe
patch link: https://lore.kernel.org/r/20250309084118.3080950-1-almasrymina%40google.com
patch subject: [PATCH RFC net-next v1] page_pool: import Jesper's page_pool benchmark
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20250310/202503101512.rKBZoYNW-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250310/202503101512.rKBZoYNW-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503101512.rKBZoYNW-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from lib/bench/bench_page_pool_simple.c:10:
In file included from include/linux/module.h:19:
In file included from include/linux/elf.h:6:
In file included from arch/s390/include/asm/elf.h:181:
In file included from arch/s390/include/asm/mmu_context.h:11:
In file included from arch/s390/include/asm/pgalloc.h:18:
In file included from include/linux/mm.h:2224:
include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
504 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
505 | item];
| ~~~~
include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
511 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
512 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
524 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
525 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
In file included from lib/bench/bench_page_pool_simple.c:19:
>> lib/bench/time_bench.h:109:30: error: unknown register name '%rax' in asm
109 | : "=r"(hi), "=r"(lo)::"%rax", "%rbx", "%rcx", "%rdx");
| ^
lib/bench/time_bench.h:122:30: error: unknown register name '%rax' in asm
122 | : "=r"(hi), "=r"(lo)::"%rax", "%rbx", "%rcx", "%rdx");
| ^
>> lib/bench/time_bench.h:188:46: error: invalid input constraint 'c' in asm
188 | asm volatile("rdpmc" : "=d" (d), "=a" (a) : "c" (in) : "memory");
| ^
>> lib/bench/time_bench.h:216:9: error: call to undeclared function 'rdmsrl_safe'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
216 | return rdmsrl_safe(MSR_IA32_PCM0, msr_result);
| ^
3 warnings and 4 errors generated.
--
In file included from lib/bench/time_bench.c:9:
In file included from include/linux/module.h:19:
In file included from include/linux/elf.h:6:
In file included from arch/s390/include/asm/elf.h:181:
In file included from arch/s390/include/asm/mmu_context.h:11:
In file included from arch/s390/include/asm/pgalloc.h:18:
In file included from include/linux/mm.h:2224:
include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
504 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
505 | item];
| ~~~~
include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
511 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
512 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
524 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
525 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
>> lib/bench/time_bench.c:11:10: fatal error: 'linux/time_bench.h' file not found
11 | #include <linux/time_bench.h>
| ^~~~~~~~~~~~~~~~~~~~
3 warnings and 1 error generated.
vim +109 lib/bench/time_bench.h
74
75 /*
76 * Below TSC assembler code is not compatible with other archs, and
77 * can also fail on guests if cpu-flags are not correct.
78 *
79 * The way TSC reading is used, many iterations, does not require as
80 * high accuracy as described below (in Intel Doc #324264).
81 *
82 * Considering changing to use get_cycles() (#include <asm/timex.h>).
83 */
84
85 /** TSC (Time-Stamp Counter) based **
86 * Recommend reading, to understand details of reading TSC accurately:
87 * Intel Doc #324264, "How to Benchmark Code Execution Times on Intel"
88 *
89 * Consider getting exclusive ownership of CPU by using:
90 * unsigned long flags;
91 * preempt_disable();
92 * raw_local_irq_save(flags);
93 * _your_code_
94 * raw_local_irq_restore(flags);
95 * preempt_enable();
96 *
97 * Clobbered registers: "%rax", "%rbx", "%rcx", "%rdx"
98 * RDTSC only change "%rax" and "%rdx" but
99 * CPUID clears the high 32-bits of all (rax/rbx/rcx/rdx)
100 */
101 static __always_inline uint64_t tsc_start_clock(void)
102 {
103 /* See: Intel Doc #324264 */
104 unsigned hi, lo;
105 asm volatile("CPUID\n\t"
106 "RDTSC\n\t"
107 "mov %%edx, %0\n\t"
108 "mov %%eax, %1\n\t"
> 109 : "=r"(hi), "=r"(lo)::"%rax", "%rbx", "%rcx", "%rdx");
110 //FIXME: on 32bit use clobbered %eax + %edx
111 return ((uint64_t)lo) | (((uint64_t)hi) << 32);
112 }
113
114 static __always_inline uint64_t tsc_stop_clock(void)
115 {
116 /* See: Intel Doc #324264 */
117 unsigned hi, lo;
118 asm volatile("RDTSCP\n\t"
119 "mov %%edx, %0\n\t"
120 "mov %%eax, %1\n\t"
121 "CPUID\n\t"
122 : "=r"(hi), "=r"(lo)::"%rax", "%rbx", "%rcx", "%rdx");
123 return ((uint64_t)lo) | (((uint64_t)hi) << 32);
124 }
125
126 /* Notes for RDTSC and RDTSCP
127 *
128 * Hannes found out that __builtin_ia32_rdtsc and
129 * __builtin_ia32_rdtscp are undocumented available in gcc, so there
130 * is no need to write inline assembler functions for them any more.
131 *
132 * unsigned long long __builtin_ia32_rdtscp(unsigned int *foo);
133 * (where foo is set to: numa_node << 12 | cpu)
134 * and
135 * unsigned long long __builtin_ia32_rdtsc(void);
136 *
137 * Above we combine the calls with CPUID, thus I don't see how this is
138 * directly appreciable.
139 */
140
141 /*
142 inline uint64_t rdtsc(void)
143 {
144 uint32_t low, high;
145 asm volatile("rdtsc" : "=a" (low), "=d" (high));
146 return low | (((uint64_t )high ) << 32);
147 }
148 */
149
150 /** Wall-clock based **
151 *
152 * use: getnstimeofday()
153 * getnstimeofday(&rec->ts_start);
154 * getnstimeofday(&rec->ts_stop);
155 *
156 * API changed see: Documentation/core-api/timekeeping.rst
157 * https://www.kernel.org/doc/html/latest/core-api/timekeeping.html#c.getnstimeofday
158 *
159 * We should instead use: ktime_get_real_ts64() is a direct
160 * replacement, but consider using monotonic time (ktime_get_ts64())
161 * and/or a ktime_t based interface (ktime_get()/ktime_get_real()).
162 */
163
164 /** PMU (Performance Monitor Unit) based **
165 *
166 * Needed for calculating: Instructions Per Cycle (IPC)
167 * - The IPC number tell how efficient the CPU pipelining were
168 */
169 //lookup: perf_event_create_kernel_counter()
170
171 bool time_bench_PMU_config(bool enable);
172
173 /* Raw reading via rdpmc() using fixed counters
174 *
175 * From: https://github.com/andikleen/simple-pmu
176 */
177 enum {
178 FIXED_SELECT = (1U << 30), /* == 0x40000000 */
179 FIXED_INST_RETIRED_ANY = 0,
180 FIXED_CPU_CLK_UNHALTED_CORE = 1,
181 FIXED_CPU_CLK_UNHALTED_REF = 2,
182 };
183
184 static __always_inline unsigned long long p_rdpmc(unsigned in)
185 {
186 unsigned d, a;
187
> 188 asm volatile("rdpmc" : "=d" (d), "=a" (a) : "c" (in) : "memory");
189 return ((unsigned long long)d << 32) | a;
190 }
191
192 /* These PMU counter needs to be enabled, but I don't have the
193 * configure code implemented. My current hack is running:
194 * sudo perf stat -e cycles:k -e instructions:k insmod lib/ring_queue_test.ko
195 */
196 /* Reading all pipelined instruction */
197 static __always_inline unsigned long long pmc_inst(void)
198 {
199 return p_rdpmc(FIXED_SELECT | FIXED_INST_RETIRED_ANY);
200 }
201
202 /* Reading CPU clock cycles */
203 static __always_inline unsigned long long pmc_clk(void)
204 {
205 return p_rdpmc(FIXED_SELECT | FIXED_CPU_CLK_UNHALTED_CORE);
206 }
207
208 /* Raw reading via MSR rdmsr() is likely wrong
209 * FIXME: How can I know which raw MSR registers are conf for what?
210 */
211 #define MSR_IA32_PCM0 0x400000C1 /* PERFCTR0 */
212 #define MSR_IA32_PCM1 0x400000C2 /* PERFCTR1 */
213 #define MSR_IA32_PCM2 0x400000C3
214 static inline uint64_t msr_inst(unsigned long long *msr_result)
215 {
> 216 return rdmsrl_safe(MSR_IA32_PCM0, msr_result);
217 }
218
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2025-03-10 8:08 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20250309084118.3080950-1-almasrymina@google.com>
2025-03-10 8:08 ` [PATCH RFC net-next v1] page_pool: import Jesper's page_pool benchmark kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox