[paulmckrcu:dev 42/42] include/linux/ratelimit.h:44:24: error: passing 'raw_spinlock_t' (aka 'struct raw_spinlock') to parameter of incompatible type 'raw_spinlock_t *' (aka 'struct raw_spinlock *'); take the address with &

[paulmckrcu:dev 42/42] include/linux/ratelimit.h:44:24: error: passing 'raw_spinlock_t' (aka 'struct raw_spinlock') to parameter of incompatible type 'raw_spinlock_t *' (aka 'struct raw_spinlock *'); take the address with &

[kernel test robot]

tree:   https://github.com/paulmckrcu/linux dev
head:   eb8edf55ec5fb6db81f970bb09e9aefa17fc49f4
commit: eb8edf55ec5fb6db81f970bb09e9aefa17fc49f4 [42/42] squash! drm/amd/pm: Avoid open-coded use of ratelimit_state structure's ->missed field
config: arm-randconfig-001-20250321 (https://download.01.org/0day-ci/archive/20250321/202503211346.O7rOAnWG-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250321/202503211346.O7rOAnWG-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503211346.O7rOAnWG-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from arch/arm/kernel/asm-offsets.c:12:
   In file included from include/linux/mm.h:1133:
   In file included from include/linux/huge_mm.h:7:
   In file included from include/linux/fs.h:33:
   In file included from include/linux/percpu-rwsem.h:7:
   In file included from include/linux/rcuwait.h:6:
   In file included from include/linux/sched/signal.h:10:
   In file included from include/linux/cred.h:18:
   In file included from include/linux/sched/user.h:9:
>> include/linux/ratelimit.h:44:24: error: passing 'raw_spinlock_t' (aka 'struct raw_spinlock') to parameter of incompatible type 'raw_spinlock_t *' (aka 'struct raw_spinlock *'); take the address with &
      44 |         raw_spin_lock_irqsave(rs->lock, flags);
         |                               ^~~~~~~~
         |                               &
   include/linux/spinlock.h:244:34: note: expanded from macro 'raw_spin_lock_irqsave'
     244 |                 flags = _raw_spin_lock_irqsave(lock);   \
         |                                                ^~~~
   include/linux/spinlock_api_smp.h:32:65: note: passing argument to parameter 'lock' here
      32 | unsigned long __lockfunc _raw_spin_lock_irqsave(raw_spinlock_t *lock)
         |                                                                 ^
   1 error generated.
   make[3]: *** [scripts/Makefile.build:102: arch/arm/kernel/asm-offsets.s] Error 1 shuffle=1602910888
   make[3]: Target 'prepare' not remade because of errors.
   make[2]: *** [Makefile:1264: prepare0] Error 2 shuffle=1602910888
   make[2]: Target 'prepare' not remade because of errors.
   make[1]: *** [Makefile:251: __sub-make] Error 2 shuffle=1602910888
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [Makefile:251: __sub-make] Error 2 shuffle=1602910888
   make: Target 'prepare' not remade because of errors.


vim +44 include/linux/ratelimit.h

    39	
    40	static inline void ratelimit_state_reset_interval(struct ratelimit_state *rs, int interval_init)
    41	{
    42		unsigned long flags;
    43	
  > 44		raw_spin_lock_irqsave(rs->lock, flags);
    45		rs->interval = interval_init;
    46		rs->begin = 0;
    47		rs->printed = 0;
    48		ratelimit_state_reset_miss(rs);
    49		raw_spin_unlock_irqrestore(&rs->lock, flags);
    50	}
    51	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki