* Re: [PATCH] nfs: add a refcount tracker for struct net as held by the nfs_client
[not found] <20250325-nfs-net-nef-v1-1-0142cbd7e9ea@kernel.org>
@ 2025-03-25 17:04 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2025-03-25 17:04 UTC (permalink / raw)
To: Jeff Layton; +Cc: llvm, oe-kbuild-all
Hi Jeff,
kernel test robot noticed the following build errors:
[auto build test ERROR on 38fec10eb60d687e30c8c6b5420d86e8149f7557]
url: https://github.com/intel-lab-lkp/linux/commits/Jeff-Layton/nfs-add-a-refcount-tracker-for-struct-net-as-held-by-the-nfs_client/20250325-194639
base: 38fec10eb60d687e30c8c6b5420d86e8149f7557
patch link: https://lore.kernel.org/r/20250325-nfs-net-nef-v1-1-0142cbd7e9ea%40kernel.org
patch subject: [PATCH] nfs: add a refcount tracker for struct net as held by the nfs_client
config: hexagon-randconfig-002-20250325 (https://download.01.org/0day-ci/archive/20250326/202503260032.8vbQDxxw-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project c2692afc0a92cd5da140dfcdfff7818a5b8ce997)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250326/202503260032.8vbQDxxw-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503260032.8vbQDxxw-lkp@intel.com/
All errors (new ones prefixed by >>):
>> fs/nfs/client.c:183:50: error: no member named 'cl_ns_tracker' in 'struct nfs_client'
183 | clp->cl_net = get_net_track(cl_init->net, &clp->cl_ns_tracker, GFP_KERNEL);
| ~~~ ^
fs/nfs/client.c:253:35: error: no member named 'cl_ns_track' in 'struct nfs_client'
253 | put_net_track(clp->cl_net, &clp->cl_ns_track);
| ~~~ ^
2 errors generated.
vim +183 fs/nfs/client.c
141
142 /*
143 * Allocate a shared client record
144 *
145 * Since these are allocated/deallocated very rarely, we don't
146 * bother putting them in a slab cache...
147 */
148 struct nfs_client *nfs_alloc_client(const struct nfs_client_initdata *cl_init)
149 {
150 struct nfs_client *clp;
151 int err = -ENOMEM;
152
153 if ((clp = kzalloc(sizeof(*clp), GFP_KERNEL)) == NULL)
154 goto error_0;
155
156 clp->cl_minorversion = cl_init->minorversion;
157 clp->cl_nfs_mod = cl_init->nfs_mod;
158 if (!get_nfs_version(clp->cl_nfs_mod))
159 goto error_dealloc;
160
161 clp->rpc_ops = clp->cl_nfs_mod->rpc_ops;
162
163 refcount_set(&clp->cl_count, 1);
164 clp->cl_cons_state = NFS_CS_INITING;
165
166 memcpy(&clp->cl_addr, cl_init->addr, cl_init->addrlen);
167 clp->cl_addrlen = cl_init->addrlen;
168
169 if (cl_init->hostname) {
170 err = -ENOMEM;
171 clp->cl_hostname = kstrdup(cl_init->hostname, GFP_KERNEL);
172 if (!clp->cl_hostname)
173 goto error_cleanup;
174 }
175
176 INIT_LIST_HEAD(&clp->cl_superblocks);
177 clp->cl_rpcclient = ERR_PTR(-EINVAL);
178
179 clp->cl_flags = cl_init->init_flags;
180 clp->cl_proto = cl_init->proto;
181 clp->cl_nconnect = cl_init->nconnect;
182 clp->cl_max_connect = cl_init->max_connect ? cl_init->max_connect : 1;
> 183 clp->cl_net = get_net_track(cl_init->net, &clp->cl_ns_tracker, GFP_KERNEL);
184
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread