* Re: [PATCH] usbip: set the dma mask to 64bit default for vhci-driver
[not found] <20250422063409.607859-1-min_halo@163.com>
@ 2025-04-23 1:02 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2025-04-23 1:02 UTC (permalink / raw)
To: Zongmin Zhou, skhan
Cc: llvm, oe-kbuild-all, gregkh, i, linux-kernel, linux-usb, shuah,
valentina.manea.m, Zongmin Zhou
Hi Zongmin,
kernel test robot noticed the following build errors:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on usb/usb-next usb/usb-linus linus/master v6.15-rc3 next-20250422]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Zongmin-Zhou/usbip-set-the-dma-mask-to-64bit-default-for-vhci-driver/20250422-143646
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
patch link: https://lore.kernel.org/r/20250422063409.607859-1-min_halo%40163.com
patch subject: [PATCH] usbip: set the dma mask to 64bit default for vhci-driver
config: arm-randconfig-004-20250423 (https://download.01.org/0day-ci/archive/20250423/202504230805.MkmxQyas-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project f819f46284f2a79790038e1f6649172789734ae8)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250423/202504230805.MkmxQyas-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504230805.MkmxQyas-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/usb/usbip/vhci_hcd.c:1349:2: error: call to undeclared function 'dma_set_mask'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
1349 | dma_set_mask(&pdev->dev, DMA_BIT_MASK(64));
| ^
drivers/usb/usbip/vhci_hcd.c:1349:2: note: did you mean 'xa_set_mark'?
include/linux/xarray.h:361:6: note: 'xa_set_mark' declared here
361 | void xa_set_mark(struct xarray *, unsigned long index, xa_mark_t);
| ^
>> drivers/usb/usbip/vhci_hcd.c:1349:27: error: call to undeclared function 'DMA_BIT_MASK'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
1349 | dma_set_mask(&pdev->dev, DMA_BIT_MASK(64));
| ^
2 errors generated.
vim +/dma_set_mask +1349 drivers/usb/usbip/vhci_hcd.c
1338
1339 static int vhci_hcd_probe(struct platform_device *pdev)
1340 {
1341 struct vhci *vhci = *((void **)dev_get_platdata(&pdev->dev));
1342 struct usb_hcd *hcd_hs;
1343 struct usb_hcd *hcd_ss;
1344 int ret;
1345
1346 usbip_dbg_vhci_hc("name %s id %d\n", pdev->name, pdev->id);
1347
1348 /* Set the dma mask to support 64bit for vhci-hcd driver. */
> 1349 dma_set_mask(&pdev->dev, DMA_BIT_MASK(64));
1350
1351 /*
1352 * Allocate and initialize hcd.
1353 * Our private data is also allocated automatically.
1354 */
1355 hcd_hs = usb_create_hcd(&vhci_hc_driver, &pdev->dev, dev_name(&pdev->dev));
1356 if (!hcd_hs) {
1357 pr_err("create primary hcd failed\n");
1358 return -ENOMEM;
1359 }
1360 hcd_hs->has_tt = 1;
1361
1362 /*
1363 * Finish generic HCD structure initialization and register.
1364 * Call the driver's reset() and start() routines.
1365 */
1366 ret = usb_add_hcd(hcd_hs, 0, 0);
1367 if (ret != 0) {
1368 pr_err("usb_add_hcd hs failed %d\n", ret);
1369 goto put_usb2_hcd;
1370 }
1371
1372 hcd_ss = usb_create_shared_hcd(&vhci_hc_driver, &pdev->dev,
1373 dev_name(&pdev->dev), hcd_hs);
1374 if (!hcd_ss) {
1375 ret = -ENOMEM;
1376 pr_err("create shared hcd failed\n");
1377 goto remove_usb2_hcd;
1378 }
1379
1380 ret = usb_add_hcd(hcd_ss, 0, 0);
1381 if (ret) {
1382 pr_err("usb_add_hcd ss failed %d\n", ret);
1383 goto put_usb3_hcd;
1384 }
1385
1386 usbip_dbg_vhci_hc("bye\n");
1387 return 0;
1388
1389 put_usb3_hcd:
1390 usb_put_hcd(hcd_ss);
1391 remove_usb2_hcd:
1392 usb_remove_hcd(hcd_hs);
1393 put_usb2_hcd:
1394 usb_put_hcd(hcd_hs);
1395 vhci->vhci_hcd_hs = NULL;
1396 vhci->vhci_hcd_ss = NULL;
1397 return ret;
1398 }
1399
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread