Re: [PATCH v1] usb: isp1760: increase buffer size to avoid overflow

Re: [PATCH v1] usb: isp1760: increase buffer size to avoid overflow

[kernel test robot]

In-Reply-To: <20250423111040.GC857@altlinux.org>
References: <20250423111040.GC857@altlinux.org>
TO: "Alexey V. Vissarionov" <gremlin@altlinux.org>
TO: Rui Miguel Silva <rui.silva@linaro.org>
CC: "Alexey V. Vissarionov" <gremlin@altlinux.org>
CC: Fedor Pchelkin <pchelkin@ispras.ru>
CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
CC: linux-usb@vger.kernel.org
CC: lvc-project@linuxtesting.org

Hi Alexey,

kernel test robot noticed the following build warnings:

[auto build test WARNING on usb/usb-testing]
[also build test WARNING on usb/usb-next usb/usb-linus linus/master v6.15-rc3 next-20250424]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Alexey-V-Vissarionov/usb-isp1760-increase-buffer-size-to-avoid-overflow/20250423-191222
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
patch link:    https://lore.kernel.org/r/20250423111040.GC857%40altlinux.org
patch subject: [PATCH v1] usb: isp1760: increase buffer size to avoid overflow
config: hexagon-randconfig-002-20250424 (https://download.01.org/0day-ci/archive/20250424/202504242017.ShUkQrcZ-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project f819f46284f2a79790038e1f6649172789734ae8)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250424/202504242017.ShUkQrcZ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504242017.ShUkQrcZ-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from drivers/usb/isp1760/isp1760-if.c:24:
   In file included from drivers/usb/isp1760/isp1760-core.h:21:
>> drivers/usb/isp1760/isp1760-hcd.h:53:30: warning: comparison of different enumeration types ('enum isp176x_device_controller_fields' and 'enum isp176x_host_controller_fields') [-Wenum-compare]
      53 |         struct regmap_field     *fields[DC_HC_FIELD_MAX];
         |                                         ^~~~~~~~~~~~~~~
   drivers/usb/isp1760/isp1760-regs.h:271:16: note: expanded from macro 'DC_HC_FIELD_MAX'
     271 |         (DC_FIELD_MAX > HC_FIELD_MAX ? DC_FIELD_MAX : HC_FIELD_MAX)
         |          ~~~~~~~~~~~~ ^ ~~~~~~~~~~~~
   In file included from drivers/usb/isp1760/isp1760-if.c:24:
   In file included from drivers/usb/isp1760/isp1760-core.h:21:
>> drivers/usb/isp1760/isp1760-hcd.h:53:30: warning: conditional expression between different enumeration types ('enum isp176x_device_controller_fields' and 'enum isp176x_host_controller_fields') [-Wenum-compare-conditional]
      53 |         struct regmap_field     *fields[DC_HC_FIELD_MAX];
         |                                         ^~~~~~~~~~~~~~~
   drivers/usb/isp1760/isp1760-regs.h:271:31: note: expanded from macro 'DC_HC_FIELD_MAX'
     271 |         (DC_FIELD_MAX > HC_FIELD_MAX ? DC_FIELD_MAX : HC_FIELD_MAX)
         |                                      ^ ~~~~~~~~~~~~   ~~~~~~~~~~~~
   In file included from drivers/usb/isp1760/isp1760-if.c:24:
   In file included from drivers/usb/isp1760/isp1760-core.h:22:
>> drivers/usb/isp1760/isp1760-udc.h:72:30: warning: comparison of different enumeration types ('enum isp176x_device_controller_fields' and 'enum isp176x_host_controller_fields') [-Wenum-compare]
      72 |         struct regmap_field *fields[DC_HC_FIELD_MAX];
         |                                     ^~~~~~~~~~~~~~~
   drivers/usb/isp1760/isp1760-regs.h:271:16: note: expanded from macro 'DC_HC_FIELD_MAX'
     271 |         (DC_FIELD_MAX > HC_FIELD_MAX ? DC_FIELD_MAX : HC_FIELD_MAX)
         |          ~~~~~~~~~~~~ ^ ~~~~~~~~~~~~
   In file included from drivers/usb/isp1760/isp1760-if.c:24:
   In file included from drivers/usb/isp1760/isp1760-core.h:22:
>> drivers/usb/isp1760/isp1760-udc.h:72:30: warning: conditional expression between different enumeration types ('enum isp176x_device_controller_fields' and 'enum isp176x_host_controller_fields') [-Wenum-compare-conditional]
      72 |         struct regmap_field *fields[DC_HC_FIELD_MAX];
         |                                     ^~~~~~~~~~~~~~~
   drivers/usb/isp1760/isp1760-regs.h:271:31: note: expanded from macro 'DC_HC_FIELD_MAX'
     271 |         (DC_FIELD_MAX > HC_FIELD_MAX ? DC_FIELD_MAX : HC_FIELD_MAX)
         |                                      ^ ~~~~~~~~~~~~   ~~~~~~~~~~~~
   4 warnings generated.


vim +53 drivers/usb/isp1760/isp1760-hcd.h

    46	
    47	struct isp1760_hcd {
    48		struct usb_hcd		*hcd;
    49	
    50		void __iomem		*base;
    51	
    52		struct regmap		*regs;
  > 53		struct regmap_field	*fields[DC_HC_FIELD_MAX];
    54	
    55		bool			is_isp1763;
    56		const struct isp1760_memory_layout	*memory_layout;
    57	
    58		spinlock_t		lock;
    59		struct isp1760_slotinfo	*atl_slots;
    60		int			atl_done_map;
    61		struct isp1760_slotinfo	*int_slots;
    62		int			int_done_map;
    63		struct isp1760_memory_chunk memory_pool[ISP176x_BLOCK_MAX];
    64		struct list_head	qh_list[QH_END];
    65	
    66		/* periodic schedule support */
    67	#define	DEFAULT_I_TDPS		1024
    68		unsigned		periodic_size;
    69		unsigned		i_thresh;
    70		unsigned long		reset_done;
    71		unsigned long		next_statechange;
    72	};
    73	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki