Re: [PATCH wireless-next v7 1/3] wifi: cfg80211: Add Support to Set RTS Threshold for each Radio

Re: [PATCH wireless-next v7 1/3] wifi: cfg80211: Add Support to Set RTS Threshold for each Radio

[kernel test robot]

Hi Roopni,

kernel test robot noticed the following build warnings:

[auto build test WARNING on f600832794c91d7021d7337104734246b02a2b86]

url:    https://github.com/intel-lab-lkp/linux/commits/Roopni-Devanathan/wifi-cfg80211-Add-Support-to-Set-RTS-Threshold-for-each-Radio/20250424-215112
base:   f600832794c91d7021d7337104734246b02a2b86
patch link:    https://lore.kernel.org/r/20250424134752.871886-2-quic_rdevanat%40quicinc.com
patch subject: [PATCH wireless-next v7 1/3] wifi: cfg80211: Add Support to Set RTS Threshold for each Radio
config: arm64-randconfig-001-20250425 (https://download.01.org/0day-ci/archive/20250425/202504252342.Myui0D81-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project f819f46284f2a79790038e1f6649172789734ae8)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250425/202504252342.Myui0D81-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504252342.Myui0D81-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> net/wireless/nl80211.c:3625:3: warning: variable 'changed' is uninitialized when used here [-Wuninitialized]
    3625 |                 changed |= WIPHY_PARAM_RTS_THRESHOLD;
         |                 ^~~~~~~
   net/wireless/nl80211.c:3616:47: note: initialize the variable 'changed' to silence this warning
    3616 |         u32 rts_threshold, old_rts_threshold, changed;
         |                                                      ^
         |                                                       = 0
   1 warning generated.


vim +/changed +3625 net/wireless/nl80211.c

  3611	
  3612	static int nl80211_set_wiphy_radio(struct genl_info *info,
  3613					   struct cfg80211_registered_device *rdev,
  3614					   u8 radio_id)
  3615	{
  3616		u32 rts_threshold, old_rts_threshold, changed;
  3617		int result = 0;
  3618	
  3619		if (!rdev->ops->set_wiphy_params)
  3620			return -EOPNOTSUPP;
  3621	
  3622		if (info->attrs[NL80211_ATTR_WIPHY_RTS_THRESHOLD]) {
  3623			rts_threshold = nla_get_u32(
  3624					info->attrs[NL80211_ATTR_WIPHY_RTS_THRESHOLD]);
> 3625			changed |= WIPHY_PARAM_RTS_THRESHOLD;
  3626		}
  3627	
  3628		if (changed) {
  3629			old_rts_threshold = rdev->wiphy.radio_cfg[radio_id].rts_threshold;
  3630	
  3631			rdev->wiphy.radio_cfg[radio_id].rts_threshold = rts_threshold;
  3632	
  3633			result = rdev_set_wiphy_params(rdev, radio_id, changed);
  3634			if (result)
  3635				rdev->wiphy.radio_cfg[radio_id].rts_threshold = old_rts_threshold;
  3636		}
  3637	
  3638		return result;
  3639	}
  3640	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki