Re: [PATCH 3/3] staging: gpib: Avoid unused variable warning

Re: [PATCH 3/3] staging: gpib: Avoid unused variable warning

[kernel test robot]

Hi Dave,

kernel test robot noticed the following build errors:

[auto build test ERROR on staging/staging-testing]

url:    https://github.com/intel-lab-lkp/linux/commits/Dave-Penkler/staging-gpib-Fix-PCMCIA-config-identifier/20250427-171209
base:   staging/staging-testing
patch link:    https://lore.kernel.org/r/20250427091018.13705-4-dpenkler%40gmail.com
patch subject: [PATCH 3/3] staging: gpib: Avoid unused variable warning
config: arm-randconfig-001-20250427 (https://download.01.org/0day-ci/archive/20250427/202504271837.SgHoiLBt-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project f819f46284f2a79790038e1f6649172789734ae8)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250427/202504271837.SgHoiLBt-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504271837.SgHoiLBt-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/staging/gpib/ines/ines_gpib.c:1118:2: error: use of undeclared identifier 'dev'
    1118 |         dev = link->priv;
         |         ^
   1 error generated.


vim +/dev +1118 drivers/staging/gpib/ines/ines_gpib.c

bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1107  
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1108  /*
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1109   * gpib_config() is scheduled to run after a CARD_INSERTION event
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1110   * is received, to configure the PCMCIA socket, and to make the
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1111   * device available to the system.
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1112   */
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1113  static int ines_gpib_config(struct pcmcia_device *link)
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1114  {
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1115  	int retval;
77b41a9342f610 Dave Penkler  2025-01-14  1116  	void __iomem *virt;
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1117  
bb1bd92fa0f2c9 Dave Penkler  2024-09-18 @1118  	dev = link->priv;
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1119  
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1120  	retval = pcmcia_loop_config(link, &ines_gpib_config_iteration, NULL);
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1121  	if (retval) {
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1122  		dev_warn(&link->dev, "no configuration found\n");
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1123  		ines_gpib_release(link);
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1124  		return -ENODEV;
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1125  	}
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1126  
0de51244e7b7e3 Dave Penkler  2025-02-20  1127  	dev_dbg(&link->dev, "ines_cs: manufacturer: 0x%x card: 0x%x\n",
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1128  		link->manf_id, link->card_id);
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1129  
2de3fa2c3f4e25 Paul Retourné 2025-04-11  1130  	/*
2de3fa2c3f4e25 Paul Retourné 2025-04-11  1131  	 * for the ines card we have to setup the configuration registers in
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1132  	 * attribute memory here
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1133  	 */
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1134  	link->resource[2]->flags |= WIN_MEMORY_TYPE_AM | WIN_DATA_WIDTH_8 | WIN_ENABLE;
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1135  	link->resource[2]->end = 0x1000;
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1136  	retval = pcmcia_request_window(link, link->resource[2], 250);
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1137  	if (retval) {
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1138  		dev_warn(&link->dev, "pcmcia_request_window failed\n");
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1139  		ines_gpib_release(link);
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1140  		return -ENODEV;
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1141  	}
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1142  	retval = pcmcia_map_mem_page(link, link->resource[2], 0);
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1143  	if (retval) {
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1144  		dev_warn(&link->dev, "pcmcia_map_mem_page failed\n");
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1145  		ines_gpib_release(link);
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1146  		return -ENODEV;
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1147  	}
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1148  	virt = ioremap(link->resource[2]->start, resource_size(link->resource[2]));
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1149  	writeb((link->resource[2]->start >> 2) & 0xff, virt + 0xf0); // IOWindow base
77b41a9342f610 Dave Penkler  2025-01-14  1150  	iounmap(virt);
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1151  
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1152  	/*
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1153  	 * This actually configures the PCMCIA socket -- setting up
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1154  	 * the I/O windows and the interrupt mapping.
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1155  	 */
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1156  	retval = pcmcia_enable_device(link);
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1157  	if (retval) {
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1158  		ines_gpib_release(link);
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1159  		return -ENODEV;
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1160  	}
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1161  	return 0;
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1162  } /* gpib_config */
bb1bd92fa0f2c9 Dave Penkler  2024-09-18  1163  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki