Re: [PATCH 7/7] sysfs: Remove transitional attribute group alias macros

Re: [PATCH 7/7] sysfs: Remove transitional attribute group alias macros

[kernel test robot]

Hi David,

kernel test robot noticed the following build errors:

[auto build test ERROR on 9c32cda43eb78f78c73aee4aa344b777714e259b]

url:    https://github.com/intel-lab-lkp/linux/commits/David-E-Box/sysfs-Rename-attribute-group-visibility-macros/20250424-015249
base:   9c32cda43eb78f78c73aee4aa344b777714e259b
patch link:    https://lore.kernel.org/r/20250423175040.784680-8-david.e.box%40linux.intel.com
patch subject: [PATCH 7/7] sysfs: Remove transitional attribute group alias macros
config: x86_64-randconfig-072-20250506 (https://download.01.org/0day-ci/archive/20250507/202505071519.Rg3hK4UR-lkp@intel.com/config)
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250507/202505071519.Rg3hK4UR-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505071519.Rg3hK4UR-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/input/touchscreen/usbtouchscreen.c:477:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
     477 | DEFINE_SIMPLE_SYSFS_GROUP_VISIBLE(mtouch);
         | ^
         | int
>> drivers/input/touchscreen/usbtouchscreen.c:477:35: error: a parameter list without types is only allowed in a function definition
     477 | DEFINE_SIMPLE_SYSFS_GROUP_VISIBLE(mtouch);
         |                                   ^
>> drivers/input/touchscreen/usbtouchscreen.c:480:16: error: use of undeclared identifier 'sysfs_group_visible_mtouch'
     480 |         .is_visible = SYSFS_GROUP_VISIBLE(mtouch),
         |                       ^
   include/linux/sysfs.h:223:33: note: expanded from macro 'SYSFS_GROUP_VISIBLE'
     223 | #define SYSFS_GROUP_VISIBLE(fn) sysfs_group_visible_##fn
         |                                 ^
   <scratch space>:95:1: note: expanded from here
      95 | sysfs_group_visible_mtouch
         | ^
   3 errors generated.


vim +/int +477 drivers/input/touchscreen/usbtouchscreen.c

7f787df1ac447e drivers/input/touchscreen/usbtouchscreen.c Dmitry Torokhov 2024-07-11  476  
7f787df1ac447e drivers/input/touchscreen/usbtouchscreen.c Dmitry Torokhov 2024-07-11 @477  DEFINE_SIMPLE_SYSFS_GROUP_VISIBLE(mtouch);
7f787df1ac447e drivers/input/touchscreen/usbtouchscreen.c Dmitry Torokhov 2024-07-11  478  
7f787df1ac447e drivers/input/touchscreen/usbtouchscreen.c Dmitry Torokhov 2024-07-11  479  static const struct attribute_group mtouch_attr_group = {
7f787df1ac447e drivers/input/touchscreen/usbtouchscreen.c Dmitry Torokhov 2024-07-11 @480  	.is_visible = SYSFS_GROUP_VISIBLE(mtouch),
7f787df1ac447e drivers/input/touchscreen/usbtouchscreen.c Dmitry Torokhov 2024-07-11  481  	.attrs = mtouch_attrs,
7f787df1ac447e drivers/input/touchscreen/usbtouchscreen.c Dmitry Torokhov 2024-07-11  482  };
1d3e20236d7a56 drivers/usb/input/usbtouchscreen.c         Daniel Ritz     2006-03-29  483  #endif
1d3e20236d7a56 drivers/usb/input/usbtouchscreen.c         Daniel Ritz     2006-03-29  484  
1d3e20236d7a56 drivers/usb/input/usbtouchscreen.c         Daniel Ritz     2006-03-29  485  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki