* Re: [PATCH] mm: madvise: make MADV_NOHUGEPAGE a no-op if !THP
[not found] <20250508-madvise-nohugepage-noop-without-thp-v1-1-e7ceffb197f3@kuka.com>
@ 2025-05-09 9:59 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2025-05-09 9:59 UTC (permalink / raw)
To: Ignacio Moreno Gonzalez via B4 Relay; +Cc: llvm, oe-kbuild-all
Hi Ignacio,
kernel test robot noticed the following build errors:
[auto build test ERROR on fc96b232f8e7c0a6c282f47726b2ff6a5fb341d2]
url: https://github.com/intel-lab-lkp/linux/commits/Ignacio-Moreno-Gonzalez-via-B4-Relay/mm-madvise-make-MADV_NOHUGEPAGE-a-no-op-if-THP/20250508-182107
base: fc96b232f8e7c0a6c282f47726b2ff6a5fb341d2
patch link: https://lore.kernel.org/r/20250508-madvise-nohugepage-noop-without-thp-v1-1-e7ceffb197f3%40kuka.com
patch subject: [PATCH] mm: madvise: make MADV_NOHUGEPAGE a no-op if !THP
config: s390-randconfig-002-20250509 (https://download.01.org/0day-ci/archive/20250509/202505091740.BC3ad4im-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250509/202505091740.BC3ad4im-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505091740.BC3ad4im-lkp@intel.com/
All errors (new ones prefixed by >>):
>> arch/s390/kvm/gaccess.c:321:2: error: expected identifier
321 | PROT_NONE,
| ^
include/uapi/asm-generic/mman-common.h:16:19: note: expanded from macro 'PROT_NONE'
16 | #define PROT_NONE 0x0 /* page can not be accessed */
| ^
>> arch/s390/kvm/gaccess.c:344:8: error: duplicate case value: '0' and 'PROT_TYPE_LA' both equal '0'
344 | case PROT_TYPE_LA:
| ^
arch/s390/kvm/gaccess.c:337:8: note: previous case defined here
337 | case PROT_NONE:
| ^
include/uapi/asm-generic/mman-common.h:16:19: note: expanded from macro 'PROT_NONE'
16 | #define PROT_NONE 0x0 /* page can not be accessed */
| ^
2 errors generated.
vim +321 arch/s390/kvm/gaccess.c
664b49735370684 Alexander Yarygin 2015-03-09 313
d03193de30e6d99 David Hildenbrand 2016-05-31 314 enum prot_type {
d03193de30e6d99 David Hildenbrand 2016-05-31 315 PROT_TYPE_LA = 0,
d03193de30e6d99 David Hildenbrand 2016-05-31 316 PROT_TYPE_KEYC = 1,
d03193de30e6d99 David Hildenbrand 2016-05-31 317 PROT_TYPE_ALC = 2,
d03193de30e6d99 David Hildenbrand 2016-05-31 318 PROT_TYPE_DAT = 3,
6ae1574c2a24eec Christian Borntraeger 2017-06-07 319 PROT_TYPE_IEP = 4,
b3cefd6bf16e723 Janis Schoetterl-Glausch 2022-08-25 320 /* Dummy value for passing an initialized value when code != PGM_PROTECTION */
b3cefd6bf16e723 Janis Schoetterl-Glausch 2022-08-25 @321 PROT_NONE,
d03193de30e6d99 David Hildenbrand 2016-05-31 322 };
d03193de30e6d99 David Hildenbrand 2016-05-31 323
c783631b0bffe60 Janis Schoetterl-Glausch 2022-05-12 324 static int trans_exc_ending(struct kvm_vcpu *vcpu, int code, unsigned long gva, u8 ar,
c783631b0bffe60 Janis Schoetterl-Glausch 2022-05-12 325 enum gacc_mode mode, enum prot_type prot, bool terminate)
d03193de30e6d99 David Hildenbrand 2016-05-31 326 {
d03193de30e6d99 David Hildenbrand 2016-05-31 327 struct kvm_s390_pgm_info *pgm = &vcpu->arch.pgm;
44ae766353af6eb Heiko Carstens 2023-10-12 328 union teid *teid;
d03193de30e6d99 David Hildenbrand 2016-05-31 329
d03193de30e6d99 David Hildenbrand 2016-05-31 330 memset(pgm, 0, sizeof(*pgm));
d03193de30e6d99 David Hildenbrand 2016-05-31 331 pgm->code = code;
44ae766353af6eb Heiko Carstens 2023-10-12 332 teid = (union teid *)&pgm->trans_exc_code;
d03193de30e6d99 David Hildenbrand 2016-05-31 333
d03193de30e6d99 David Hildenbrand 2016-05-31 334 switch (code) {
c14b88d76624e02 Janosch Frank 2016-07-29 335 case PGM_PROTECTION:
c14b88d76624e02 Janosch Frank 2016-07-29 336 switch (prot) {
b3cefd6bf16e723 Janis Schoetterl-Glausch 2022-08-25 337 case PROT_NONE:
b3cefd6bf16e723 Janis Schoetterl-Glausch 2022-08-25 338 /* We should never get here, acts like termination */
b3cefd6bf16e723 Janis Schoetterl-Glausch 2022-08-25 339 WARN_ON_ONCE(1);
b3cefd6bf16e723 Janis Schoetterl-Glausch 2022-08-25 340 break;
6ae1574c2a24eec Christian Borntraeger 2017-06-07 341 case PROT_TYPE_IEP:
44ae766353af6eb Heiko Carstens 2023-10-12 342 teid->b61 = 1;
3b684a420bd8a26 Joe Perches 2020-03-10 343 fallthrough;
a679c547d19ded9 Christian Borntraeger 2016-12-15 @344 case PROT_TYPE_LA:
44ae766353af6eb Heiko Carstens 2023-10-12 345 teid->b56 = 1;
a679c547d19ded9 Christian Borntraeger 2016-12-15 346 break;
a679c547d19ded9 Christian Borntraeger 2016-12-15 347 case PROT_TYPE_KEYC:
44ae766353af6eb Heiko Carstens 2023-10-12 348 teid->b60 = 1;
a679c547d19ded9 Christian Borntraeger 2016-12-15 349 break;
c14b88d76624e02 Janosch Frank 2016-07-29 350 case PROT_TYPE_ALC:
44ae766353af6eb Heiko Carstens 2023-10-12 351 teid->b60 = 1;
3b684a420bd8a26 Joe Perches 2020-03-10 352 fallthrough;
c14b88d76624e02 Janosch Frank 2016-07-29 353 case PROT_TYPE_DAT:
44ae766353af6eb Heiko Carstens 2023-10-12 354 teid->b61 = 1;
c14b88d76624e02 Janosch Frank 2016-07-29 355 break;
c14b88d76624e02 Janosch Frank 2016-07-29 356 }
c783631b0bffe60 Janis Schoetterl-Glausch 2022-05-12 357 if (terminate) {
44ae766353af6eb Heiko Carstens 2023-10-12 358 teid->b56 = 0;
44ae766353af6eb Heiko Carstens 2023-10-12 359 teid->b60 = 0;
44ae766353af6eb Heiko Carstens 2023-10-12 360 teid->b61 = 0;
c783631b0bffe60 Janis Schoetterl-Glausch 2022-05-12 361 }
3b684a420bd8a26 Joe Perches 2020-03-10 362 fallthrough;
d03193de30e6d99 David Hildenbrand 2016-05-31 363 case PGM_ASCE_TYPE:
d03193de30e6d99 David Hildenbrand 2016-05-31 364 case PGM_PAGE_TRANSLATION:
d03193de30e6d99 David Hildenbrand 2016-05-31 365 case PGM_REGION_FIRST_TRANS:
d03193de30e6d99 David Hildenbrand 2016-05-31 366 case PGM_REGION_SECOND_TRANS:
d03193de30e6d99 David Hildenbrand 2016-05-31 367 case PGM_REGION_THIRD_TRANS:
d03193de30e6d99 David Hildenbrand 2016-05-31 368 case PGM_SEGMENT_TRANSLATION:
d03193de30e6d99 David Hildenbrand 2016-05-31 369 /*
d03193de30e6d99 David Hildenbrand 2016-05-31 370 * op_access_id only applies to MOVE_PAGE -> set bit 61
d03193de30e6d99 David Hildenbrand 2016-05-31 371 * exc_access_id has to be set to 0 for some instructions. Both
c14b88d76624e02 Janosch Frank 2016-07-29 372 * cases have to be handled by the caller.
d03193de30e6d99 David Hildenbrand 2016-05-31 373 */
44ae766353af6eb Heiko Carstens 2023-10-12 374 teid->addr = gva >> PAGE_SHIFT;
44ae766353af6eb Heiko Carstens 2023-10-12 375 teid->fsi = mode == GACC_STORE ? TEID_FSI_STORE : TEID_FSI_FETCH;
44ae766353af6eb Heiko Carstens 2023-10-12 376 teid->as = psw_bits(vcpu->arch.sie_block->gpsw).as;
3b684a420bd8a26 Joe Perches 2020-03-10 377 fallthrough;
d03193de30e6d99 David Hildenbrand 2016-05-31 378 case PGM_ALEN_TRANSLATION:
d03193de30e6d99 David Hildenbrand 2016-05-31 379 case PGM_ALE_SEQUENCE:
d03193de30e6d99 David Hildenbrand 2016-05-31 380 case PGM_ASTE_VALIDITY:
d03193de30e6d99 David Hildenbrand 2016-05-31 381 case PGM_ASTE_SEQUENCE:
d03193de30e6d99 David Hildenbrand 2016-05-31 382 case PGM_EXTENDED_AUTHORITY:
c14b88d76624e02 Janosch Frank 2016-07-29 383 /*
c14b88d76624e02 Janosch Frank 2016-07-29 384 * We can always store exc_access_id, as it is
c14b88d76624e02 Janosch Frank 2016-07-29 385 * undefined for non-ar cases. It is undefined for
c14b88d76624e02 Janosch Frank 2016-07-29 386 * most DAT protection exceptions.
c14b88d76624e02 Janosch Frank 2016-07-29 387 */
d03193de30e6d99 David Hildenbrand 2016-05-31 388 pgm->exc_access_id = ar;
d03193de30e6d99 David Hildenbrand 2016-05-31 389 break;
d03193de30e6d99 David Hildenbrand 2016-05-31 390 }
d03193de30e6d99 David Hildenbrand 2016-05-31 391 return code;
d03193de30e6d99 David Hildenbrand 2016-05-31 392 }
d03193de30e6d99 David Hildenbrand 2016-05-31 393
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread