* Re: [PATCH iwl-net v2 3/3] ice: fix rebuilding the Tx scheduler tree for large queue counts
[not found] <20250509094233.197245-4-michal.kubiak@intel.com>
@ 2025-05-09 15:16 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2025-05-09 15:16 UTC (permalink / raw)
To: Michal Kubiak; +Cc: llvm, oe-kbuild-all
Hi Michal,
kernel test robot noticed the following build warnings:
[auto build test WARNING on tnguy-net-queue/dev-queue]
url: https://github.com/intel-lab-lkp/linux/commits/Michal-Kubiak/ice-fix-Tx-scheduler-error-handling-in-XDP-callback/20250509-174401
base: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue.git dev-queue
patch link: https://lore.kernel.org/r/20250509094233.197245-4-michal.kubiak%40intel.com
patch subject: [PATCH iwl-net v2 3/3] ice: fix rebuilding the Tx scheduler tree for large queue counts
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20250509/202505092344.1eUfv4i4-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250509/202505092344.1eUfv4i4-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505092344.1eUfv4i4-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/net/ethernet/intel/ice/ice_sched.c:2113: warning: Function parameter or struct member 'vsi_node' not described in 'ice_sched_rm_vsi_subtree'
>> drivers/net/ethernet/intel/ice/ice_sched.c:2113: warning: Excess function parameter 'vsi_handle' description in 'ice_sched_rm_vsi_subtree'
vim +2113 drivers/net/ethernet/intel/ice/ice_sched.c
2097
2098 /**
2099 * ice_sched_rm_vsi_subtree - remove all nodes assigned to a given VSI
2100 * @pi: port information structure
2101 * @vsi_handle: software VSI handle
2102 * @owner: LAN or RDMA
2103 * @tc: TC number
2104 *
2105 * Return: Zero in case of success, or -EBUSY if the VSI has leaf nodes in TC.
2106 *
2107 * This function removes all the VSI support nodes associated with a given VSI
2108 * and its LAN or RDMA children nodes from the scheduler tree.
2109 */
2110 static int
2111 ice_sched_rm_vsi_subtree(struct ice_port_info *pi,
2112 struct ice_sched_node *vsi_node, u8 owner, u8 tc)
> 2113 {
2114 u16 vsi_handle = vsi_node->vsi_handle;
2115 bool all_vsi_nodes_removed = true;
2116 int j = 0;
2117
2118 while (vsi_node) {
2119 struct ice_sched_node *next_vsi_node;
2120
2121 if (ice_sched_is_leaf_node_present(vsi_node)) {
2122 ice_debug(pi->hw, ICE_DBG_SCHED, "VSI has leaf nodes in TC %d\n", tc);
2123 return -EBUSY;
2124 }
2125 while (j < vsi_node->num_children) {
2126 if (vsi_node->children[j]->owner == owner) {
2127 ice_free_sched_node(pi, vsi_node->children[j]);
2128
2129 /* reset the counter again since the num
2130 * children will be updated after node removal
2131 */
2132 j = 0;
2133 } else {
2134 j++;
2135 }
2136 }
2137
2138 next_vsi_node = ice_sched_find_next_vsi_node(vsi_node);
2139
2140 /* remove the VSI if it has no children */
2141 if (!vsi_node->num_children)
2142 ice_free_sched_node(pi, vsi_node);
2143 else
2144 all_vsi_nodes_removed = false;
2145
2146 vsi_node = next_vsi_node;
2147 }
2148
2149 /* clean up aggregator related VSI info if any */
2150 if (all_vsi_nodes_removed)
2151 ice_sched_rm_agg_vsi_info(pi, vsi_handle);
2152
2153 return 0;
2154 }
2155
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread