* Re: [RFC 2/3] block: use LARGE_ZERO_PAGE in __blkdev_issue_zero_pages()
[not found] <20250516101054.676046-3-p.raghav@samsung.com>
@ 2025-05-17 0:54 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2025-05-17 0:54 UTC (permalink / raw)
To: Pankaj Raghav; +Cc: llvm, oe-kbuild-all
Hi Pankaj,
[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:
[auto build test ERROR on 9e619cd4fefd19cdce16e169d5827bc64ae01aa1]
url: https://github.com/intel-lab-lkp/linux/commits/Pankaj-Raghav/mm-add-large-zero-page-for-efficient-zeroing-of-larger-segments/20250516-181327
base: 9e619cd4fefd19cdce16e169d5827bc64ae01aa1
patch link: https://lore.kernel.org/r/20250516101054.676046-3-p.raghav%40samsung.com
patch subject: [RFC 2/3] block: use LARGE_ZERO_PAGE in __blkdev_issue_zero_pages()
config: arm-randconfig-001-20250517 (https://download.01.org/0day-ci/archive/20250517/202505170820.pZo55E1i-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project f819f46284f2a79790038e1f6649172789734ae8)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250517/202505170820.pZo55E1i-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505170820.pZo55E1i-lkp@intel.com/
All errors (new ones prefixed by >>):
>> block/blk-lib.c:214:5: error: use of undeclared identifier 'ZERO_LARGE_PAGE_SIZE'
214 | ZERO_LARGE_PAGE_SIZE, nr_sects << SECTOR_SHIFT);
| ^
>> block/blk-lib.c:215:30: error: call to undeclared function 'ZERO_LARGE_PAGE'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
215 | added = bio_add_page(bio, ZERO_LARGE_PAGE(0), len, 0);
| ^
>> block/blk-lib.c:215:30: error: incompatible integer to pointer conversion passing 'int' to parameter of type 'struct page *' [-Wint-conversion]
215 | added = bio_add_page(bio, ZERO_LARGE_PAGE(0), len, 0);
| ^~~~~~~~~~~~~~~~~~
include/linux/bio.h:412:61: note: passing argument to parameter 'page' here
412 | int __must_check bio_add_page(struct bio *bio, struct page *page, unsigned len,
| ^
3 errors generated.
vim +/ZERO_LARGE_PAGE_SIZE +214 block/blk-lib.c
194
195 static void __blkdev_issue_zero_pages(struct block_device *bdev,
196 sector_t sector, sector_t nr_sects, gfp_t gfp_mask,
197 struct bio **biop, unsigned int flags)
198 {
199 while (nr_sects) {
200 unsigned int nr_vecs = __blkdev_sectors_to_bio_pages(nr_sects);
201 struct bio *bio;
202
203 bio = bio_alloc(bdev, nr_vecs, REQ_OP_WRITE, gfp_mask);
204 bio->bi_iter.bi_sector = sector;
205
206 if ((flags & BLKDEV_ZERO_KILLABLE) &&
207 fatal_signal_pending(current))
208 break;
209
210 do {
211 unsigned int len, added;
212
213 len = min_t(sector_t,
> 214 ZERO_LARGE_PAGE_SIZE, nr_sects << SECTOR_SHIFT);
> 215 added = bio_add_page(bio, ZERO_LARGE_PAGE(0), len, 0);
216 if (added < len)
217 break;
218 nr_sects -= added >> SECTOR_SHIFT;
219 sector += added >> SECTOR_SHIFT;
220 } while (nr_sects);
221
222 *biop = bio_chain_and_submit(*biop, bio);
223 cond_resched();
224 }
225 }
226
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread