Re: [PATCH RFC 7/9] iio: trigger: Add new API iio_trigger_attach_timestamp()

Re: [PATCH RFC 7/9] iio: trigger: Add new API iio_trigger_attach_timestamp()

[kernel test robot]

Hi Gyeyoung,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on 43a9eee06bf8a8535d8709b29379bec8cafcab56]

url:    https://github.com/intel-lab-lkp/linux/commits/Gyeyoung-Baek/iio-buffer-Fix-checkpatch-pl-warning/20250519-222930
base:   43a9eee06bf8a8535d8709b29379bec8cafcab56
patch link:    https://lore.kernel.org/r/20250519-timestamp-v1-7-fcb4f6c2721c%40gmail.com
patch subject: [PATCH RFC 7/9] iio: trigger: Add new API iio_trigger_attach_timestamp()
config: s390-randconfig-001-20250520 (https://download.01.org/0day-ci/archive/20250520/202505201045.dS4OfoSM-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project f819f46284f2a79790038e1f6649172789734ae8)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250520/202505201045.dS4OfoSM-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505201045.dS4OfoSM-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/iio/industrialio-trigger.c:305:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
     305 |         int ret;
         |             ^
   1 warning generated.


vim +/ret +305 drivers/iio/industrialio-trigger.c

3138e8998dbd8f Gyeyoung Baek 2025-05-19  299  
b14e7f938a5fa7 Gyeyoung Baek 2025-05-19  300  static int iio_poll_func_register(struct iio_poll_func *pf,
b14e7f938a5fa7 Gyeyoung Baek 2025-05-19  301  				  struct iio_trigger *trig)
b14e7f938a5fa7 Gyeyoung Baek 2025-05-19  302  {
b14e7f938a5fa7 Gyeyoung Baek 2025-05-19  303  	irq_handler_t tophalf = NULL;
b14e7f938a5fa7 Gyeyoung Baek 2025-05-19  304  	irq_handler_t bottomhalf = pf->thread;
b14e7f938a5fa7 Gyeyoung Baek 2025-05-19 @305  	int ret;
b14e7f938a5fa7 Gyeyoung Baek 2025-05-19  306  
b14e7f938a5fa7 Gyeyoung Baek 2025-05-19  307  	/*
b14e7f938a5fa7 Gyeyoung Baek 2025-05-19  308  	 * The consumer does not need timestamp.
b14e7f938a5fa7 Gyeyoung Baek 2025-05-19  309  	 * Just request raw irq handler.
b14e7f938a5fa7 Gyeyoung Baek 2025-05-19  310  	 */
b14e7f938a5fa7 Gyeyoung Baek 2025-05-19  311  	if (!pf->timestamp_enabled)
b14e7f938a5fa7 Gyeyoung Baek 2025-05-19  312  		goto out_request_irq;
b14e7f938a5fa7 Gyeyoung Baek 2025-05-19  313  
3138e8998dbd8f Gyeyoung Baek 2025-05-19  314  	/*
3138e8998dbd8f Gyeyoung Baek 2025-05-19  315  	 * The trigger supports grabbing timestamp.
3138e8998dbd8f Gyeyoung Baek 2025-05-19  316  	 * Just request raw irq handler.
3138e8998dbd8f Gyeyoung Baek 2025-05-19  317  	 */
3138e8998dbd8f Gyeyoung Baek 2025-05-19  318  	if (trig->early_timestamp) {
3138e8998dbd8f Gyeyoung Baek 2025-05-19  319  		ret = iio_trigger_attach_timestamp(trig, pf);
3138e8998dbd8f Gyeyoung Baek 2025-05-19  320  		pf->timestamp_type = IIO_TIMESTAMP_TYPE_TRIGGER;
3138e8998dbd8f Gyeyoung Baek 2025-05-19  321  		goto out_request_irq;
3138e8998dbd8f Gyeyoung Baek 2025-05-19  322  	}
3138e8998dbd8f Gyeyoung Baek 2025-05-19  323  
b14e7f938a5fa7 Gyeyoung Baek 2025-05-19  324  	if (trig->trig_type & IIO_TRIG_TYPE_POLL_NESTED) {
b14e7f938a5fa7 Gyeyoung Baek 2025-05-19  325  		bottomhalf = iio_pollfunc_bottom_half_wrapper;
b14e7f938a5fa7 Gyeyoung Baek 2025-05-19  326  		pf->timestamp_type = IIO_TIMESTAMP_TYPE_CONSUMER_BOTTOM_HALF;
b14e7f938a5fa7 Gyeyoung Baek 2025-05-19  327  	} else if (trig->trig_type & IIO_TRIG_TYPE_POLL) {
b14e7f938a5fa7 Gyeyoung Baek 2025-05-19  328  		tophalf = iio_pollfunc_top_half_wrapper;
b14e7f938a5fa7 Gyeyoung Baek 2025-05-19  329  		pf->timestamp_type = IIO_TIMESTAMP_TYPE_CONSUMER_TOP_HALF;
b14e7f938a5fa7 Gyeyoung Baek 2025-05-19  330  	} else {
b14e7f938a5fa7 Gyeyoung Baek 2025-05-19  331  		pr_err("Trigger does not set valid trig_type.");
b14e7f938a5fa7 Gyeyoung Baek 2025-05-19  332  		return -EINVAL;
b14e7f938a5fa7 Gyeyoung Baek 2025-05-19  333  	}
b14e7f938a5fa7 Gyeyoung Baek 2025-05-19  334  
b14e7f938a5fa7 Gyeyoung Baek 2025-05-19  335  out_request_irq:
b14e7f938a5fa7 Gyeyoung Baek 2025-05-19  336  	return request_threaded_irq(pf->irq, tophalf, bottomhalf,
b14e7f938a5fa7 Gyeyoung Baek 2025-05-19  337  				    pf->type, pf->name, pf);
b14e7f938a5fa7 Gyeyoung Baek 2025-05-19  338  }
b14e7f938a5fa7 Gyeyoung Baek 2025-05-19  339  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki