* Re: [PATCH net-next 1/5] net: bridge: mcast: explicitly track active state
[not found] <20250522195952.29265-2-linus.luessing@c0d3.blue>
@ 2025-05-23 9:44 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2025-05-23 9:44 UTC (permalink / raw)
To: Linus Lüssing, bridge
Cc: llvm, oe-kbuild-all, netdev, openwrt-devel, linux-kernel,
linux-doc, Nikolay Aleksandrov, Ido Schimmel, Ivan Vecera,
Jiri Pirko, Vladimir Oltean, Andrew Lunn, Jonathan Corbet,
Simon Horman, Paolo Abeni, Jakub Kicinski, Eric Dumazet,
David S . Miller, Kuniyuki Iwashima, Stanislav Fomichev,
Xiao Liang, Markus Stockhausen, Jan Hoffmann, Birger Koblitz,
Bjørn Mork, Linus Lüssing
Hi Linus,
kernel test robot noticed the following build errors:
[auto build test ERROR on net/main]
[also build test ERROR on linus/master v6.15-rc7 next-20250523]
[cannot apply to net-next/main horms-ipvs/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Linus-L-ssing/net-bridge-mcast-explicitly-track-active-state/20250523-040914
base: net/main
patch link: https://lore.kernel.org/r/20250522195952.29265-2-linus.luessing%40c0d3.blue
patch subject: [PATCH net-next 1/5] net: bridge: mcast: explicitly track active state
config: x86_64-buildonly-randconfig-004-20250523 (https://download.01.org/0day-ci/archive/20250523/202505231710.LnCUsJMF-lkp@intel.com/config)
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250523/202505231710.LnCUsJMF-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505231710.LnCUsJMF-lkp@intel.com/
All errors (new ones prefixed by >>):
>> net/bridge/br_multicast.c:1135:6: error: expected value in expression
1135 | #elif
| ^
>> net/bridge/br_multicast.c:1180:11: error: no member named 'ip6_active' in 'struct net_bridge_mcast'; did you mean 'ip4_active'?
1180 | brmctx->ip6_active = ip6_active;
| ^~~~~~~~~~
| ip4_active
include/trace/events/../../../net/bridge/br_private.h:161:10: note: 'ip4_active' declared here
161 | bool ip4_active;
| ^
2 errors generated.
vim +1135 net/bridge/br_multicast.c
1122
1123 static int br_ip6_multicast_check_active(struct net_bridge_mcast *brmctx,
1124 bool *active)
1125 {
1126 #if IS_ENABLED(CONFIG_IPV6)
1127 if (!__br_multicast_querier_exists(brmctx, &brmctx->ip6_other_query,
1128 true))
1129 *active = false;
1130
1131 if (brmctx->ip6_active == *active)
1132 return false;
1133
1134 return true;
> 1135 #elif
1136 *active = false;
1137 return false;
1138 #endif
1139 }
1140
1141 /**
1142 * __br_multicast_update_active() - update mcast active state
1143 * @brmctx: the bridge multicast context to check
1144 * @force_inactive: forcefully deactivate mcast active state
1145 * @extack: netlink extended ACK structure
1146 *
1147 * This (potentially) updates the IPv4/IPv6 multicast active state. And by
1148 * that enables or disables snooping of multicast payload traffic in fast
1149 * path.
1150 *
1151 * The multicast active state is set, per protocol family, if:
1152 *
1153 * - an IGMP/MLD querier is present
1154 * - for own IPv6 MLD querier: an IPv6 address is configured on the bridge
1155 *
1156 * And is unset otherwise.
1157 *
1158 * This function should be called by anything that changes one of the
1159 * above prerequisites.
1160 *
1161 * Return: 0 on success, a negative value otherwise.
1162 */
1163 static int __br_multicast_update_active(struct net_bridge_mcast *brmctx,
1164 bool force_inactive,
1165 struct netlink_ext_ack *extack)
1166 {
1167 bool ip4_active, ip6_active, ip4_changed, ip6_changed;
1168 int ret = 0;
1169
1170 lockdep_assert_held_once(&brmctx->br->multicast_lock);
1171
1172 ip4_active = !force_inactive;
1173 ip6_active = !force_inactive;
1174 ip4_changed = br_ip4_multicast_check_active(brmctx, &ip4_active);
1175 ip6_changed = br_ip6_multicast_check_active(brmctx, &ip6_active);
1176
1177 if (ip4_changed)
1178 brmctx->ip4_active = ip4_active;
1179 if (ip6_changed)
> 1180 brmctx->ip6_active = ip6_active;
1181
1182 return ret;
1183 }
1184
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread