Re: [PATCH] mmc: sdhci: Return void from sdhci_runtime_suspend_host() and sdhci_runtime_resume_host()

Re: [PATCH] mmc: sdhci: Return void from sdhci_runtime_suspend_host() and sdhci_runtime_resume_host()

[kernel test robot]

Hi Adrian,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on ulf-hansson-mmc-mirror/next v6.15 next-20250530]
[cannot apply to shawnguo/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Adrian-Hunter/mmc-sdhci-Return-void-from-sdhci_runtime_suspend_host-and-sdhci_runtime_resume_host/20250530-202113
base:   linus/master
patch link:    https://lore.kernel.org/r/20250530122018.37250-1-adrian.hunter%40intel.com
patch subject: [PATCH] mmc: sdhci: Return void from sdhci_runtime_suspend_host() and sdhci_runtime_resume_host()
config: i386-buildonly-randconfig-002-20250530 (https://download.01.org/0day-ci/archive/20250530/202505302212.ZprBxoVy-lkp@intel.com/config)
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250530/202505302212.ZprBxoVy-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505302212.ZprBxoVy-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/mmc/host/sdhci-esdhc-imx.c:2103:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
    2103 |         if (host->mmc->caps2 & MMC_CAP2_CQE) {
         |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/mmc/host/sdhci-esdhc-imx.c:2123:9: note: uninitialized use occurs here
    2123 |         return ret;
         |                ^~~
   drivers/mmc/host/sdhci-esdhc-imx.c:2103:2: note: remove the 'if' if its condition is always true
    2103 |         if (host->mmc->caps2 & MMC_CAP2_CQE) {
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/mmc/host/sdhci-esdhc-imx.c:2101:9: note: initialize the variable 'ret' to silence this warning
    2101 |         int ret;
         |                ^
         |                 = 0
   1 warning generated.


vim +2103 drivers/mmc/host/sdhci-esdhc-imx.c

04143fbaeb5799 Dong Aisheng      2016-07-12  2094  
2788ed42cdd755 Ulf Hansson       2016-07-27  2095  #ifdef CONFIG_PM
89d7e5c131228a Dong Aisheng      2013-11-04  2096  static int sdhci_esdhc_runtime_suspend(struct device *dev)
89d7e5c131228a Dong Aisheng      2013-11-04  2097  {
89d7e5c131228a Dong Aisheng      2013-11-04  2098  	struct sdhci_host *host = dev_get_drvdata(dev);
89d7e5c131228a Dong Aisheng      2013-11-04  2099  	struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
070e6d3ff5a696 Jisheng Zhang     2016-02-16  2100  	struct pltfm_imx_data *imx_data = sdhci_pltfm_priv(pltfm_host);
89d7e5c131228a Dong Aisheng      2013-11-04  2101  	int ret;
89d7e5c131228a Dong Aisheng      2013-11-04  2102  
bb6e358169bf62 BOUGH CHEN        2019-01-07 @2103  	if (host->mmc->caps2 & MMC_CAP2_CQE) {
bb6e358169bf62 BOUGH CHEN        2019-01-07  2104  		ret = cqhci_suspend(host->mmc);
bb6e358169bf62 BOUGH CHEN        2019-01-07  2105  		if (ret)
bb6e358169bf62 BOUGH CHEN        2019-01-07  2106  			return ret;
bb6e358169bf62 BOUGH CHEN        2019-01-07  2107  	}
bb6e358169bf62 BOUGH CHEN        2019-01-07  2108  
5ef4a6a3b9ceac Adrian Hunter     2025-05-30  2109  	sdhci_runtime_suspend_host(host);
89d7e5c131228a Dong Aisheng      2013-11-04  2110  
d38dcad4e7b48f Adrian Hunter     2017-03-20  2111  	if (host->tuning_mode != SDHCI_TUNING_MODE_3)
d38dcad4e7b48f Adrian Hunter     2017-03-20  2112  		mmc_retune_needed(host->mmc);
d38dcad4e7b48f Adrian Hunter     2017-03-20  2113  
3602785b341a95 Michael Trimarchi 2018-01-04  2114  	imx_data->actual_clock = host->mmc->actual_clock;
3602785b341a95 Michael Trimarchi 2018-01-04  2115  	esdhc_pltfm_set_clock(host, 0);
89d7e5c131228a Dong Aisheng      2013-11-04  2116  	clk_disable_unprepare(imx_data->clk_per);
89d7e5c131228a Dong Aisheng      2013-11-04  2117  	clk_disable_unprepare(imx_data->clk_ipg);
89d7e5c131228a Dong Aisheng      2013-11-04  2118  	clk_disable_unprepare(imx_data->clk_ahb);
89d7e5c131228a Dong Aisheng      2013-11-04  2119  
1c4989b000aeac BOUGH CHEN        2019-04-29  2120  	if (imx_data->socdata->flags & ESDHC_FLAG_PMQOS)
d1b98305916bc0 Rafael J. Wysocki 2020-02-12  2121  		cpu_latency_qos_remove_request(&imx_data->pm_qos_req);
1c4989b000aeac BOUGH CHEN        2019-04-29  2122  
89d7e5c131228a Dong Aisheng      2013-11-04  2123  	return ret;
89d7e5c131228a Dong Aisheng      2013-11-04  2124  }
89d7e5c131228a Dong Aisheng      2013-11-04  2125  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki