* Re: [RFC] vfio/type1: optimize vfio_unpin_pages_remote() for large folio
[not found] <20250605124923.21896-1-lizhe.67@bytedance.com>
@ 2025-06-05 23:24 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2025-06-05 23:24 UTC (permalink / raw)
To: lizhe.67; +Cc: llvm, oe-kbuild-all
Hi,
[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:
[auto build test ERROR on awilliam-vfio/next]
[also build test ERROR on awilliam-vfio/for-linus linus/master v6.15 next-20250605]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/lizhe-67-bytedance-com/vfio-type1-optimize-vfio_unpin_pages_remote-for-large-folio/20250605-205109
base: https://github.com/awilliam/linux-vfio.git next
patch link: https://lore.kernel.org/r/20250605124923.21896-1-lizhe.67%40bytedance.com
patch subject: [RFC] vfio/type1: optimize vfio_unpin_pages_remote() for large folio
config: s390-randconfig-002-20250606 (https://download.01.org/0day-ci/archive/20250606/202506060749.d93rQNLD-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250606/202506060749.d93rQNLD-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506060749.d93rQNLD-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/vfio/vfio_iommu_type1.c:778:14: error: call to undeclared function 'vpfn_pages'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
778 | locked += vpfn_pages(dma, iova, step);
| ^
drivers/vfio/vfio_iommu_type1.c:778:14: note: did you mean 'vma_pages'?
include/linux/mm.h:3590:29: note: 'vma_pages' declared here
3590 | static inline unsigned long vma_pages(struct vm_area_struct *vma)
| ^
1 error generated.
vim +/vpfn_pages +778 drivers/vfio/vfio_iommu_type1.c
761
762 static long vfio_unpin_pages_remote(struct vfio_dma *dma, dma_addr_t iova,
763 unsigned long pfn, unsigned long npage,
764 bool do_accounting)
765 {
766 long unlocked = 0, locked = 0;
767
768 while (npage) {
769 long step = get_step(pfn, npage);
770
771 /*
772 * Although the third parameter of put_pfns() is of type int,
773 * the value of step here will not exceed the range that int
774 * can represent. Therefore, it is safe to pass step.
775 */
776 if (put_pfns(pfn, dma->prot, step)) {
777 unlocked += step;
> 778 locked += vpfn_pages(dma, iova, step);
779 }
780 pfn += step;
781 iova += PAGE_SIZE * step;
782 npage -= step;
783 }
784
785 if (do_accounting)
786 vfio_lock_acct(dma, locked - unlocked, true);
787
788 return unlocked;
789 }
790
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread