* Re: [PATCH v10 2/7] reboot: hw_protection_trigger: use standardized numeric shutdown/reboot reasons instead of strings
[not found] <20250617094945.3619360-3-o.rempel@pengutronix.de>
@ 2025-06-17 20:41 ` kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2025-06-17 20:41 UTC (permalink / raw)
To: Oleksij Rempel, Sebastian Reichel, Srinivas Kandagatla,
Benson Leung, Tzung-Bi Shih, Daniel Lezcano
Cc: llvm, oe-kbuild-all, Oleksij Rempel, Matti Vaittinen,
Matti Vaittinen, Mark Brown, kernel, linux-kernel, Liam Girdwood,
Rafael J. Wysocki, Zhang Rui, Lukasz Luba, linux-pm,
Søren Andersen, Guenter Roeck, Ahmad Fatoum, Andrew Morton,
Linux Memory Management List, chrome-platform
Hi Oleksij,
kernel test robot noticed the following build warnings:
[auto build test WARNING on sre-power-supply/for-next]
[also build test WARNING on broonie-regulator/for-next chrome-platform/for-next chrome-platform/for-firmware-next linus/master v6.16-rc2 next-20250617]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Oleksij-Rempel/power-Extend-power_on_reason-h-for-upcoming-PSCRR-framework/20250617-175433
base: https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git for-next
patch link: https://lore.kernel.org/r/20250617094945.3619360-3-o.rempel%40pengutronix.de
patch subject: [PATCH v10 2/7] reboot: hw_protection_trigger: use standardized numeric shutdown/reboot reasons instead of strings
config: hexagon-randconfig-001-20250618 (https://download.01.org/0day-ci/archive/20250618/202506180402.ly0g2TQe-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250618/202506180402.ly0g2TQe-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506180402.ly0g2TQe-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/regulator/core.c:5280:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
5280 | default:
| ^
drivers/regulator/core.c:5280:2: note: insert '__attribute__((fallthrough));' to silence this warning
5280 | default:
| ^
| __attribute__((fallthrough));
drivers/regulator/core.c:5280:2: note: insert 'break;' to avoid fall-through
5280 | default:
| ^
| break;
1 warning generated.
vim +5280 drivers/regulator/core.c
5253
5254 /**
5255 * regulator_handle_critical - Handle events for system-critical regulators.
5256 * @rdev: The regulator device.
5257 * @event: The event being handled.
5258 *
5259 * This function handles critical events such as under-voltage, over-current,
5260 * and unknown errors for regulators deemed system-critical. On detecting such
5261 * events, it triggers a hardware protection shutdown with a defined timeout.
5262 */
5263 static void regulator_handle_critical(struct regulator_dev *rdev,
5264 unsigned long event)
5265 {
5266 enum psc_reason pscr;
5267
5268 if (!rdev->constraints->system_critical)
5269 return;
5270
5271 switch (event) {
5272 case REGULATOR_EVENT_UNDER_VOLTAGE:
5273 pscr = PSCR_UNDER_VOLTAGE;
5274 break;
5275 case REGULATOR_EVENT_OVER_CURRENT:
5276 pscr = PSCR_OVER_CURRENT;
5277 break;
5278 case REGULATOR_EVENT_FAIL:
5279 pscr = PSCR_REGULATOR_FAILURE;
> 5280 default:
5281 pscr = PSCR_UNKNOWN;
5282 }
5283
5284 hw_protection_trigger(pscr,
5285 rdev->constraints->uv_less_critical_window_ms);
5286 }
5287
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread